Re: [Koha-devel] DateTime->now usage

2019-05-01 Thread dcook
2019 5:30 PM To: koha-devel Subject: Re: [Koha-devel] DateTime->now usage Yup, I believe we should be consistently using dt_from_string too. Martin Renvoize <https://www.ptfs-europe.com> Development Team Manager Phone: +44 (0) 1483 378728 Mobil

Re: [Koha-devel] DateTime->now usage

2019-05-01 Thread Renvoize, Martin
Yup, I believe we should be consistently using dt_from_string too. *Martin Renvoize* Development Team Manager *Phone:* +44 (0) 1483 378728 *Mobile:* +44 (0) 7725 985 636 *Email:* martin.renvo...@ptfs-europe.com *Fax:* +44 (0) 800 756 6384 www.ptfs-europe.

Re: [Koha-devel] DateTime->now usage

2019-04-30 Thread Jonathan Druart
Hi, Yes, we must use dt_from_string. Note that some occurrences could stay as it: when the time_zone is passed. Cheers, Jonathan Le mar. 30 avr. 2019 à 12:59, Tomas Cohen Arazi a écrit : > > Hi, on testnig bug 22453 [1] I noticed that we do the wrong thing in many > places, actually: > > $ git

[Koha-devel] DateTime->now usage

2019-04-30 Thread Tomas Cohen Arazi
Hi, on testnig bug 22453 [1] I noticed that we do the wrong thing in many places, actually: $ git grep 'DateTime\->new' Do you agree we should be using dt_from_string instead? The consequences are for those having the DB server and/or the plack server running on some timezone and having koha-conf