Re: [Koha-devel] Bug 5636

2011-12-12 Thread MJ Ray
Paul Poulain > In this case (speaking as RM here, not as owner of the company > submitting the patch ;-) ), it should just be "passed QA", as it passes > the 3 questions: don't break existing behaviour, do what it announces, > consistent with existing feature & code. (double check if there can be

Re: [Koha-devel] Bug 5636

2011-12-12 Thread MJ Ray
Tomas Cohen Arazi > I think functionality should be included in C4 or Koha, and exposed by > both command-line tool and templated front-ends. Also, any > command-line tool should honour system preferences by default, and the > user be warned if using parameters others than default. I agree with t

Re: [Koha-devel] dontmerge preference

2011-12-12 Thread Frédéric Demians
> What should the manual say about the cron job? If it's not required > then I can say that, but I know that it's still there so I assume it > can be used and should be documented. Take a look at: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6094 and my comment: http://bugs.koha-c

Re: [Koha-devel] Bug 5636

2011-12-12 Thread Chris Nighswonger
On Mon, Dec 12, 2011 at 12:07 PM, Galen Charlton wrote: > Hi, > > Such an attack may be more theoretical than real, but my preference would > be that if a script's logic should be accessible from the command line and > the web interface, to put the logic in the API and have the CGI and CLI > scri

Re: [Koha-devel] Bug 5636

2011-12-12 Thread Chris Cormack
On 13 December 2011 06:11, LAURENT Henri-Damien wrote: >> > Hi, > in my opinion, it is not "dual-purpose" script, > command-line or web interface, it is the same process you want. > duplicating code and editing to make the code commandline compliant > would be far harder to maintain and keep sync

Re: [Koha-devel] Bug 5636

2011-12-12 Thread LAURENT Henri-Damien
Le 12/12/2011 17:24, Ian Walls a écrit : > My difficulty with this patch is that it sets precedent for implementing > both commandline and staff client interfaces for a single script. Up > until now, that's not be the case (as far as my research has shown; > counter-examples welcome). I just thin

Re: [Koha-devel] Bug 5636

2011-12-12 Thread Galen Charlton
Hi, On 12/12/2011 11:24 AM, Ian Walls wrote: My difficulty with this patch is that it sets precedent for implementing both commandline and staff client interfaces for a single script. Up until now, that's not be the case (as far as my research has shown; counter-examples welcome). I just think

Re: [Koha-devel] Bug 5636

2011-12-12 Thread Jared Camins-Esakov
Ian, My difficulty with this patch is that it sets precedent for implementing > both commandline and staff client interfaces for a single script. Up until > now, that's not be the case (as far as my research has shown; > counter-examples welcome). I just think we need, for consistency sake, to >

[Koha-devel] dontmerge preference

2011-12-12 Thread Nicole Engard
I need some assistance in documenting this preference: http://manual.koha-community.org/3.6/en/administration.html#dontmerge It says that the cron is required, but apparently its not: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7347 What should the manual say about the cron job? If

Re: [Koha-devel] Bug 5636

2011-12-12 Thread Paul Poulain
Le 12/12/2011 17:24, Ian Walls a écrit : > My difficulty with this patch is that it sets precedent for implementing > both commandline and staff client interfaces for a single script. Up > until now, that's not be the case (as far as my research has shown; > counter-examples welcome). I just thin

[Koha-devel] Jenkins back to unstable !

2011-12-12 Thread Paul Poulain
Hello (chris_c & others) Jenkins is back to unstable, because of XISBN.t test. build 562 was stable, and 563 is not, and I can't see where the problem can come from. BREAKING NEWS : (just before sending this mail) build 565 is stable again. The patch I pushed can't explain why we're stable. I'm r

Re: [Koha-devel] Bug 5636

2011-12-12 Thread Ian Walls
My difficulty with this patch is that it sets precedent for implementing both commandline and staff client interfaces for a single script. Up until now, that's not be the case (as far as my research has shown; counter-examples welcome). I just think we need, for consistency sake, to either make t

Re: [Koha-devel] Bug 5636

2011-12-12 Thread Paul Poulain
Le 12/12/2011 14:06, Marcel de Rooy a écrit : > Hi all, > Patch 5636 should be next in passing qa now, but these questions > remained open: > Style question to the community: should core pages in the staff client > (like > > tools/cleanborrowers.pl) have both a templated page in the staff client

Re: [Koha-devel] Bug 5636

2011-12-12 Thread Tomas Cohen Arazi
2011/12/12 Marcel de Rooy : > Hi all, > > > > Patch 5636 should be next in passing qa now, but these questions remained > open: > > > > Style question to the community:  should core pages in the staff client > (like > > tools/cleanborrowers.pl) have both a templated page in the staff client AND > a

Re: [Koha-devel] Bug 5636

2011-12-12 Thread Zeno Tajoli
Hi all, Il 12/12/2011 14:06, Marcel de Rooy ha scritto: > Patch 5636 should be next in passing qa now, but these questions remained > open: > > Style question to the community: should core pages in the staff client (like > tools/cleanborrowers.pl) have both a templated page in the staff client

[Koha-devel] Bug 5636

2011-12-12 Thread Marcel de Rooy
Hi all, Patch 5636 should be next in passing qa now, but these questions remained open: Style question to the community: should core pages in the staff client (like tools/cleanborrowers.pl) have both a templated page in the staff client AND a command-line presence, or should the commandline tool

[Koha-devel] FW: A few patches waiting for your signature...

2011-12-12 Thread Marcel de Rooy
Just to mention another patch that I wrote myself ;) 6536 Z3950 Enhancements: SRU targets, MARC conversion, additional XSLT processing The functionality patch dates from June 30, but still applies. (We use it in production for 6 months now already!) The dbrev patch has been rebased last time