not add any more non-board related information the board
> file format than is already there. This state information could be
> saved in the project file or the application config file. My preference
> is the project file but it's not a strong preference.
>
> >
> > If
r explicitly not going in to version control.
-Jon
On Thu, Feb 22, 2018 at 12:15 PM, Andy Peters wrote:
>
> On Feb 22, 2018, at 7:58 AM, Jon Evans wrote:
>
>
> Currently some of the render visibility stuff is saved in the application
> preferences, and some is not saved.
>
Also broken on MacOS. Hashing of enum types (and therefore using them as
unordered_map keys) doesn't work on all compilers until C++14. Patch
attached that should fix it (tested on MacOS)
On Thu, Feb 22, 2018 at 1:05 PM, Foo Barmann wrote:
> Hi,
> while trying to compile the current kicad so
Yes, looks like your fix will work too!
On Thu, Feb 22, 2018 at 3:19 PM, jp charras wrote:
> Le 22/02/2018 à 21:15, Jon Evans a écrit :
> > Also broken on MacOS. Hashing of enum types (and therefore using them
> as unordered_map keys)
> > doesn't work on all compil
Thanks.
>
>
> On 02/21/2018 11:39 PM, Jon Evans wrote:
>
>> Hi all,
>>
>> This patch rearranges the Render panel to be in a more logical order, and
>> adds some whitespace.
>> I divided it into three groupings:
>> 1) footprint related
>> 2) othe
Fixing a small bug in my recently-merged patch
That'll teach me to try to do 3 things at once ;-)
From 08ab7228870df603589c8f476c704b0435fd43fa Mon Sep 17 00:00:00 2001
From: Jon Evans
Date: Thu, 22 Feb 2018 19:14:27 -0500
Subject: [PATCH] Fix assert on GerbView launch
---
pcbnew/layer_wid
Is there already a bug report for that? We should make sure to keep track
of all this so if someone has time to do some kind of settings-saving
overhaul for V6 we catch all of that stuff.
On Thu, Feb 22, 2018 at 7:31 PM, José Ignacio wrote:
> One thing that is very inconsistent is that layer se
Fixes: https://bugs.launchpad.net/kicad/+bug/1747443
-Jon
From 781adc8252bace405d30ba9e8878265fac73be4e Mon Sep 17 00:00:00 2001
From: Jon Evans
Date: Thu, 22 Feb 2018 19:31:51 -0500
Subject: [PATCH] Clear out old layer data when loading on top of an existing
image
Fixes: lp:1747443
* https
Hi JP, good catch, the attached fixes it for me
-Jon
On Fri, Feb 23, 2018 at 7:18 AM, jp charras wrote:
> Le 23/02/2018 à 01:04, Jon Evans a écrit :
> > Here are two more quick patches addressing some of the easier changes.
> > I have some other bugs to look at that seem more
If you add a call to ReFillRender() at the top
of PCB_LAYER_WIDGET::SyncRenderStates() instead of my change, does it fix
it?
On Fri, Feb 23, 2018 at 9:54 AM, jp charras wrote:
> Le 23/02/2018 à 14:24, Jon Evans a écrit :
> > Hi JP, good catch, the attached fixes it for me
>
ow if this
makes sense to you also.
Thanks,
-Jon
On Fri, Feb 23, 2018 at 10:05 AM, jp charras wrote:
> Le 23/02/2018 à 15:57, Jon Evans a écrit :
> > If you add a call to ReFillRender() at the top of
> > PCB_LAYER_WIDGET::SyncRenderStates()
> instead of my
> > change
tand the distinction, but shouldn’t we name them Front SMD Pads and
> Back SMD Pads to make it clearer?
>
> Cheers,
> Jeff.
>
> > On 23 Feb 2018, at 15:35, jp charras wrote:
> >
> > Le 23/02/2018 à 16:12, Jon Evans a écrit :
> >> You can comm
Yes, this is not really a bug. The behavior of the "draw polygon" tool is
the same as the zone tool on non-copper layers used to be.
On Fri, Feb 23, 2018 at 6:49 PM, Seth Hillbrand
wrote:
> The graphical polygon tool works for non-copper layers.
>
> Andrzej, does this tool not work?
>
> -S
>
>
I went back to an older version of master (back around September of last
year) and I can't make a zone on a non-copper layer that behaves like a
copper zone. Even when using the zone tool, they behave like graphic
polygons.
Were you able to do this up until Orson's recent change? If so, how do yo
aybe there's a use-case I'm missing?
>
> -S
>
> 2018-02-23 16:26 GMT-08:00 Jon Evans :
>
>> I went back to an older version of master (back around September of last
>> year) and I can't make a zone on a non-copper layer that behaves like a
>> copper zon
OK, yeah it does look like some things are no longer possible, so it makes
sense to wait until Orson wakes up to this barrage of emails :)
On Feb 23, 2018 20:07, "Andrzej Wolski" wrote:
>
> Was it ever possible to run the fill algorithm (meaning, only fill in
>> parts of a polygon outline, based
I agree with this! It has always tripped me up when I switch back and forth
between kicad and other EDA tools.
On Feb 24, 2018 9:31 AM, "Diego Herranz"
wrote:
> Hi,
>
> Now that so much work is happening on re-structuring menus, I've
> remembered something I have always found weird on pcbnew.
>
d paths, but if I apply this patch, everything
seems to work regardless)
-Jon
From 8acee9dcd85083406ee1919fdb3e1dffb5d696a4 Mon Sep 17 00:00:00 2001
From: Jon Evans
Date: Sat, 24 Feb 2018 12:16:58 -0500
Subject: [PATCH] Make sure the footprint cache exists in
LoadEnumeratedFootpri
to this, but the second one will kill performance.
> I’ve got a slightly different one baking….
>
> Cheers,
> Jeff.
>
>
> On 24 Feb 2018, at 17:18, Jon Evans wrote:
>
> See: https://bugs.launchpad.net/kicad/+bug/1751464
>
> The first one is simple; m_Layers wasn
All set. Included here for reference
On Sat, Feb 24, 2018 at 1:09 PM, Jeff Young wrote:
> Hi Jon,
>
> Cool. You want to attach that one to the bug?
>
> Cheers,
> Jeff.
>
>
> On 24 Feb 2018, at 17:55, Jon Evans wrote:
>
> Yes it definitely is specific to some
le the later goes through the Print code.
>
> Do we need both? I haven’t a clue.
>
> It would be nice to clean this stuff up, if there is in fact a clean way
> to present it.
>
> Cheers,
> Jeff.
>
>
> On 24 Feb 2018, at 14:54, Jon Evans wrote:
>
> I agree with
Yes I think that's the plan, just needs someone to sign up to write it :)
On Sat, Feb 24, 2018, 14:00 Andrzej Wolski wrote:
> Cairo have PDF, SVG and Postscript support. I was once wondering if
> GAL/Cairo could be used for printing.
>
> Andrzej
>
> W dniu 2018-02-24 o
it has been discussed. The only downside is
> that we will have to write our own print handling on windows and I'm
> guessing macos. That's one of the reasons no one has signed up yet because
> it will be a large undertaking.
> >
> > On 02/24/2018 02:02 PM, Jon Evans w
I would also recommend keeping 5.0 in master (and just use tags for the
RCs) to keep things simpler. I think we don't have enough committers and QA
process to handle two parallel branches. Like Jeff said, anyone working on
6.0 stuff can just keep it in a private branch a little longer.
-Jon
On Sa
GerbView.
-Jon
From 47b143f347d55c7608afd8aba087ed324cfb74da Mon Sep 17 00:00:00 2001
From: Jon Evans
Date: Sun, 25 Feb 2018 12:38:35 -0500
Subject: [PATCH] Fix regression in GerbView display settings; some
optimization too
---
common/view/view.cpp | 14 ++
gerbview
Fixes: https://bugs.launchpad.net/kicad/+bug/1751589
From c8e31559693753a6fd9cfaab29c5d77e01122a7b Mon Sep 17 00:00:00 2001
From: Jon Evans
Date: Sun, 25 Feb 2018 12:52:52 -0500
Subject: [PATCH] Refactor post-load actions in PcbNew and apply them
consistently
Fixes: lp:1751589
* https
Fixes: https://bugs.launchpad.net/kicad/+bug/1751183
From 6a9a7cd6a2cfd2faa59cdf352e5f8676bea4853c Mon Sep 17 00:00:00 2001
From: Jon Evans
Date: Sun, 25 Feb 2018 13:30:59 -0500
Subject: [PATCH] Make all new hotkeys editable; label some GAL-only hotkeys
Fixes: lp:1751183
* https
These patches improves redraw performance when toggling sketch/filled draw
modes.
On Linux at least, the difference is quite noticeable on complicated Gerber
files.
-Jon
From 04cb51708ff6f46773b3f1acad2b8b8e9adf2db6 Mon Sep 17 00:00:00 2001
From: Jon Evans
Date: Sun, 25 Feb 2018 15:14:28 -0500
number of items in the view).
-Jon
From a7bda21efef9ca6eee250ea3ce420d058b3cf354 Mon Sep 17 00:00:00 2001
From: Jon Evans
Date: Sun, 25 Feb 2018 15:38:05 -0500
Subject: [PATCH] Don't use the RTREE in UpdateAllLayersOrder() /
UpdateAllLayersColor()
Since we are going to inspect every item for
One more performance patch for GerbView attached
On Sun, Feb 25, 2018 at 3:14 PM, Jon Evans wrote:
> These patches improves redraw performance when toggling sketch/filled draw
> modes.
>
> On Linux at least, the difference is quite noticeable on complicated
> Gerber files.
Fixes: https://bugs.launchpad.net/kicad/+bug/1751646
From e648158336af3f90c41bf17a9a2b387b5b095191 Mon Sep 17 00:00:00 2001
From: Jon Evans
Date: Sun, 25 Feb 2018 18:17:59 -0500
Subject: [PATCH] Ensure ROUTER_PREVIEW_ITEM draws on top of all normal layers
Fixes: lp:1751646
* https
Hi Clemens, do these files have Gerber X2 attributes? What process did you
use to load them? (i.e. did you load one at a time; use a Gerber job file,
load them all at once, etc)?
Thanks,
Jon
On Sun, Feb 25, 2018 at 6:15 PM, Clemens Koller wrote:
> Hi!
>
> I am not absolutely sure what's going
Gerber File... - Shift-Clicking
> on the files in the order I want to load them - Open.
>
> (I need to click #no of file times to dismiss the warning dialog box
> because of the proprietary format "%FSDAX33Y33*%", which is annoying, btw.)
>
> Regards,
>
> Clemens
&g
Hmm, can't reproduce on Linux (when loading job file, it successfully finds
the Gerbers in the same directory as the job file)
Do you have the ability to build a debug build and get a stack trace of the
crash?
-Jon
On Sun, Feb 25, 2018 at 7:02 PM, Andy Peters wrote:
> On macOS High Sierra, lat
And one final performance patch for now
On Sun, Feb 25, 2018 at 6:56 PM, Jon Evans wrote:
> One more performance optimization attached
>
> Clemens -- are you talking to me directly? For most of my smaller fixes I
> do not push them to anywhere public before they get merged. Wa
, Feb 25, 2018 at 6:49 PM, Clemens Koller wrote:
> What is the quickest way to git pull your changes when I want to follow
> you in real-time?
>
> git.launchpad.net/kicad ?
>
> On 2018-02-26 00:39, Wayne Stambaugh wrote:
> > Patches merged. Thanks!
> >
> > On
I'm still trying to debug the crash, but the attached patch should fix the
files not found issue.
On Sun, Feb 25, 2018 at 7:16 PM, Andy Peters wrote:
>
>
> On Feb 25, 2018, at 5:11 PM, Jon Evans wrote:
>
> Hmm, can't reproduce on Linux (when loading job file, it
OK, got the crash bug too.
On Sun, Feb 25, 2018 at 8:12 PM, Jon Evans wrote:
> I'm still trying to debug the crash, but the attached patch should fix the
> files not found issue.
>
> On Sun, Feb 25, 2018 at 7:16 PM, Andy Peters wrote:
>
>>
>>
>> On Feb
To be honest I'm not sure I think those options should even be in the
context menu, especially when you have selected an item. They are already
on the toolbar and have hotkeys.
But maybe some people use them and would be sad if we removed them :)
On Sun, Feb 25, 2018 at 9:27 PM, Andrey Kuznetsov
ddress sanitizer report for details.
>
> Regards,
> Orson
>
> On 02/25/2018 10:01 PM, Jon Evans wrote:
> > This patch uses simple iteration instead of the RTREE search to update
> the
> > layer order and color in VIEW. On my Linux system, this results in a
>
Hi Wayne, just a reminder there are two more patches here, sorry about the
high volume of email.
Thanks,
Jon
On Sun, Feb 25, 2018 at 7:23 PM, Wayne Stambaugh
wrote:
> Patch merged. Thanks.
>
> On 02/25/2018 04:07 PM, Jon Evans wrote:
>
>> One more performance patch for
ne mode.
> >>>
> >>> Cheers,
> >>>
> >>> Wayne
> >>>
> >>> On 2/26/2018 5:01 AM, Maciej Sumiński wrote:
> >>>> Jon,
> >>>>
> >>>> With this patch applied, any layer switching in
In the case that there is a separate installer for the libraries (which I
also think makes sense), maybe those line items should be removed from the
main installer instead of just disabled (if that is easy) to reduce
confusion?
On Mon, Feb 26, 2018 at 12:42 PM, Wayne Stambaugh
wrote:
> On 2/26/2
Re-sending these since they may have gotten lost in the other thread.
These fix some bugs Andy Peters found on GerbView MacOS.
-Jon
0001-Fix-edge-case-GERBER_FILE_IMAGE-creation-logic.patch
Description: Binary data
0001-Use-proper-path-when-loading-files-from-Gerber-job-f (1).patch
Description
Reproduced on Linux, and reported here:
https://bugs.launchpad.net/kicad/+bug/1751960
On Mon, Feb 26, 2018 at 7:27 PM, Andy Peters wrote:
> This uses last night’s nightly (macOS).
>
> I imported a DXF file into the Cmts.User layer (nothing else is on it) and
> I need to move it into a specific l
smaller one is just a fix to redraw negative items when their
visibility is toggled.
-Jon
From 30664c1ef39a3e9898b7ca732d3b9c0a97264318 Mon Sep 17 00:00:00 2001
From: Jon Evans
Date: Mon, 26 Feb 2018 21:15:32 -0500
Subject: [PATCH] GerbView: Implement in-place GAL layer reordering (for X2
sorting
> Shift-Clicking on the files in the order I want to load them - Open.
> >
> > (I need to click #no of file times to dismiss the warning dialog box
> because of the proprietary format "%FSDAX33Y33*%", which is annoying, btw.)
> >
> > Regards,
> &g
801 - 847 of 847 matches
Mail list logo
