Re: [Kicad-developers] Pulling mac 5.0.2...

2019-01-08 Thread Adam Wolf
Hi Wayne, I need a judgement call, and it's a little urgent. The current Mac packages call themselves 5.0.2, but the version information inside is Version: (5.0.2-4-g3082e92af), release build. This is because there are 4 patches applied to the 5.0.2 source during packaging. These are exclusivel

Re: [Kicad-developers] [KiCad-developers] Hoping to contribute but I have some questions

2019-01-08 Thread Brian Piccioni
Seth That certainly is much simpler! After doing some experimentation, if I manually update the schematic and push an update to the PCB using "Match Footprints by Timestamp" I retain the component connectivity, etc., and only change the reference designation, which is the desired effect. The

Re: [Kicad-developers] Pulling mac 5.0.2...

2019-01-08 Thread Wayne Stambaugh
Hey Adam, Rather than committing the macos build patches to the git repo, why not just run patch from the build script to apply them? This way you don't taint the git repo commit log and the version string will be 5.0.2 assuming that it the branch that you are building. This is how we have done

[Kicad-developers] [PATCH] Wildcard tests + removed variadic interface

2019-01-08 Thread John Beard
Hi, Here are some patches for wildcards: * Add some tests to demo the API and expected output. * Remove a variadic function signature and replace with one that takes a std::vector. This allows better and more typesafe use of this API at run time. * Unify the "all files" wildcard handling. Avoids

Re: [Kicad-developers] Pulling mac 5.0.2...

2019-01-08 Thread Adam Wolf
Thanks Wayne. Will do. I appreciate your fast response. Adam On Tue, Jan 8, 2019 at 7:58 AM Wayne Stambaugh wrote: > Hey Adam, > > Rather than committing the macos build patches to the git repo, why not > just run patch from the build script to apply them? This way you don't > taint the git

Re: [Kicad-developers] [KiCad-developers] Hoping to contribute but I have some questions

2019-01-08 Thread Wayne Stambaugh
Seth, This seems backwards to me. Geographical references are generated at the board level so the references changes have to be pushed from the board to the schematic not the other way around. This requires the following steps: 1) Create a netlist from the board editor. 2 preferred) Send netlis

Re: [Kicad-developers] Pulling mac 5.0.2...

2019-01-08 Thread Adam Wolf
Alright. Those changes are made. I am doing builds now. They are going to be 5.0.2-5 in order to ... reduce confusion. After builds, I need to upload them to testing/, download them, run them through a test procedure that's in the README, and then see if this fixes the issues for users. If so,

Re: [Kicad-developers] [PATCH] Wildcard tests + removed variadic interface

2019-01-08 Thread Seth Hillbrand
Am 2019-01-08 09:16, schrieb John Beard: Hi, Here are some patches for wildcards: * Add some tests to demo the API and expected output. * Remove a variadic function signature and replace with one that takes a std::vector. This allows better and more typesafe use of this API at run time. * Unify

Re: [Kicad-developers] [PATCH] Wildcard tests + removed variadic interface

2019-01-08 Thread John Beard
Hi Seth, Good idea - I was just moving what the code currently did, but sounds like a sensible fix. I'll amend patch 0003. Does it otherwise work on Windows? Cheers, John On Tue, Jan 8, 2019 at 4:36 PM Seth Hillbrand wrote: > > Am 2019-01-08 09:16, schrieb John Beard: > > Hi, > > > > Here are

Re: [Kicad-developers] [PATCH] Wildcard tests + removed variadic interface

2019-01-08 Thread Seth Hillbrand
Am 2019-01-08 11:46, schrieb John Beard: Hi Seth, Good idea - I was just moving what the code currently did, but sounds like a sensible fix. I'll amend patch 0003. Does it otherwise work on Windows? Unfortunately, I don't have a Windows setup so we'll need to wait for an available Windows te

Re: [Kicad-developers] [PATCH] Wildcard tests + removed variadic interface

2019-01-08 Thread John Beard
Hi Seth, Here are updated patches (only #3 is changed). I have still hardcoded the expected results in the test, otherwise it'll be a fairly opaque test of two copy-pasted lines. The windows filter is now " (*.*)|*.*": is that right? Cheers, John On Tue, Jan 8, 2019 at 4:48 PM Seth Hillbrand

Re: [Kicad-developers] [KiCad-developers] Hoping to contribute but I have some questions

2019-01-08 Thread Seth Hillbrand
Am 2019-01-08 09:46, schrieb Wayne Stambaugh: Seth, This seems backwards to me. Geographical references are generated at the board level so the references changes have to be pushed from the board to the schematic not the other way around. This requires the following steps: 1) Create a netlist

[Kicad-developers] [PATCH] Wrong windows macro

2019-01-08 Thread John Beard
Hi, Quick patch for a misuse of __WXWINDOWS__ for checking the presence of Windows. The correct macro is __WINDOWS__ or __WXMSW__ in GUI programs. __WXWINDOWS__ is always set, on all platforms. The alternative is to remove the ifdef entirely, as this is not a big issue to do on non-windows platf

Re: [Kicad-developers] [PATCH] Wildcard tests + removed variadic interface

2019-01-08 Thread jp charras
Le 08/01/2019 à 18:35, John Beard a écrit : > Hi Seth, > > Here are updated patches (only #3 is changed). > > I have still hardcoded the expected results in the test, otherwise > it'll be a fairly opaque test of two copy-pasted lines. > > The windows filter is now " (*.*)|*.*": is that right? >

[Kicad-developers] Build failed in Jenkins: linux-kicad-full-gcc-head #4494

2019-01-08 Thread Miguel Angel Ajo
See Changes: [hillbrand] eeschema: Simplify netlist dialog [hillbrand] units: Move common units and add tests [hillbrand] pcbnew: Allow capture of non-highlighted items -

[Kicad-developers] Build failed in Jenkins: linux-kicad-full-gcc-head #4495

2019-01-08 Thread Miguel Angel Ajo
See Changes: [hillbrand] Don't start autopan if the cursor was warped [hillbrand] pcbnew: Don't use frame refresh to update display -- [...truncated 155.76 KB...]

Re: [Kicad-developers] [KiCad-developers] Hoping to contribute but I have some questions

2019-01-08 Thread Brian Piccioni
Well, that's a pity. I was hoping to be able to help but I rather doubt that would be possible because by the time back-annotation is in place I won't have the time to learn the code well enough to contribute. Mind you I am of the school that a good plan today is better than a perfect plan tomorro

Re: [Kicad-developers] [KiCad-developers] Hoping to contribute but I have some questions

2019-01-08 Thread Seth Hillbrand
Am 2019-01-08 17:55, schrieb Brian Piccioni: If there are other non-critical sub-projects I could work on in order to learn, I'd be keen to have the opportunity. Here is a link[1] to the outstanding bugs that need to be addressed prior to version 5.1. If you'd like to hurry along the develop

Re: [Kicad-developers] [KiCad-developers] Hoping to contribute but I have some questions

2019-01-08 Thread Brian Piccioni
Seth I have read the style guide and it more or less conforms with my usual way of doing things. The major change is the use of spaces vs tabs, which is just a setting on my editor, and the way I always signal global variables is slightly different. I also use a lot if inline comments. If you cou

Re: [Kicad-developers] [KiCad-developers] Hoping to contribute but I have some questions

2019-01-08 Thread Seth Hillbrand
Am 2019-01-08 18:37, schrieb Brian Piccioni: Seth I have read the style guide and it more or less conforms with my usual way of doing things. The major change is the use of spaces vs tabs, which is just a setting on my editor, and the way I always signal global variables is slightly differen

[Kicad-developers] Build failed in Jenkins: linux-kicad-full-gcc-head #4496

2019-01-08 Thread Miguel Angel Ajo
See Changes: [hillbrand] pcbnew: Don't knock out thermals for non-conn zone [hillbrand] ratsnest: Calculate ratsnest per pad [hillbrand] Remove errant printf() debugging statement --

Re: [Kicad-developers] [PATCH] Wildcard tests + removed variadic interface

2019-01-08 Thread Wayne Stambaugh
John, Would you please rebase your patches? Patch 0001 no longer applies cleaning. Apparently someone made a change the caused a conflict before I could get around to merging them. Thanks, Wayne On 1/8/2019 12:35 PM, John Beard wrote: > Hi Seth, > > Here are updated patches (only #3 is chang

[Kicad-developers] Build failed in Jenkins: linux-kicad-full-gcc-head #4497

2019-01-08 Thread Miguel Angel Ajo
See -- [...truncated 155.62 KB...] Scanning dependencies of target kicad-ogltest [ 89%] Building CXX object pcbnew/CMakeFiles/pcbnew_kiface_objects.dir/footprint_libraries_utils.

Re: [Kicad-developers] [RFC] Symbol library file format

2019-01-08 Thread Andrew Lutsenko
Hi again, I just pushed an example of some proto definitions and a code that shows how to write it. Take a look at https://github.com/qu1ck/kicad-source-mirror/tree/proto/proto I modeled symbol.proto after what is currently in the eeschema format proposal google doc but it's not completely 1:1 be