[Kicad-developers] [PATCH] Make doc extension (pdf) are not case sensitive.

2017-01-22 Thread Константин Барановский
By default in Linux, KiCad opens pdf-files in GIMP (on my system), so I setup it to open pdf with another app and it works if extension of the doc in lower case (pdf). But if extension in upper case (PDF), KiCad still opens it in GIMP. In attachment the patch that resolves this issue. From 0142a560

Re: [Kicad-developers] [PATCH] Make doc extension (pdf) are not case sensitive.

2017-01-22 Thread Chris Pavlina
Merged, thank you. On Sun, Jan 22, 2017 at 04:45:31PM +0200, Константин Барановский wrote: > By default in Linux, KiCad opens pdf-files in GIMP (on my system), so I > setup it to open pdf with another app and it works if extension of the doc > in lower case (pdf). But if extension in upper case (P

Re: [Kicad-developers] [PATCH] Tidy consts in D_PAD

2017-01-22 Thread Chris Pavlina
Merged. Thank you. On Sun, Jan 22, 2017 at 06:32:52AM +0800, John Beard wrote: > Hi, > > There are a few accessors in D_PAD that could do with const qualifiers. > > Also a few functions return non-POD objects by const value. This > doesn't actually acheive anything, except forcing the compiler t

Re: [Kicad-developers] [PATCH] C++14-style std::make_unique for C++11

2017-01-22 Thread Chris Pavlina
After reading about the application of std::make_unique, I like it; I am not opposed to merging this. I would, however, be in favor of modifying it slightly to emit a warning or error if built under C++14, so that it is not forgotten if and when we do make the transition to C++14 in the future. Is

[Kicad-developers] Jenkins build is back to normal : kicad-qa #2211

2017-01-22 Thread Miguel Angel Ajo
See ___ Mailing list: https://launchpad.net/~kicad-developers Post to : kicad-developers@lists.launchpad.net Unsubscribe : https://launchpad.net/~kicad-developers More help : https://help.launchp

[Kicad-developers] V5 features confusion

2017-01-22 Thread Jon Neal
This is mostly directed at Wayne: I read through your FOSDEM slides that you showed on hackaday recently ( https://drive.google.com/file/d/0B8ng6CtJ1Hh6NU11UTRrbzZBYjg/view). It looks like you included support for via stitching, removal of the legacy canvas. I'm quite surprised at this since neit

Re: [Kicad-developers] V5 features confusion

2017-01-22 Thread Wayne Stambaugh
This was only a preliminary draft, not final draft which I am still working on. The legacy canvas is not going to be removed during this dev cycle. Via stitching is still planned but that could change. We may have to move the feature freeze back because I still want to get the new schematic file

Re: [Kicad-developers] [PATCH] C++14-style std::make_unique for C++11

2017-01-22 Thread Wayne Stambaugh
I'm not opposed but I agree with your assessment that it needs to not build when c++14 is defined. Is this something that devs are going to use or is something we can push off until we are actually a c++14 project? On 1/22/2017 10:51 AM, Chris Pavlina wrote: > After reading about the application

[Kicad-developers] Dialog SetFocus patches for OSX

2017-01-22 Thread Diogo Condeço
Hi all, I've attached 2 patches for some SetFocus optimisations on Macos. Tested also on Linux where there wasn't the issue, and it is still ok. This was a macos specific problem... 0001 fixes the find dialog and pad_properties dialog on pcbnew 0002 fixes add_component dialog on eeschema I've us

Re: [Kicad-developers] Dialog SetFocus patches for OSX

2017-01-22 Thread Wayne Stambaugh
Would one of our osx devs test these patches and let me know if I should commit them. I don't see any coding policy violations so as long as they fix the problems on osx then I will commit them. Thanks, Wayne On 1/22/2017 5:52 PM, Diogo Condeço wrote: > Hi all, > > I've attached 2 patches for

[Kicad-developers] Fwd: [PATCH] C++14-style std::make_unique for C++11

2017-01-22 Thread John Beard
FWD to list -- Forwarded message -- From: John Beard Date: Mon, Jan 23, 2017 at 8:36 AM Subject: Re: [Kicad-developers] [PATCH] C++14-style std::make_unique for C++11 To: Wayne Stambaugh The idea with std::make_unique is essentially that when making std::unique_ptrs, you never

[Kicad-developers] [PATCH] Move PostCommandMenuEvent to EDA_BASE_FRAME

2017-01-22 Thread John Beard
Hi, This is a small patch to move PostCommandMenuEvent up to EDA_BASE_FRAME, from PCB_BASE_EDIT_FRAME. This function has nothing intristic to PCB edit frames, it would apply to any frame. I'd like to use it for code that works in both Pcbnew and Cvpcb, which have EDA_BASE_FRAME as the first suita

[Kicad-developers] [PATCH] Allow editing locked modules in modedit

2017-01-22 Thread John Beard
This patch makes it possible to edit locked modules in the module editor. Since you have to explicitly launch modedit to be able to change the module, and there is no change to pcbnew behaviour, editing locked modules still required explicit effort to do so (just like moving locked modules). Fixe

Re: [Kicad-developers] [PATCH] Allow editing locked modules in modedit

2017-01-22 Thread Chris Pavlina
Merged. Thank you On Mon, Jan 23, 2017 at 09:28:42AM +0800, John Beard wrote: > This patch makes it possible to edit locked modules in the module editor. > > Since you have to explicitly launch modedit to be able to change the > module, and there is no change to pcbnew behaviour, editing locked >

[Kicad-developers] [PATCH] Init OPENGL_GAL currentTarget

2017-01-22 Thread John Beard
Hi, This patch initialises a class member in OPENGL_GAL. It uses the SetTarget function to make sure the target and manager initialise in a consistent way. Cheers, John From f9a0fc626f78337165595f18f4dca73afa11a9af Mon Sep 17 00:00:00 2001 From: John Beard Date: Mon, 23 Jan 2017 13:19:10 +0800