Re: [Kicad-developers] Project save as

2019-11-12 Thread Eeli Kaikkonen
ti 12. marrask. 2019 klo 17.43 Jeff Young (j...@rokeby.ie) kirjoitti: > FWIW, the old generated files are not outdated — the paths in them are > updated. > > I was thinking for example gerbers which often (usually?) have project name and revision as graphics in some layer. Whatever the reason of u

Re: [Kicad-developers] Project save as

2019-11-12 Thread Jeff Young
FWIW, the old generated files are not outdated — the paths in them are updated. > On 11 Nov 2019, at 23:06, Eeli Kaikkonen wrote: > > > > ti 12. marrask. 2019 klo 0.02 Jon Evans (j...@craftyjon.com > ) kirjoitti: > I question the value of creating this amount of com

Re: [Kicad-developers] Project save as

2019-11-11 Thread Eeli Kaikkonen
ti 12. marrask. 2019 klo 0.02 Jon Evans (j...@craftyjon.com) kirjoitti: > I question the value of creating this amount of complex UI around "save > as". > In that case I personally would prefer minimal functionality, copying only the necessary project files. More likely than not the generated fi

Re: [Kicad-developers] Project save as

2019-11-11 Thread Jon Evans
I guess ultimately this is up to Jeff since he's implementing it, but I think this is going way above and beyond what any user should expect of an application. I have never used any software that tried this hard to handle the "save as" feature without any chance of the user needing to take some fo

Re: [Kicad-developers] Project save as

2019-11-11 Thread Eeli Kaikkonen
Here's a rough idea of what a confirmation dialog could do: [image: image.png] I think something like that would be flexible enough to help the user with most workflows and left the responsibility to the user while being simple and easy enough to use (although a bit more work to implement, of cou

Re: [Kicad-developers] Project save as

2019-11-11 Thread Jeff Young
Limiting it to a dash is just because that’s all Kicad generates. The user could indeed use anything. So should we rename any file that starts with the old project name? I did have a version that did that, but it seemed too aggressive to me. > On 11 Nov 2019, at 20:56, Eeli Kaikkonen wrote:

Re: [Kicad-developers] Project save as

2019-11-11 Thread Jeff Young
But even doing that is going to be more work, as they’re going to have to delete a whole pile of old files…. I have several old projects that I haven’t opened since the 4.0.x days. I may want to move them, but regenerating the Gerbers wouldn’t necessarily generate the same files. (It might if

Re: [Kicad-developers] Project save as

2019-11-11 Thread Eeli Kaikkonen
ma 11. marrask. 2019 klo 22.41 Jeff Young (j...@rokeby.ie) kirjoitti: > Yes, the current algorithm renames files that either match the project > name (with any extension), or start with the project name followed by a > dash. > Limiting the following character to dash seems arbitrary. Underscore i

Re: [Kicad-developers] Project save as

2019-11-11 Thread Ian McInerney
I agree, we should only be transferring and renaming the non-generated files rather than trying to account for every possible file under the sun. If the user wants the generated files, they can regenerate them from the new project. -Ian On Mon, 11 Nov 2019, 20:30 Jon Evans, wrote: > In my opini

Re: [Kicad-developers] Project save as

2019-11-11 Thread Jeff Young
Yes, the current algorithm renames files that either match the project name (with any extension), or start with the project name followed by a dash. We don’t need to know the extension in either case. This feels right to me, but I’m open to discussion. Cheers, Jeff. > On 11 Nov 2019, at 20:29

Re: [Kicad-developers] Project save as

2019-11-11 Thread Andy Peters
> On Nov 11, 2019, at 1:28 PM, Seth Hillbrand wrote: > > On 2019-11-11 11:42, Jeff Young wrote: > >> A... I didn't notice that. We are indeed failing to look for the Protel >> extensions. > > Are we renaming generated files? If we stick with base project files, it's > easy to explain w

Re: [Kicad-developers] Project save as

2019-11-11 Thread Jon Evans
In my opinion we should not rename any generated files. This matches my experience with other tools. On Mon, Nov 11, 2019 at 3:28 PM Seth Hillbrand wrote: > On 2019-11-11 11:42, Jeff Young wrote: > > > A... I didn't notice that. We are indeed failing to look for the > > Protel extensions.

Re: [Kicad-developers] Project save as

2019-11-11 Thread Seth Hillbrand
On 2019-11-11 11:42, Jeff Young wrote: A... I didn't notice that. We are indeed failing to look for the Protel extensions. Are we renaming generated files? If we stick with base project files, it's easy to explain where the cut-off is. Once we go down into generated files, this gets h

Re: [Kicad-developers] Project save as

2019-11-11 Thread Jeff Young
A… I didn’t notice that. We are indeed failing to look for the Protel extensions. > On 11 Nov 2019, at 19:35, Eeli Kaikkonen wrote: > > ma 11. marrask. 2019 klo 20.39 Jeff Young (j...@rokeby.ie > ) kirjoitti: > I want to address the Gerber issue first. In this case

Re: [Kicad-developers] Project save as

2019-11-11 Thread Jeff Young
Next for the folder or file question. New project does indeed ask for the name of the project file and also asks if you want a directory auto-created. I hate that, but I’ll admit it’s clearer than the Save As… case where you’re not sure which it’s asking for. We have our own dialog for selecti

Re: [Kicad-developers] Project save as

2019-11-11 Thread Jeff Young
I want to address the Gerber issue first. In this case Eeli was expecting the old name to get updated if it occurred anywhere in the filename. My expectation was that it would only get updated if the file name started with the old name. Either is easy to implement, but I’d rather not have a p

Re: [Kicad-developers] Project save as

2019-11-11 Thread Eeli Kaikkonen
ma 11. marrask. 2019 klo 18.07 Wayne Stambaugh (stambau...@gmail.com) kirjoitti: > Isn't this this the same behavior as File->New? We should keep the path > creation behavior consistent. > It should be possible to use the same customized dialog then, right? Now it's different. Eeli Kaikkonen __

Re: [Kicad-developers] Project save as

2019-11-11 Thread Wayne Stambaugh
Isn't this this the same behavior as File->New? We should keep the path creation behavior consistent. On 11/11/19 10:56 AM, Jon Evans wrote: > FWIW, we are considering moving to the "create a folder for the project" > to be a requirement rather than an option, in case that impacts this > feature.

Re: [Kicad-developers] Project save as

2019-11-11 Thread Jon Evans
FWIW, we are considering moving to the "create a folder for the project" to be a requirement rather than an option, in case that impacts this feature. Or rather, it would be a requirement that there be one KiCad project per folder, not necessarily that automatically creating a folder would be a req

Re: [Kicad-developers] Project save as

2019-11-11 Thread Eeli Kaikkonen
I hope you don't mind I give some first impressions here. I can move these to bug database if needed. Before trying it's unclear what the file dialog selects. I created a new directory (with the name of the new project), went inside it and gave the project name in the dialog. "All files *.*" filte

Re: [Kicad-developers] Project save as

2019-11-09 Thread Jeff Young
He he… I know our users. I can be sure of a bug report even if I get it right. ;) > This is exactly why I never tackled this one. Anytime your are trying > to deal with complex relative path changes, the code gets rather messy. > I doubt this will affect many users but you can be rest assured o

Re: [Kicad-developers] Project save as

2019-11-09 Thread Wayne Stambaugh
On 11/9/2019 2:18 PM, Jeff Young wrote: > Hi Wayne, > >> On 9 Nov 2019, at 19:05, Wayne Stambaugh wrote: >> >> Hey Jeff, >> >> On 11/9/2019 12:06 PM, Jeff Young wrote: >>> I’m working through the project Save As feature. >>> >>> I currently have it renaming the top-level files, updating the symbo

Re: [Kicad-developers] Project save as

2019-11-09 Thread Jeff Young
Hi Wayne, > On 9 Nov 2019, at 19:05, Wayne Stambaugh wrote: > > Hey Jeff, > > On 11/9/2019 12:06 PM, Jeff Young wrote: >> I’m working through the project Save As feature. >> >> I currently have it renaming the top-level files, updating the symbol and >> footprint lib tables, updating paths in

Re: [Kicad-developers] Project save as

2019-11-09 Thread Wayne Stambaugh
Hey Jeff, On 11/9/2019 12:06 PM, Jeff Young wrote: > I’m working through the project Save As feature. > > I currently have it renaming the top-level files, updating the symbol and > footprint lib tables, updating paths in Gerber job files, and updating paths > and filenames in the netlist. >