I agree here as well, I dont think that informing users of changes that
will happen /once/ is to be considered nagware, and is a lot prefered
than to just do the changes and let the user figure it out afterwards.
On 2017-03-31 16:02, José Ignacio wrote:
I do not thing such option is necessary,
I do not thing such option is necessary, the amount of broken files is not
that high, and the dialog will not show up once if you fix them.
On Fri, Mar 31, 2017 at 8:44 AM, Wayne Stambaugh
wrote:
> I've already fixed this with option #3. I will go back and add a do not
> show again option when
I've already fixed this with option #3. I will go back and add a do not
show again option when I get some time. I really wanted get this fix
committed as quickly as possible to minimize the number of broken
schematics.
Cheers,
Wayne
On 3/31/2017 9:40 AM, José Ignacio wrote:
> I like option #3
I like option #3 the most, #1 a close second, #4 the least, i wouldn't like
unexpected automatic saving behavior. If anything it may be worth it to
have a generic thing were to toss all these warts in the future. Perhaps a
general "file repair/recovery", kind of how the rescue system works for
symb
Hi,
I'd vote of #3 but with the addition of a "Don't show this dialog in the
future" option.
If the "don't show" has been set, then simply auto save (ie: #4)
Regards
David G
On 31/03/17 01:33, Wayne Stambaugh wrote:
> I have found and fixed the bug in this bug report:
>
> https://bugs.launchpa
I just took the cheap and dirty way out and made sure that the unit is
never 0. I agree, fixing this at the selector level probably makes more
sense but this will ensure that if someone mucks it up in the future, at
least the unit value can never be zero and reintroduce this bug.
Interestingly, d
lol, I was just going to ask you why that line is even there if _no_
components can have a zero unit, and then decided to git-blame it and
realized _I_ wrote that line.
I think the reason I did that is that the new selector returns zero when
the user has selected a root component - it only returns
The problem is line 169 of eeschema/getpart.cpp. The component unit
cannot be 0 even for components that do not have multiple units. There
probably should be an assertion in the SCH_COMPONENT ctor to warn devs
about this.
On 3/30/2017 3:24 PM, Chris Pavlina wrote:
> Ops. Sorry.
>
> I caught
Ops. Sorry.
I caught one place where I had done that. Thought that was all. :\
On Thu, Mar 30, 2017 at 03:13:31PM -0400, Wayne Stambaugh wrote:
> I believe since the new component chooser dialog has been implement
> which hasn't been very long.
>
> On 3/30/2017 2:53 PM, Maciej Suminski wrot
I believe since the new component chooser dialog has been implement
which hasn't been very long.
On 3/30/2017 2:53 PM, Maciej Suminski wrote:
> Do you know for how long the bug was present? It could help estimate the
> number of schematic files affected.
>
> As much as I hate windows popping up,
I also vote #3 for the same reason as everyone else :)
On Thu, Mar 30, 2017 at 01:33:55PM -0400, Wayne Stambaugh wrote:
> I have found and fixed the bug in this bug report:
>
> https://bugs.launchpad.net/kicad/+bug/1677282
>
> This bug creates invalid schematic files which sets the component uni
Hi!
#3 ++
Simply because it's the most transparent and informative way to solve the issue.
Maybe it's wise additionally to recommend saving the file to a different
filename because it could matter...
#5 could be to have #4 saving to a different filename or creating a backup of
the old one autom
Do you know for how long the bug was present? It could help estimate the
number of schematic files affected.
As much as I hate windows popping up, I do not think notifying the users
would be that annoying. It is going to happen only once for each invalid
file. I doubt there are people working on 1
Just thinking about the impact between #3 and #4 (I don't think #1 or #2
are good options)
#3 - impacts everyone who has used both the old and new versions,
regardless of whether they use a VCS. Impact is a minor annoyance (weird
dialog box, pops up once per schematic, that they probably don't ca
14 matches
Mail list logo
