Hey John,
I started working again on getting the rest of these patches committed
and discovered that this[1] commit breaks the python console (at least
on windows) in Pcbnew. Please take a look at it when you get a chance.
Thanks,
Wayne
[1]:
https://git.launchpad.net/~john-j-beard/kicad/commit
Hey John,
I'll cherry-pick the swig commit from your branch.
The revised patch you sent is now failing to build
eeschema/sim/ngspice.cpp. It's missing the definitions for wxTextFile
and wxFileName so you will have to add the appropriate headers to
ngspice.cpp.
Cheers,
Wayne
On 3/24/2017 11:38
Hi Wayne,
Like this?
As for the patches that don't apply out of order, in this case it is
due to removing the following line in the previous commit. If you want
to cherry-pick that patch, doing it by git rather than raw patches
would be much easier. Git would be able to flag the conflict up and i
On 3/24/2017 9:50 AM, John Beard wrote:
> Hi Wayne,
>
> The InitKicadAbout function was removed in 2010 by commit
> b45a35b719739e1ed1a723a4e7412d63020e5f2c. Is it still useful in the
> swig file?
It should be removed but unfortunately this patch now no longer applies
cleanly.
>
> As for the di
Hi Wayne,
The InitKicadAbout function was removed in 2010 by commit
b45a35b719739e1ed1a723a4e7412d63020e5f2c. Is it still useful in the
swig file?
As for the directory_utils compile failure, perhaps there's a
difference in WX on Windows?
Does #include at the top of common/directory_utils.cpp fix
John,
I committed up to patch 9. Patch 6 did not apply cleanly. Apparently
it needs the broken patch 5 so it will need to be rebased once you fix
patch 5.
I have a question about patch 10. Did you test InitAboutKicad from the
python scripting. It was originally ignored because there were issu
So far, I've tested patches 1-4 and they seem fine. Patch 5 fails to
compile on windows with the following compiler output:
C:/msys64/home/wstambaugh/src/kicad-trunk/common/directory_utils.cpp: In
function 'wxConfigBase* GetNewConfig(const wxString&)':
C:/msys64/home/wstambaugh/src/kicad-trunk/co
Hi John,
Thank you for the patches. I have committed:
0001 OPENGL_GAL: Init currentTarget
0003 Rework zone creation in GAL (committed yesterday)
I had a look at other changes, and they appear to be a sensible common.h
clean-up. All patches received the Orson Approves™ badge, but I leave
the f
Hi Wayne,
They are pretty much all independent in scope, but there might be
(very minor) conflicts if you apply a subset or out of order.
Here are the patches.
Cheers,
John
On Wed, Mar 22, 2017 at 10:03 PM, Wayne Stambaugh wrote:
> Hey John,
>
> I'm assuming that the common.h tidy ups are fro
Hey John,
I'm assuming that the common.h tidy ups are from commit
cb2ef9ea5e4ee449295c41573beefa2fc0935b84 forward. If you don't mind, it
would make my life a bit easier if you would send the patches. They
look like they are all stand alone changes so it shouldn't be an issue
to push them one at
Hi Wayne,
Just an update: the tidy_ups branch [1] has been rebased and a small
number of conflicts resolved (mostly includes being added in the same
places).
Thanks,
John
[1] https://code.launchpad.net/~john-j-beard/kicad/+git/kicad/+ref/tidy_ups
On Thu, Feb 9, 2017 at 10:08 PM, John Beard wr
Hi Wayne,
Yes, first in the list is "8f192fe12 OPENGL_GAL: Init currentTarget"
That particular one is actually an older patch I had on my tidy-up
branch and isn't really in the common.h set, but it keeps my IDE
quieter! 5e6a022b5 is the first common.h one.
Cheers,
John
On Thu, Feb 9, 2017 at 9
John,
I like this idea. Anything that prevents unnecessary compiling is a
good thing. Looking at this repo, I'm guessing that everything from
commit 8f192fe12eb52efd6d024c82d1416db5e62b345f on is what needs to be
merged. I'll try to take a look at it over the weekend. Keep up the
great work.
13 matches
Mail list logo
