Re: [Kicad-developers] [PATCH] Wildcard tests + removed variadic interface

2019-01-09 Thread Wayne Stambaugh
John, I merged your patch set into the development branch. Thanks, Wayne On 1/9/2019 4:54 AM, John Beard wrote: > Hi Wayne, > > It means someone else added a test! :-) > > Here is a rebase of these patches. > > Cheers, > > John > > On Wed, Jan 9, 2019 at 1:58 AM Wayne Stambaugh wrote: >>

Re: [Kicad-developers] [PATCH] Wildcard tests + removed variadic interface

2019-01-09 Thread John Beard
Hi Wayne, It means someone else added a test! :-) Here is a rebase of these patches. Cheers, John On Wed, Jan 9, 2019 at 1:58 AM Wayne Stambaugh wrote: > > John, > > Would you please rebase your patches? Patch 0001 no longer applies > cleaning. Apparently someone made a change the caused a

Re: [Kicad-developers] [PATCH] Wildcard tests + removed variadic interface

2019-01-08 Thread Wayne Stambaugh
John, Would you please rebase your patches? Patch 0001 no longer applies cleaning. Apparently someone made a change the caused a conflict before I could get around to merging them. Thanks, Wayne On 1/8/2019 12:35 PM, John Beard wrote: > Hi Seth, > > Here are updated patches (only #3 is chang

Re: [Kicad-developers] [PATCH] Wildcard tests + removed variadic interface

2019-01-08 Thread jp charras
Le 08/01/2019 à 18:35, John Beard a écrit : > Hi Seth, > > Here are updated patches (only #3 is changed). > > I have still hardcoded the expected results in the test, otherwise > it'll be a fairly opaque test of two copy-pasted lines. > > The windows filter is now " (*.*)|*.*": is that right? >

Re: [Kicad-developers] [PATCH] Wildcard tests + removed variadic interface

2019-01-08 Thread John Beard
Hi Seth, Here are updated patches (only #3 is changed). I have still hardcoded the expected results in the test, otherwise it'll be a fairly opaque test of two copy-pasted lines. The windows filter is now " (*.*)|*.*": is that right? Cheers, John On Tue, Jan 8, 2019 at 4:48 PM Seth Hillbrand

Re: [Kicad-developers] [PATCH] Wildcard tests + removed variadic interface

2019-01-08 Thread Seth Hillbrand
Am 2019-01-08 11:46, schrieb John Beard: Hi Seth, Good idea - I was just moving what the code currently did, but sounds like a sensible fix. I'll amend patch 0003. Does it otherwise work on Windows? Unfortunately, I don't have a Windows setup so we'll need to wait for an available Windows te

Re: [Kicad-developers] [PATCH] Wildcard tests + removed variadic interface

2019-01-08 Thread John Beard
Hi Seth, Good idea - I was just moving what the code currently did, but sounds like a sensible fix. I'll amend patch 0003. Does it otherwise work on Windows? Cheers, John On Tue, Jan 8, 2019 at 4:36 PM Seth Hillbrand wrote: > > Am 2019-01-08 09:16, schrieb John Beard: > > Hi, > > > > Here are

Re: [Kicad-developers] [PATCH] Wildcard tests + removed variadic interface

2019-01-08 Thread Seth Hillbrand
Am 2019-01-08 09:16, schrieb John Beard: Hi, Here are some patches for wildcards: * Add some tests to demo the API and expected output. * Remove a variadic function signature and replace with one that takes a std::vector. This allows better and more typesafe use of this API at run time. * Unify