Re: [Kicad-developers] wxAuiNotebook vs. wxNotebook

2017-09-20 Thread Wayne Stambaugh
On 9/19/2017 3:34 PM, jp charras wrote: > Le 19/09/2017 à 20:28, Michael Kavanagh a écrit : >> In that case since I don't see why the Aui features are needed in the About >> dialog I submit this >> patch for review. I have only tested on Windows 10 so it should be tested on >> macOS etc. before m

Re: [Kicad-developers] wxAuiNotebook vs. wxNotebook

2017-09-19 Thread jp charras
Le 19/09/2017 à 20:28, Michael Kavanagh a écrit : > In that case since I don't see why the Aui features are needed in the About > dialog I submit this > patch for review. I have only tested on Windows 10 so it should be tested on > macOS etc. before merging. > > Regards, > Michael What is the

Re: [Kicad-developers] wxAuiNotebook vs. wxNotebook

2017-09-19 Thread Greg Smith
I'm docking wx windows created in Python. Please don't take that away at least for the windows that make sense. Right now, I am a child to Pcbnew and dock to Pcbnew's manager, but I suspect there's a lower level one that is better for LayerViewSet. And perhaps KiCommand as well. The current issu

Re: [Kicad-developers] wxAuiNotebook vs. wxNotebook

2017-09-19 Thread Wayne Stambaugh
The thought was at some point we would switch over to wxAuiManager[1] to handle all window management. That never happened because wxAui has not proven to be reliable enough to convert everything over to it. Hopefully at some point this will happen as it pulls in some nice features such as dockabl

Re: [Kicad-developers] wxAuiNotebook vs. wxNotebook

2017-09-19 Thread Michael Kavanagh
Updated screenshot attached including the icons. Regards, Michael On 19 September 2017 at 17:27, Greg Smith wrote: > I think the main difference is in the ability to be a dock for other > panels. > > https://wiki.wxpython.org/AuiNotebook%20%28AGW%29 > > "Advanced User Interface (AUI) that provi

Re: [Kicad-developers] wxAuiNotebook vs. wxNotebook

2017-09-19 Thread Greg Smith
I think the main difference is in the ability to be a dock for other panels. https://wiki.wxpython.org/AuiNotebook%20%28AGW%29 "Advanced User Interface (AUI) that provides perspective saving, floating sub-windows that can be docked, customizable look and feel and the splittable AUI Notebook."

[Kicad-developers] wxAuiNotebook vs. wxNotebook

2017-09-19 Thread Michael Kavanagh
Hi, Is there any reason why wxAuiNotebook is used in some cases instead of wxNotebook which uses native widgets? I have attached screenshots of the different appearances on Windows. I can send some patches changing some over to wxNotebook if this is acceptable. For the About dialog at least it se