Re: [Kicad-developers] Show grid in eeschema status line

2019-06-04 Thread Steven A. Falco
On 6/4/19 4:46 PM, Wayne Stambaugh wrote: > On 6/3/19 12:25 PM, Steven A. Falco wrote: >> On 6/3/19 10:42 AM, Wayne Stambaugh wrote: >>> Hi Steve, >>> >>> Your patch no longer applies cleanly as there has been some serious >>> refactoring and legacy code removal. I think your patch is a good idea

Re: [Kicad-developers] Show grid in eeschema status line

2019-06-04 Thread Wayne Stambaugh
On 6/3/19 12:25 PM, Steven A. Falco wrote: > On 6/3/19 10:42 AM, Wayne Stambaugh wrote: >> Hi Steve, >> >> Your patch no longer applies cleanly as there has been some serious >> refactoring and legacy code removal. I think your patch is a good idea >> but it will need to be fixed. I do have a few

Re: [Kicad-developers] Show grid in eeschema status line

2019-06-03 Thread Steven A. Falco
On 6/3/19 10:42 AM, Wayne Stambaugh wrote: > Hi Steve, > > Your patch no longer applies cleanly as there has been some serious > refactoring and legacy code removal. I think your patch is a good idea > but it will need to be fixed. I do have a few comments from your > original patch: > > * Plea

Re: [Kicad-developers] Show grid in eeschema status line

2019-06-03 Thread Wayne Stambaugh
Hi Steve, Your patch no longer applies cleanly as there has been some serious refactoring and legacy code removal. I think your patch is a good idea but it will need to be fixed. I do have a few comments from your original patch: * Please use `git commit` to commit your code to your local repo

Re: [Kicad-developers] Show grid in eeschema status line

2019-05-24 Thread Steven A. Falco
On 5/23/19 1:59 PM, Wayne Stambaugh wrote: > Hey Steve, > > Adding "grid" to the coordinates in the status bar is not correct. > These are the cursor coordinates not the grid coordinates. To add the > current grid size to the status bar, you would need to add another pane > to status bar and fetc

Re: [Kicad-developers] Show grid in eeschema status line

2019-05-23 Thread Steven A. Falco
On 5/23/19 1:59 PM, Wayne Stambaugh wrote: > Hey Steve, > > Adding "grid" to the coordinates in the status bar is not correct. > These are the cursor coordinates not the grid coordinates. To add the > current grid size to the status bar, you would need to add another pane > to status bar and fetc

Re: [Kicad-developers] Show grid in eeschema status line

2019-05-23 Thread Wayne Stambaugh
Hey Steve, Adding "grid" to the coordinates in the status bar is not correct. These are the cursor coordinates not the grid coordinates. To add the current grid size to the status bar, you would need to add another pane to status bar and fetch the current grid setting from the current SCREEN obje

[Kicad-developers] Show grid in eeschema status line

2019-05-18 Thread Steven A. Falco
I decided to try adding the current grid size to the status line of eeschema and the symbol editor, so as to make the N/shift-N hotkeys easier to use. Below is what I came up with. Is this something that could be accepted? I don't know if it fits with the style of the KiCad code - I have most