Re: [Kicad-developers] Optimization flags in 3d-viewer

2017-02-23 Thread Chris Pavlina
> From: Chris Pavlina [pavlina.ch...@gmail.com] > Sent: 23 February 2017 22:31 > To: Mário Luzeiro > Cc: Simon Richter; KiCad Developers > Subject: Re: [Kicad-developers] Optimization flags in 3d-viewer > > It's okay if you paint the code red though. That really does make it go >

Re: [Kicad-developers] Optimization flags in 3d-viewer

2017-02-23 Thread Mário Luzeiro
___ > From: Chris Pavlina [pavlina.ch...@gmail.com] > Sent: 23 February 2017 22:06 > To: Mário Luzeiro > Cc: Simon Richter; KiCad Developers > Subject: Re: [Kicad-developers] Optimization flags in 3d-viewer > > On Thu, Feb 23, 2017 at 03:48:39PM +, Mário Lu

Re: [Kicad-developers] Optimization flags in 3d-viewer

2017-02-23 Thread Chris Pavlina
.@gmail.com] > Sent: 23 February 2017 22:06 > To: Mário Luzeiro > Cc: Simon Richter; KiCad Developers > Subject: Re: [Kicad-developers] Optimization flags in 3d-viewer > > On Thu, Feb 23, 2017 at 03:48:39PM +, Mário Luzeiro wrote: > > Yes I added it, because for 3D we need

Re: [Kicad-developers] Optimization flags in 3d-viewer

2017-02-23 Thread Mário Luzeiro
I am *sorry* Mario From: Chris Pavlina [pavlina.ch...@gmail.com] Sent: 23 February 2017 22:06 To: Mário Luzeiro Cc: Simon Richter; KiCad Developers Subject: Re: [Kicad-developers] Optimization flags in 3d-viewer On Thu, Feb 23, 2017 at 03:48:39PM +

Re: [Kicad-developers] Optimization flags in 3d-viewer

2017-02-23 Thread Chris Pavlina
nchpad.net] on behalf of > Simon Richter [simon.rich...@hogyros.de] > Sent: 23 February 2017 15:25 > To: KiCad Developers > Subject: [Kicad-developers] Optimization flags in 3d-viewer > > Hi, > > in 3d-viewer/CMakeLists.txt we have > > set( CMAKE_C_FLAGS_RELEASE

Re: [Kicad-developers] Optimization flags in 3d-viewer

2017-02-23 Thread Chris Pavlina
On Thu, Feb 23, 2017 at 11:45:40AM -0500, Mark Roszko wrote: > Does -O3 really have that much of an improvement though? I assume the > only thing cpu bound thing in the 3d viewer is the raytracing. Even on CPU-bound things -O3 tends not to be too much of an improvement on both gcc and clang. -O2 i

Re: [Kicad-developers] Optimization flags in 3d-viewer

2017-02-23 Thread Mário Luzeiro
KiCad Developers Subject: Re: [Kicad-developers] Optimization flags in 3d-viewer Does -O3 really have that much of an improvement though? I assume the only thing cpu bound thing in the 3d viewer is the raytracing. If you really want speed you would throw in P

Re: [Kicad-developers] Optimization flags in 3d-viewer

2017-02-23 Thread Simon Richter
Hi, On 23.02.2017 16:48, Mário Luzeiro wrote: > Yes I added it, because for 3D we need *speed* :P It's unnecessary though, as cmake defaults to "-O3 -DNDEBUG". So overwriting that will likely enable assertion checks. > What kind of warnings it is causing? O_o MSVC only knows "-O2" as a syn

Re: [Kicad-developers] Optimization flags in 3d-viewer

2017-02-23 Thread Mark Roszko
Does -O3 really have that much of an improvement though? I assume the only thing cpu bound thing in the 3d viewer is the raytracing. If you really want speed you would throw in PGO :P. ___ Mailing list: https://launchpad.net/~kicad-developers Post to

Re: [Kicad-developers] Optimization flags in 3d-viewer

2017-02-23 Thread Mário Luzeiro
February 2017 15:25 To: KiCad Developers Subject: [Kicad-developers] Optimization flags in 3d-viewer Hi, in 3d-viewer/CMakeLists.txt we have set( CMAKE_C_FLAGS_RELEASE "-O3" ) set( CMAKE_CXX_FLAGS_RELEASE "-O3" ) Is that intentional? - it seems to be unused in the Mak

[Kicad-developers] Optimization flags in 3d-viewer

2017-02-23 Thread Simon Richter
Hi, in 3d-viewer/CMakeLists.txt we have set( CMAKE_C_FLAGS_RELEASE "-O3" ) set( CMAKE_CXX_FLAGS_RELEASE "-O3" ) Is that intentional? - it seems to be unused in the Make based builds - it overwrites any existing flags in these variables - it causes warnings on MSVC Simon signature.as