Re: [Kicad-developers] New fix for bug 1663173

2017-10-19 Thread Wayne Stambaugh
Hi Jean-Samuel, I committed your code to the master branch. Thank you for your contribution to KiCad. Cheers, Wayne On 10/19/2017 4:30 AM, Jean-Samuel Reynaud wrote: > Hi, > > Sorry, corrected patch attached. > > Regards > Le 18/10/2017 à 19:31, Wayne Stambaugh a écrit : >> Hi Jean-Samuel, >

Re: [Kicad-developers] New fix for bug 1663173

2017-10-19 Thread Jean-Samuel Reynaud
Hi, Sorry, corrected patch attached. Regards Le 18/10/2017 à 19:31, Wayne Stambaugh a écrit : > Hi Jean-Samuel, > > There are a few coding policy violations in your patch. > > if( outline.OutlineCount() > 0) { > > should be: > > if( outline.OutlineCount() > 0 ) > { > > This occurs several ti

Re: [Kicad-developers] New fix for bug 1663173

2017-10-18 Thread Wayne Stambaugh
Hi Jean-Samuel, There are a few coding policy violations in your patch. if( outline.OutlineCount() > 0) { should be: if( outline.OutlineCount() > 0 ) { This occurs several times. Please fix this as resubmit the patch. Thanks, Wayne On 10/18/2017 8:58 AM, Jean-Samuel Reynaud wrote: > Hi all

[Kicad-developers] New fix for bug 1663173

2017-10-18 Thread Jean-Samuel Reynaud
Hi all, Since some recent modifications (I don't search from what version exactly), bug 1663173 is coming back... See original description : https://bugs.launchpad.net/kicad/+bug/1663173 Please find attached the patch to fix it. Following this issue I have two comments: - For any usage of "pol