Re: [Kicad-developers] Modedit graphical item properties dialog patch

2017-01-29 Thread Maciej Sumiński
Thank you Diogo, I have just committed your patch. Regards, Orson On 01/27/2017 09:49 PM, Diogo Condeço wrote: > From a6d5b321ca5d5a75cde7f5039bb0bd0f729454b4 Mon Sep 17 00:00:00 2001 > From: Diogo Condeco > Date: Fri, 27 Jan 2017 20:31:35 + > Subject: [PATCH] MACOS Setfocus and CancelButton

Re: [Kicad-developers] Modedit graphical item properties dialog patch

2017-01-27 Thread Diogo Condeço
Hi all, As we discussed attached is a patch to correct SetFocus issues and the CancelButtonIssue. SetFocus requires DLGSHIM_USE_SETFOCUS to be set, which is only set when __WXMAC__ is defined. I've tested this on my system and it is working -> example is the eeschema edit reference value dialog w

Re: [Kicad-developers] Modedit graphical item properties dialog patch

2017-01-26 Thread Wayne Stambaugh
On 1/26/2017 10:06 AM, Diogo Condeço wrote: > @Orson yes moving it into Show seems to work. I will remove the > FixOSXCancelButtonIssue() call from other dialogs to test it further... > > The only dialog I found this doesn't work is the new input for a new > footprint on the module editor... > >

Re: [Kicad-developers] Modedit graphical item properties dialog patch

2017-01-26 Thread Diogo Condeço
@Orson yes moving it into Show seems to work. I will remove the FixOSXCancelButtonIssue() call from other dialogs to test it further... The only dialog I found this doesn't work is the new input for a new footprint on the module editor... @Wayne this is the cancel (cmd-c) button issue... I don't

Re: [Kicad-developers] Modedit graphical item properties dialog patch

2017-01-26 Thread Wayne Stambaugh
On 1/26/2017 2:52 AM, Maciej Sumiński wrote: > On 01/25/2017 08:14 PM, Diogo Condeço wrote: >> Hi all, >> >> This patch corrects the CMD+C cancel dialog bug on macos... There are still >> some both in the footprint editor, and the board editor. I will try to >> patch them once i can get some free t

Re: [Kicad-developers] Modedit graphical item properties dialog patch

2017-01-25 Thread Maciej Sumiński
On 01/25/2017 08:14 PM, Diogo Condeço wrote: > Hi all, > > This patch corrects the CMD+C cancel dialog bug on macos... There are still > some both in the footprint editor, and the board editor. I will try to > patch them once i can get some free time. I wonder if FixOSXCancelButtonIssue() call co

[Kicad-developers] Modedit graphical item properties dialog patch

2017-01-25 Thread Diogo Condeço
Hi all, This patch corrects the CMD+C cancel dialog bug on macos... There are still some both in the footprint editor, and the board editor. I will try to patch them once i can get some free time. There is still the setfocus issue, which I will try to get later on... But I would like to go throug