Re: [Kicad-developers] [PATCH v2 0/8] MSVC Build

2019-07-17 Thread Simon Richter
Hi Wayne, On Tue, Jul 16, 2019 at 06:24:30PM -0400, Wayne Stambaugh wrote: > I'm ready to push this patch set. I'm assuming this is the same changes > as the merge request. If not please let me know. The merge request is better: - two small fixes for things that happened while rebasing -

Re: [Kicad-developers] [PATCH v2 0/8] MSVC Build

2019-07-16 Thread Wayne Stambaugh
Simon, I'm ready to push this patch set. I'm assuming this is the same changes as the merge request. If not please let me know. Cheers, Wayne On 7/4/2019 12:05 PM, Simon Richter wrote: > Hi, > > another attempt at getting the MSVC patchset merged. :) > > The mails with the patches are for c

Re: [Kicad-developers] [PATCH v2 0/8] MSVC Build

2019-07-16 Thread Wayne Stambaugh
Simon, On 7/12/2019 4:00 PM, Simon Richter wrote: > Hi Wayne, > >> I have to apply the patches, build, and test. I should be able to get >> to it over the weekend. My only comment is on patch #1. I would have >> preferred that we implemented the missing boost pointer container object >> clone

Re: [Kicad-developers] [PATCH v2 0/8] MSVC Build

2019-07-12 Thread Simon Richter
Hi Wayne, > I have to apply the patches, build, and test. I should be able to get > to it over the weekend. My only comment is on patch #1. I would have > preferred that we implemented the missing boost pointer container object > clone methods rather the work around. As a temporary fix I could

Re: [Kicad-developers] [PATCH v2 0/8] MSVC Build

2019-07-12 Thread Wayne Stambaugh
I have to apply the patches, build, and test. I should be able to get to it over the weekend. My only comment is on patch #1. I would have preferred that we implemented the missing boost pointer container object clone methods rather the work around. As a temporary fix I could live with this but

Re: [Kicad-developers] [PATCH v2 0/8] MSVC Build

2019-07-12 Thread Seth Hillbrand
Agreed. Wayne are you comfortable with this? -S On 2019-07-11 15:00, Nick Østergaard wrote: It looks like people are happy with the patches, can we get them merged so they don't get lost and we don't need to rebase them locally all the time? On Fri, 5 Jul 2019 at 19:01, Simon Richter wrote:

Re: [Kicad-developers] [PATCH v2 0/8] MSVC Build

2019-07-11 Thread Nick Østergaard
It looks like people are happy with the patches, can we get them merged so they don't get lost and we don't need to rebase them locally all the time? On Fri, 5 Jul 2019 at 19:01, Simon Richter wrote: > > Hi, > > On Fri, Jul 05, 2019 at 06:24:45PM +0200, Tomasz Wlostowski wrote: > > > > I can't te

Re: [Kicad-developers] [PATCH v2 0/8] MSVC Build

2019-07-05 Thread Simon Richter
Hi, On Fri, Jul 05, 2019 at 06:24:45PM +0200, Tomasz Wlostowski wrote: > > I can't test the Windows functionality but this doesn't appear to break > > anything on Linux. > I'm ok with Simon's patches. Can give them a try on MSVC, but I'm pretty > confident they will work already. These are test

Re: [Kicad-developers] [PATCH v2 0/8] MSVC Build

2019-07-05 Thread Tomasz Wlostowski
On 05/07/2019 18:21, Seth Hillbrand wrote: > I can't test the Windows functionality but this doesn't appear to break > anything on Linux. > I'm ok with Simon's patches. Can give them a try on MSVC, but I'm pretty confident they will work already. @Simon: Now that we'll be supporting MSVC, should

Re: [Kicad-developers] [PATCH v2 0/8] MSVC Build

2019-07-05 Thread Seth Hillbrand
I can't test the Windows functionality but this doesn't appear to break anything on Linux. -Seth On 2019-07-04 12:05, Simon Richter wrote: Hi, another attempt at getting the MSVC patchset merged. :) The mails with the patches are for commenting, this branch should probably be merged from th

[Kicad-developers] [PATCH v2 0/8] MSVC Build

2019-07-04 Thread Simon Richter
Hi, another attempt at getting the MSVC patchset merged. :) The mails with the patches are for commenting, this branch should probably be merged from the "msvc" branch under https://git.launchpad.net/~sjr/kicad in order to preserve author/date information properly. Simon Simon Richter (5):