Re: [Kicad-developers] [PATCH 1/2] Hide EDA_ITEM ctors

2015-01-29 Thread Wayne Stambaugh
Simon, I applied your patch in the product branch r5394. I generally frown patches like this. While technically you are correct EDA_ITEM not used directly, this is merely semantics. When this kind of patch is the biggest issue in the KiCad source, I will retire to some tropical island and soak

[Kicad-developers] [PATCH 1/2] Hide EDA_ITEM ctors

2015-01-25 Thread Simon Richter
This is really an abstract class and should not be instantiated directly. --- include/base_struct.h | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/include/base_struct.h b/include/base_struct.h index 360e4ff..5db45f4 100644 --- a/include/base_struct.h +++ b/include/base_str