Re: [Kicad-developers] [PATCH] refactor BRIGHT_BOX to common

2017-03-11 Thread Maciej Suminski
Ok, I went for 'KiCad Developers' then. Thank you! Regards, Orson On 03/11/2017 09:34 PM, Jon Evans wrote: > Hi Orson, I kept it as you as I basically just cut your code in half and > put part in another file. But feel free to change it to me or kicad > developers if you wish! > > Thanks, > Jon

Re: [Kicad-developers] [PATCH] refactor BRIGHT_BOX to common

2017-03-11 Thread Jon Evans
Hi Orson, I kept it as you as I basically just cut your code in half and put part in another file. But feel free to change it to me or kicad developers if you wish! Thanks, Jon On Mar 11, 2017 15:33, "Maciej Suminski" wrote: Hi Jon, There are new files (pcb_bright_box.*) that say I am the aut

Re: [Kicad-developers] [PATCH] refactor BRIGHT_BOX to common

2017-03-11 Thread Maciej Suminski
Hi Jon, There are new files (pcb_bright_box.*) that say I am the author, but it would be unfair of me to take credit for someone else's work. Shall I change it to 'KiCad Developers' or what would be your preference? Once it is changed, I am going to merge the patches. Thank you for your efforts.

Re: [Kicad-developers] [PATCH] refactor BRIGHT_BOX to common

2017-03-11 Thread Jon Evans
Oops! Yes, thanks. On Sat, Mar 11, 2017 at 12:35 PM, Chris Pavlina wrote: > I assume you want the header in include/preview_items as well, right? > > On Sat, Mar 11, 2017 at 08:54:11AM -0500, Jon Evans wrote: > > Hi John, you are right! It was late and I didn't remember about your new > > direc

Re: [Kicad-developers] [PATCH] refactor BRIGHT_BOX to common

2017-03-11 Thread Chris Pavlina
I assume you want the header in include/preview_items as well, right? On Sat, Mar 11, 2017 at 08:54:11AM -0500, Jon Evans wrote: > Hi John, you are right! It was late and I didn't remember about your new > directory but it's totally the right place. Updated patch attached. > > Thanks, > Jon >

Re: [Kicad-developers] [PATCH] refactor BRIGHT_BOX to common

2017-03-11 Thread Jon Evans
Hi John, you are right! It was late and I didn't remember about your new directory but it's totally the right place. Updated patch attached. Thanks, Jon On Sat, Mar 11, 2017 at 7:09 AM, John Beard wrote: > Hi Jon, > > This looks like something that could live in common/preview_items, > which

Re: [Kicad-developers] [PATCH] refactor BRIGHT_BOX to common

2017-03-11 Thread John Beard
Hi Jon, This looks like something that could live in common/preview_items, which is where I put "transient" EDA_ITEMs (i.e. constructed with NOT_USED) that are theoretically useful for any GAL canvas. So far, the ruler overlay, and SELECTION_AREA are living there, but I have a couple more in the

[Kicad-developers] [PATCH] refactor BRIGHT_BOX to common

2017-03-10 Thread Jon Evans
Hi, Quick refactor to allow use of BRIGHT_BOX from GerbView Best, Jon From 527b2cd85e0ef9249e552577cfe07054b363cc88 Mon Sep 17 00:00:00 2001 From: Jon Evans Date: Sat, 11 Mar 2017 00:46:03 -0500 Subject: [PATCH] Refactor BRIGHT_BOX to common so it can be used by other programs --- common/CMak