Re: [Kicad-developers] [PATCH] fix position of text and refdes from PCAD import

2016-02-27 Thread Eldar Khayrullin
Ok, thank ![](https://link.nylas.com/open/ac7n0u7eu8cj6vjow9ajimqdr/f6336e079ac1460f986e 5049e943e593) > On Feb 27 2016, at 8:35 pm, Wayne Stambaugh wrote: > > Patches 1-3 committed in product branch r6594. Thank you for your contribution to KiCad. > > On 2/27/2016

Re: [Kicad-developers] [PATCH] fix position of text and refdes from PCAD import

2016-02-27 Thread Wayne Stambaugh
Patches 1-3 committed in product branch r6594. Thank you for your contribution to KiCad. On 2/27/2016 5:36 AM, Eldar Khayrullin wrote: > Hello. Patch that fix a size and a proportional of font. > > On Feb 26 2016, at 8:18 pm, Eldar Khayrullin > wrote: > Add patch for carret return s

Re: [Kicad-developers] [PATCH] fix position of text and refdes from PCAD import

2016-02-27 Thread Eldar Khayrullin
Previous patch is last patch in my set ![](https://link.nylas.com/open/ac7n0u7eu8cj6vjow9ajimqdr/65482b56586c4b9dbb43 fab2a8f405b2) > On Feb 27 2016, at 1:36 pm, Eldar Khayrullin wrote: Hello. Patch that fix a size and a proportional of font. ![](https://link.nylas

Re: [Kicad-developers] [PATCH] fix position of text and refdes from PCAD import

2016-02-26 Thread Eldar Khayrullin
Add patch for carret return symbol in text > On Feb 25 2016, at 10:36 pm, Eldar Khayrullin wrote: Next I will fix some other import bugs: > > * carret return symbol \r -> ? > * size and proportional of text > * etc > >> On Feb 25 2016, at 10:30 pm, Eldar Kh

Re: [Kicad-developers] [PATCH] fix position of text and refdes from PCAD import

2016-02-25 Thread Eldar Khayrullin
Patch for position text with only justify from imported file. More accuary. > On Feb 25 2016, at 9:05 pm, Eldar Khayrullin wrote: And it apply only for free text not to refdes and value... > >> On Feb 25 2016, at 9:01 pm, Eldar Khayrullin w

Re: [Kicad-developers] [PATCH] fix position of text and refdes from PCAD import

2016-02-25 Thread Eldar Khayrullin
Next I will fix some other import bugs: * carret return symbol \r -> ? * size and proportional of text * etc > On Feb 25 2016, at 10:30 pm, Eldar Khayrullin wrote: Patch for position text with only justify from imported file. More accuary. > >> On Feb 25 2016,

Re: [Kicad-developers] [PATCH] fix position of text and refdes from PCAD import

2016-02-25 Thread Eldar Khayrullin
And it apply only for free text not to refdes and value... > On Feb 25 2016, at 9:01 pm, Eldar Khayrullin wrote: I find that I can select horizontal and vertical justification of Kicad text but vertical justify don't accessible from GUI. Can I use vertical justify? >

Re: [Kicad-developers] [PATCH] fix position of text and refdes from PCAD import

2016-02-25 Thread Eldar Khayrullin
I find that I can select horizontal and vertical justification of Kicad text but vertical justify don't accessible from GUI. Can I use vertical justify? > On Feb 25 2016, at 7:02 pm, Eldar Khayrullin wrote: I think about this. But in the begining I'll try to use easy w

Re: [Kicad-developers] [PATCH] fix position of text and refdes from PCAD import

2016-02-25 Thread Eldar Khayrullin
I think about this. But in the begining I'll try to use easy way: using parametr 'extent' and calculate more pretty scale from PCAD to Kicad height and width > On Feb 25 2016, at 2:59 am, Piotr Esden-Tempski wrote: > > Regarding variable width font. I ran into the issue whe

Re: [Kicad-developers] [PATCH] fix position of text and refdes from PCAD import

2016-02-24 Thread Piotr Esden-Tempski
Regarding variable width font. I ran into the issue when I was trying to generate symbols for KiCad. To solve it I have generated a table with glyph widths from the C code used in KiCad itself. You can find my python table here: https://github.com/esden/stm32-kicad-lib/blob/master/script/kicadli

Re: [Kicad-developers] [PATCH] fix position of text and refdes from PCAD import

2016-02-24 Thread Eldar Khayrullin
Ok, glad to help. > On Feb 24 2016, at 8:55 pm, Wayne Stambaugh wrote: > > If the differences are due to variable font width issues then there is not much we can do about that. Thanks for fixing this. > > On 2/24/2016 11:57 AM, Eldar Khayrullin wrote: > PCAD stro

Re: [Kicad-developers] [PATCH] fix position of text and refdes from PCAD import

2016-02-24 Thread Wayne Stambaugh
If the differences are due to variable font width issues then there is not much we can do about that. Thanks for fixing this. On 2/24/2016 11:57 AM, Eldar Khayrullin wrote: > PCAD stroke font isn't fixed width font and KiCad font too. > I look for possible and try to solve this with more easy way

Re: [Kicad-developers] [PATCH] fix position of text and refdes from PCAD import

2016-02-24 Thread Eldar Khayrullin
PCAD stroke font isn't fixed width font and KiCad font too. I look for possible and try to solve this with more easy way > On Feb 24 2016, at 7:51 pm, Wayne Stambaugh wrote: > > Eldar, > > Are you planning on actually determining the appropriate PCAD units for te

Re: [Kicad-developers] [PATCH] fix position of text and refdes from PCAD import

2016-02-24 Thread Wayne Stambaugh
Eldar, Are you planning on actually determining the appropriate PCAD units for text so that this can be converted accurately? While you patch makes things better, I would prefer that we convert boards as accurately as possible. I know we don't handle different fonts but there should be no reason

Re: [Kicad-developers] [PATCH] fix position of text and refdes from PCAD import

2016-02-24 Thread Eldar Khayrullin
Thank you. Not ideal yet, but more truely > On Feb 24 2016, at 3:00 pm, jp charras wrote: > > Le 23/02/2016 13:36, Eldar Khayrullin a écrit : > Result > >> On Feb 23 2016, at 3:29 pm, Eldar Khayrullin > <eldar.khayrul...@mail.ru> wrote: > Apply Justify o

Re: [Kicad-developers] [PATCH] fix position of text and refdes from PCAD import

2016-02-24 Thread jp charras
Le 23/02/2016 13:36, Eldar Khayrullin a écrit : > Result > >> On Feb 23 2016, at 3:29 pm, Eldar Khayrullin > wrote: > Apply Justify of text and flipped flag of text from import file. I committed your patches. AFAIK, they look good for me. Thanks. -- Jean-Pierre C

Re: [Kicad-developers] [PATCH] fix position of text and refdes from PCAD import

2016-02-23 Thread Eldar Khayrullin
Result > On Feb 23 2016, at 3:29 pm, Eldar Khayrullin wrote: Apply Justify of text and flipped flag of text from import file. > >> On Feb 23 2016, at 12:00 pm, Eldar Khayrullin wrote: Hello. >> >> I rebase patches. >> >> PS: All siz

Re: [Kicad-developers] [PATCH] fix position of text and refdes from PCAD import

2016-02-23 Thread Eldar Khayrullin
Apply Justify of text and flipped flag of text from import file. > On Feb 23 2016, at 12:00 pm, Eldar Khayrullin wrote: Hello. > > I rebase patches. > > PS: All sizes in Kicad internal units. > >> On Feb 22 2016, at 9:35 pm, Wayne Stambaugh

Re: [Kicad-developers] [PATCH] fix position of text and refdes from PCAD import

2016-02-23 Thread Eldar Khayrullin
Hello. I rebase patches. PS: All sizes in Kicad internal units. > On Feb 22 2016, at 9:35 pm, Wayne Stambaugh wrote: > > Eldar, > > There is something unsettling about your patch. Why are there different scalars applied when calculating the length of the text versu

Re: [Kicad-developers] [PATCH] fix position of text and refdes from PCAD import

2016-02-22 Thread Wayne Stambaugh
Eldar, There is something unsettling about your patch. Why are there different scalars applied when calculating the length of the text versus the height? This would suggest the PCAD file format does not use the same units for text height, text width, and text position. It appears to me that you

Re: [Kicad-developers] [PATCH] fix position of text and refdes from PCAD import

2016-02-22 Thread Eldar Khayrullin
Next patch continue fixing bug https://bugs.launchpad.net/kicad/+bug/1547822 > On Feb 22 2016, at 7:55 pm, Eldar Khayrullin wrote: Hello. Patch attached. P.S. need work to correct a justification of text and text size (I do) >From 766b6e5b5859b8209f5fac79655295aa0

[Kicad-developers] [PATCH] fix position of text and refdes from PCAD import

2016-02-22 Thread Eldar Khayrullin
Hello. Patch attached. P.S. need work to correct a justification of text and text size (I do) >From f5647e191d15e833164076fcd8f35981513e4a98 Mon Sep 17 00:00:00 2001 From: Eldar Khayrullin Date: Mon, 22 Feb 2016 19:46:16 +0300 Subject: [PATCH] Fix position of text and refdes for PCAD import