Re: [Kicad-developers] [PATCH] better UI experience (properties window)

2017-04-01 Thread Fabrizio Tappero
thanks a lot Wayne, cheers Fabrizio On Fri, Mar 31, 2017 at 10:27 PM, Wayne Stambaugh wrote: > Fabrizio, > > I pushed your patch to the master branch. Thank you for your contribution. > > Cheers, > > Wayne > > On 3/30/2017 7:28 AM, Fabrizio Tappero wrote: > > Hi Wayne, > > OK, I fixed the prob

Re: [Kicad-developers] [PATCH] better UI experience (properties window)

2017-03-31 Thread Wayne Stambaugh
Fabrizio, I pushed your patch to the master branch. Thank you for your contribution. Cheers, Wayne On 3/30/2017 7:28 AM, Fabrizio Tappero wrote: > Hi Wayne, > OK, I fixed the problem. Please refer to the patch in attachment, it > will produce this: > > ​Inline image 1​ > > ​I tried to use th

Re: [Kicad-developers] [PATCH] better UI experience (properties window)

2017-03-28 Thread Wayne Stambaugh
Hey Fabrizio, No problem. Thank you for the update. Cheers, Wayne On 3/28/2017 1:41 PM, Fabrizio Tappero wrote: > Hi Wayne, > yeah I have wrongly inserted the patch file into it. I can fix it but I > need two days to get back to my PC. > > I will get back to you on Thursday > > cheers > Fabr

Re: [Kicad-developers] [PATCH] better UI experience (properties window)

2017-03-28 Thread Fabrizio Tappero
Hi Wayne, yeah I have wrongly inserted the patch file into it. I can fix it but I need two days to get back to my PC. I will get back to you on Thursday cheers Fabrizio On Tue, Mar 28, 2017 at 6:43 PM, Wayne Stambaugh wrote: > Hey Fabrizio, > > Still no luck. Here is the `git am` output: > >

Re: [Kicad-developers] [PATCH] better UI experience (properties window)

2017-03-28 Thread Andrey Kuznetsov
Actually, "Rotation" does make more sense, and it's a compact word. Add degree symbols to each rotation value, and use 0 90 180 270 instead of doing the + - thing. On Tue, Mar 28, 2017 at 4:19 AM, Clemens Koller wrote: > Hi! > > On 2017-03-28 12:30, Ingo Kletti wrote: > > Am 28.03.2017 um 10:06

Re: [Kicad-developers] [PATCH] better UI experience (properties window)

2017-03-28 Thread Wayne Stambaugh
Hey Fabrizio, Still no luck. Here is the `git am` output: $ git am < /c/Users/Wayne/Archive/temp/kicad/patches/better-properties-wind.patch Applying: commit 49df104f1b7c7e7ac4a1087a7dc3bfef053fcc33 error: better-properties-wind.patch: does not exist in index error: patch failed: eeschema/dialogs

Re: [Kicad-developers] [PATCH] better UI experience (properties window)

2017-03-28 Thread Fabrizio Tappero
Hi Wayne, here you go. I am having some problems with this PC. cheers Fabrizio On Tue, Mar 28, 2017 at 4:40 PM, Wayne Stambaugh wrote: > Fabrizio, > > I just attempt to apply this patch and both `git am` and `patch` are > failing to apply the patch. Please rebase and resend it. > > Thanks,

Re: [Kicad-developers] [PATCH] better UI experience (properties window)

2017-03-28 Thread Wayne Stambaugh
Fabrizio, I just attempt to apply this patch and both `git am` and `patch` are failing to apply the patch. Please rebase and resend it. Thanks, Wayne On 3/28/2017 4:06 AM, Fabrizio Tappero wrote: > Hi guys, > OK, fixed all problems ;-) > > Inline image 1 > > Please note that, as rightly sugg

Re: [Kicad-developers] [PATCH] better UI experience (properties window)

2017-03-28 Thread Clemens Koller
Hi! On 2017-03-28 12:30, Ingo Kletti wrote: > Am 28.03.2017 um 10:06 schrieb Fabrizio Tappero: >> [...] >> In my opinion, I think "(degrees)" should not be plural and should not >> between brackets but if you like it this way so be it. > > Concerning the brackets, the 'Bureau International des Po

Re: [Kicad-developers] [PATCH] better UI experience (properties window)

2017-03-28 Thread Ingo Kletti
Am 28.03.2017 um 10:06 schrieb Fabrizio Tappero: [...] In my opinion, I think "(degrees)" should not be plural and should not between brackets but if you like it this way so be it. Concerning the brackets, the 'Bureau International des Poids et Mesures' states that units should be separated by

Re: [Kicad-developers] [PATCH] better UI experience (properties window)

2017-03-28 Thread Marco Ciampa
On Tue, Mar 28, 2017 at 10:06:42AM +0200, Fabrizio Tappero wrote: > In my opinion, I think "(degrees)" should not be plural and should not > between brackets but if you like it this way so be it. Wikipedia uses degrees: https://en.wikipedia.org/wiki/Gradian#Conversion hope it helps -- Marco C

Re: [Kicad-developers] [PATCH] better UI experience (properties window)

2017-03-27 Thread Aaron Pelly
Vertical position could probably do with swapping the align bottom and align top radio buttons too; seems more logical. (This time to the list. Sorry Wayne.) On 28/03/17 06:12, Wayne Stambaugh wrote: > Please change "Orientation, degree" to "Orientation (degrees)" > > The spacing still isn't cor

Re: [Kicad-developers] [PATCH] better UI experience (properties window)

2017-03-27 Thread Wayne Stambaugh
Please change "Orientation, degree" to "Orientation (degrees)" The spacing still isn't correct between the "Font Size", "X Position", and "Y Position" controls. There is more space between the "Font Size" and "X Position controls than there is between the "X Position" and "Y Position" controls.

Re: [Kicad-developers] [PATCH] better UI experience (properties window)

2017-03-27 Thread Fabrizio Tappero
here the current look [image: Inline image 1] On Mon, Mar 27, 2017 at 6:17 PM, Fabrizio Tappero < fabrizio.tapp...@gmail.com> wrote: > Hi Wayne, > sure no problem. Here you go. > > Let me know if you want something else to be changed. > > cheers > Fabrizio > PS I do not seem to understand how to

Re: [Kicad-developers] [PATCH] better UI experience (properties window)

2017-03-27 Thread Fabrizio Tappero
Hi Wayne, sure no problem. Here you go. Let me know if you want something else to be changed. cheers Fabrizio PS I do not seem to understand how to change the spacing of the font size and X pos elements... On Mon, Mar 27, 2017 at 4:12 PM, Wayne Stambaugh wrote: > Hey Fabrizio, > > Sorry I d

Re: [Kicad-developers] [PATCH] better UI experience (properties window)

2017-03-27 Thread Wayne Stambaugh
Hey Fabrizio, Sorry I didn't comment on this sooner but I've been busy. I have a few comments: "Custom Fields" should just read "Fields". The first four fields are mandatory so the word custom is misleading. The "Assert" button is confusing. This button tests the component name but does not u