Re: [Kicad-developers] [PATCH] Setting grid line sizes and density

2017-02-20 Thread Maciej Sumiński
Hi John, Well done! Now everything works as expected, so I have just committed your patches. Thank you for your contribution. Cheers, Orson On 02/16/2017 07:05 PM, John Beard wrote: > Hi Orson, > > I have modified the incrementer control to unbind from the kill focus > event. This meant I could

Re: [Kicad-developers] [PATCH] Setting grid line sizes and density

2017-02-16 Thread John Beard
Hi Orson, I have modified the incrementer control to unbind from the kill focus event. This meant I couldn't use a lambda - if you know how to unbind from a lambda without a lot of messing around, please let me know! I have also made it so the increment GetValue will update the value before retur

Re: [Kicad-developers] [PATCH] Setting grid line sizes and density

2017-02-16 Thread John Beard
Hi Orson, Thank you very much for checking! I see you found mydeliberate...last minute mistakes! That's very strage about the enter thing, I certainly tried it before but now I see a segfault as well. I will try to work out how to unbind from a lambda, as I suspect you are right. Cheers, Jo

Re: [Kicad-developers] [PATCH] Setting grid line sizes and density

2017-02-16 Thread Maciej Sumiński
Hi John, Thank you very much, I see lots of great improvements here. Your branch is a good candidate for merge, but there is one problem. If I type a value in INCREMENT_TEXT_CTRL and hit Enter, pcbnew segfaults. I suspect that kill focus event handler is executed after the window is gone, but I am

[Kicad-developers] [PATCH] Setting grid line sizes and density

2017-02-15 Thread John Beard
Hi, Here is a branch with a set of patches to add the ability to set the grid line/dot size and the minimum grid spacing (to avoid very dense grids when using thicker lines). https://code.launchpad.net/~john-j-beard/kicad/+git/kicad/+ref/grid_dot_size This also includes moving the grid display s