Hi hauptmech,
I am just now reading this thread and your previous one about the hotkeys.
I agree that there should not be hard-coded hotkeys!
In fact, this patch did not add the hotkeys, it was just moving code around
that already existed. I'm fine with looking in to moving the hotkeys out
of th
Hi Jon,
It looks like this patch did a lot of good stuff. Nice work!
I don't use kicad often, but when I do, it's with a carefully optimized
keyboard mapping and enough stimulants that I look like a professional
starcraft player with the fingers flying and the crowd cheering. Really
something
That was a really good refactor, now the code seems much cleaner. I have
just committed your patches. Once again, thank you Jon!
Regards,
Orson
On 02/20/2017 07:12 PM, Jon Evans wrote:
> This time with the patch attached :)
>
> On Mon, Feb 20, 2017 at 1:12 PM, Jon Evans wrote:
>
>> Hi Orson,
>
This time with the patch attached :)
On Mon, Feb 20, 2017 at 1:12 PM, Jon Evans wrote:
> Hi Orson,
>
> I've attached a follow-up patch that moves all TOOL_ACTIONs out of
> pcb_actions.cpp and creates a COMMON_TOOLS class for storing
> cross-application tools. I was not able to move all zoom/gri
Hi Orson,
I've attached a follow-up patch that moves all TOOL_ACTIONs out of
pcb_actions.cpp and creates a COMMON_TOOLS class for storing
cross-application tools. I was not able to move all zoom/grid tools
because of dependencies on pcbnew that need to be resolved -- I did not
want to take on the
Thank you John, we really appreciate your efforts.
Regards,
Orson
On 02/20/2017 03:50 PM, Jon Evans wrote:
> Hi Orson,
>
> I can definitely pull the pcb_actions into their respective files, I will
> do that and send another patch.
>
> Best,
> Jon
>
> On Mon, Feb 20, 2017 at 4:25 AM, John Beard
Hi Orson,
I can definitely pull the pcb_actions into their respective files, I will
do that and send another patch.
Best,
Jon
On Mon, Feb 20, 2017 at 4:25 AM, John Beard wrote:
> HI Orson,
>
> I think that sounds like a sensible idea. Having a huge central list
> of actions has a bit of a code
HI Orson,
I think that sounds like a sensible idea. Having a huge central list
of actions has a bit of a code smell for me, as it's a big header than
then needs including everywhere. Smaller lists that are included along
with their tool's headers (if needed), or even actions that are
totally hidde
Hi Jon,
I see the point of your patch, as COMMON_ACTIONS are now a bit misused.
They should not keep majority of the TOOL_ACTIONs, as many of them are
pcbnew specific, but there are still actions that will be shared with
other applications (e.g. zoom & grid control, move/rotate/flip).
For some ti
9 matches
Mail list logo
