Re: [Kicad-developers] [PATCH] QA: Polyset Distance tests

2019-01-30 Thread jp charras
Le 30/01/2019 à 11:51, John Beard a écrit : > Urgh, I have the inline but in another pending patch that preceded > this, so it got removed in rebase. > > Sorry! > > On Wed, Jan 30, 2019 at 10:27 AM Simon Richter > wrote: >> >> Hi, >> >> On 30.01.19 11:21, jp charras wrote: >> >>> E:/kicad-launc

Re: [Kicad-developers] [PATCH] QA: Polyset Distance tests

2019-01-30 Thread John Beard
Urgh, I have the inline but in another pending patch that preceded this, so it got removed in rebase. Sorry! On Wed, Jan 30, 2019 at 10:27 AM Simon Richter wrote: > > Hi, > > On 30.01.19 11:21, jp charras wrote: > > > E:/kicad-launchpad/testing_git/qa/unit_test_utils/include/unit_test_utils/geom

Re: [Kicad-developers] [PATCH] QA: Polyset Distance tests

2019-01-30 Thread Simon Richter
Hi, On 30.01.19 11:21, jp charras wrote: > E:/kicad-launchpad/testing_git/qa/unit_test_utils/include/unit_test_utils/geometry.h:18: > multiple definition of `operator<<(std::ostream&, BOX2 > > const&)' > CMakeFiles/qa_common_gerbview.dir/objects.a(test_shape_arc.cpp.obj):E:/kicad-launchpad/testin

Re: [Kicad-developers] [PATCH] QA: Polyset Distance tests

2019-01-30 Thread jp charras
Le 30/01/2019 à 10:47, John Beard a écrit : > HI Wayne, > > Thanks. I have realised there is a test failure in qa_common_eeschema > caused by unit rounding. It's currently "masked" by the polyset > failures. > > Patches attached: > > 1) Make polyset failures expected, so at least they won't mask

Re: [Kicad-developers] [PATCH] QA: Polyset Distance tests

2019-01-30 Thread John Beard
HI Wayne, Thanks. I have realised there is a test failure in qa_common_eeschema caused by unit rounding. It's currently "masked" by the polyset failures. Patches attached: 1) Make polyset failures expected, so at least they won't mask other errors or kill CI jobs while the polysets are worked on

Re: [Kicad-developers] [PATCH] QA: Polyset Distance tests

2019-01-29 Thread Wayne Stambaugh
Patches merged. Thanks, Wayne On 1/29/2019 5:40 PM, John Beard wrote: > Hi, > > Following the QA patch set just merged, here are a couple more. > > 1) Add tests on SHAPE_POLY_SET::Distance and a few geometry helpers > for concisely constructing test objects. Notably: this test would have > cau

[Kicad-developers] [PATCH] QA: Polyset Distance tests

2019-01-29 Thread John Beard
Hi, Following the QA patch set just merged, here are a couple more. 1) Add tests on SHAPE_POLY_SET::Distance and a few geometry helpers for concisely constructing test objects. Notably: this test would have caught the bug just fixed in 90178eb68. 2) Some internal QA tidy up to make the qa-interna