You are welcome!
I want to slowly get more into the internas of KiCAD as long as my time permits
(*aehrm*).
These little patches / tasks might help a bit.
Regards,
Clemens
On 2017-02-15 09:48, hauptmech wrote:
> Hi Clemens,
>
> Hopefully my hacking of the mail header drops this in the correct
Hi Clemens,
Hopefully my hacking of the mail header drops this in the correct thread
Thanks for the cleaning up the coding style. That was very cool of you.
-hauptmech
___
Mailing list: https://launchpad.net/~kicad-developers
Post to : kicad
No, we don't really use sign-off's, but you added it to your patch.
2017-02-14 10:35 GMT+01:00 Clemens Koller :
> Thanks!
>
> Do we actually collect "Sign-offs" of the devs/authors for KiCAD?
>
> And - I forgot: There are similar locations in the code with could run into
> the same issues.
> I di
Thanks!
Do we actually collect "Sign-offs" of the devs/authors for KiCAD?
And - I forgot: There are similar locations in the code with could run into the
same issues.
I didn't / couldn't check these.
Regards,
Clemens
On 2017-02-13 23:33, Chris Pavlina wrote:
> Thank you both. I pushed the f
Thank you both. I pushed the fixed patch, crediting hauptmech as the
original author and leaving Clemens' signoff.
On Mon, Feb 13, 2017 at 10:07:56PM +0100, Clemens Koller wrote:
> Well...
>
> I had a look at this for my very own training pleasure and updated the patch
> from Hauptmechto to suit
Well...
I had a look at this for my very own training pleasure and updated the patch
from Hauptmechto to suit the coding style AFAICT.
(attached)
Regards,
Clemens
On 2017-02-13 21:09, hauptmech wrote:
> Thanks for the heads up Chris.
>
> Respectfully to the developers, I don't have time. If t
Thanks for the heads up Chris.
Respectfully to the developers, I don't have time. If this does not
match your coding style then consider it bug report.
-Hauptmech
On 14/02/17 04:00, Chris Pavlina wrote:
Thank you for your contribution.
We're generally pretty strict about the coding style fo
Hi hauptmech,
I've been informed that my terseness could be mistaken for lack of
appreciation for your efforts. I apologize if the that was your
impression because that was not my intent. I am extremely busy at the
moment so I am trying to keep my responses as short as possible and the
amount of
Thank you for your contribution.
We're generally pretty strict about the coding style for new code; it
can be found at Documentation/development/coding-style-policy.md in the
source tree. If you don't see what the problem is, pay particular
attention to spacing around parentheses, and to the place
Please fix you coding policy violations so this patch can be merged.
On 2/13/2017 6:30 AM, hauptmech wrote:
> When attempting to read a pcad file exported from Altium, kicad was
> segfaulting because it was trying to access an empty array. This patch
> fixes that.
>
> The reason the array was emp
When attempting to read a pcad file exported from Altium, kicad was
segfaulting because it was trying to access an empty array. This patch
fixes that.
The reason the array was empty was the the board outline in the pcad
file was composed of only arcs and the plugin only processes lines in
the
11 matches
Mail list logo
