Re: [Kicad-developers] [PATCH] Import attributes and variants from eagle.

2018-07-31 Thread Seth Hillbrand
Mark- Looks good. I committed your patch with minor modifications. Thank you for your contribution to KiCad. Best- Seth Am Di., 31. Juli 2018 um 04:35 Uhr schrieb : > Hello Seth, > > I think I fixed all the problems you mention in the attached patch. > > - Why are you storing unknown

Re: [Kicad-developers] [PATCH] Import attributes and variants from eagle.

2018-07-30 Thread Seth Hillbrand
Hi Mark- Generally looks good. There are a few coding style issues and a couple questions. The coding style issues - else on new line - empty () should not have spaces - blank line above if statements Questions: - Why are you storing unknown attributes? Are these used for something? - The bool

Re: [Kicad-developers] [PATCH] Import attributes and variants from eagle.

2018-07-23 Thread Seth Hillbrand
Thanks Mark, I'll be able to test this out next week. -S Am Mo., 23. Juli 2018 um 01:52 Uhr schrieb : > Hello Seth, > > As requested an example eagle project using variants. > > regards > > Mark. > ___ Mailing list: https://launchpad.net/~kicad-develop

Re: [Kicad-developers] [PATCH] Import attributes and variants from eagle.

2018-07-23 Thread mdoesbur
Hello Seth, As requested an example eagle project using variants. regards Mark. eagle_variant.tgz Description: Binary data ___ Mailing list: https://launchpad.net/~kicad-developers Post to : kicad-developers@lists.launchpad.net Unsubscribe : http

Re: [Kicad-developers] [PATCH] Import attributes and variants from eagle.

2018-07-17 Thread mdoesbur
Hello Seth, I don't know how to use eagle myself, but will ask a colleague to create a small sample project. He's on vacation right now but will be back next week. regards, Mark. ___ Mailing list: https://launchpad.net/~kicad-developers Post to :

Re: [Kicad-developers] [PATCH] Import attributes and variants from eagle.

2018-07-17 Thread Seth Hillbrand
Hi Mark- Thank you for your contribution. It would be helpful to evaluating the patch if you could provide an example Eagle project that uses the variants feature. Best- Seth Am Mo., 16. Juli 2018 um 23:49 Uhr schrieb : > From: Mark van Doesburg > > Here is a patch that copies all attributes

[Kicad-developers] [PATCH] Import attributes and variants from eagle.

2018-07-16 Thread mdoesbur
From: Mark van Doesburg Here is a patch that copies all attributes from an original eagle schematic. This is necessary for me to keep the BOM the same. Since kicad does not yet support variants, it creates additional fields for values that differ for variants. It prefixes them with "VARIANT_"