Seth,
I merged you patch set into the development branch. Nice work and thank
you for you contribution to KiCad.
Cheers,
Wayne
On 11/29/2017 2:14 PM, Seth Hillbrand wrote:
> Here is the re-based patchset. No code changes but I repaired the
> coding policy violations.
>
> Best-
> Seth
>
> On
Here is the re-based patchset. No code changes but I repaired the coding
policy violations.
Best-
Seth
On Wed, Nov 29, 2017 at 7:40 AM, Wayne Stambaugh
wrote:
> Seth,
>
> I've done some minimal testing with this patch set and it appears to
> work as expected. I like the way it handles junctio
Seth,
I've done some minimal testing with this patch set and it appears to
work as expected. I like the way it handles junctions and it does
resolve the undo issue I was having with the overlapped wires/buses. I
am assuming this is the latest patch set and that there are no other
patches that ne
I have been playing with these patches for a bit and I like it, so far I
can't find any bad behavior and it nicely improves the way junctions are
managed.
-Jon
On Tue, Nov 28, 2017 at 2:19 PM, Wayne Stambaugh
wrote:
> This does not really qualify as a new feature but rather a fix of an
> existi
This does not really qualify as a new feature but rather a fix of an
existing feature. Given the number of bug fixes linked to the changes,
I'm OK with merging it assuming it's ready to go. I only have a few
comments. I saw at least one Doxygen comment in a source file instead
of the header and
Hi Orson-
Thanks for the pointer. I found and corrected the issue and updated the
commit messages to remove the NEW/CHANGED tags that didn't reflect
user-visible changes.
Since we're now in feature freeze, this may be too late for 5.0. However,
this does address a number of bug reports so I'm a
Hi Seth,
I tried this with interf_u demo shipped with the source code. There are
four capacitors in the left bottom corner - try dragging one of the
middle ones out. If you cannot reproduce the problem, I will try to
shoot a video.
Cheers,
Orson
On 11/25/2017 03:58 PM, Seth Hillbrand wrote:
> Hi
Hi Orson-
Thanks for the test and the clarification of the documentation.
On the schematic, I can't seem to recreate the issue you document in the
image. Is the example schematic one you can share?
Best-
Seth
On Fri, Nov 24, 2017 at 6:50 AM, Maciej Sumiński
wrote:
> Hi Seth,
>
> I tested the
The related issue
https://bugs.launchpad.net/kicad/+bug/1491052
В Среда, 22 ноя. 2017 в 11:07 П. П., Seth Hillbrand
написал:
Updated patchset for this proposal, rebased to master. I've also
updated the commit messages to match the CHANGE:/NEW: format and
added one new bug from launchpad that
Hi Seth,
I tested the branch and I consider it a significant improvement to the
way junctions are handled. I confirm it fixes the four bugs mentioned in
patch 0011, apart from a single case when a parallel component is
dragged out. In this case junctions are not still not auto deleted (see
[1], th
Updated patchset for this proposal, rebased to master. I've also updated
the commit messages to match the CHANGE:/NEW: format and added one new bug
from launchpad that this addresses.
-Seth
On Wed, Nov 8, 2017 at 3:59 AM, Nick Østergaard wrote:
> For that specific issue with the junction drawi
For that specific issue with the junction drawing, there is a patch in the
thread "[Kicad-developers] [PATCH] Draw junctions last"
2017-11-03 13:12 GMT+01:00 Jon Evans :
> I looked at fixing this and some other related things, and decided to just
> wait for the GAL port. There will need to be hug
I looked at fixing this and some other related things, and decided to just
wait for the GAL port. There will need to be huge refactoring of the
eeschema draw code as part of that effort, so putting much effort into
making the wxDC drawing better seems not worth it.
-Jon
On Nov 3, 2017 00:08, "Kev
On 2017-11-02 06:31 PM, Seth Hillbrand wrote:
Please let me know if there are any additional issues or suggestions for
improvement.
How difficult would it be to have junctions draw last on schematics? There
is a minor negative visual effect when you have a component with one end
joined to a w
Hi All-
Attached is an updated patchset for this feature, rebased to current master.
This should resolve the issues that Nick and Michael reported as well as
update to handle imported Eagle schematics.
Please let me know if there are any additional issues or suggestions for
improvement.
Thanks-
Michael-
Thank you for catching that. I'll incorporate your suggestion into the
patchset.
Best-
Seth
On Sun, Oct 29, 2017 at 3:06 AM, Michael Geselbracht <
mgeselbrac...@gmail.com> wrote:
> Hi,
>
> just tested your patches. I think it is an improvement over the current
> master.
> But with thi
Hi,
just tested your patches. I think it is an improvement over the current
master.
But with this patch eeschema crashes on opening some (hierarchical)
sheets either by double-clicking or using the navigator.
I have changed eeschema/schematic_undo_redo.cpp:182
from
if( commandToUndo->m_Statu
Hi Nick-
I've tried this action ('g' to drag for me, 'd' is not mapped unless I
missed a step) on all of schematics in my own library as well as the demos
but can't get it to crash with the updated patch.
Would you be able to send me a copy of your schematic?
Thanks-
Seth
On Sat, Oct 28, 2017 a
Thank you. But I still get the same assert.
All I do it hit d on my cap and move the pin anchor to the middle of the T
junction where the one pin is on the same net.
2017-10-28 21:30 GMT+02:00 Seth Hillbrand :
> Thank you Nick for testing! Looks like a missed a `break` when
> re-formatting from
Thank you Nick for testing! Looks like a missed a `break` when
re-formatting from the first commit.
I've corrected the issue in the attached patch set.
-Seth
On Sat, Oct 28, 2017 at 5:49 AM, Nick Østergaard wrote:
> Hello Seth
>
> I am not entirely sure what these patches actually do, but I t
Hello Seth
I am not entirely sure what these patches actually do, but I tired to test
them.
But I have major problems with dragging stuff around in kicad. On the
attached I dragged a capacitor to the T junction on the wire above it.
If I make the asserts continue I get a blank page eventually.
Hi,
On 28.10.2017 02:09, Seth Hillbrand wrote:
> Quick ping on this. Master has moved on, so I've re-based the patch set
> to the current master, in case anyone is up for looking at it. I also
> split out the largest patch into a couple of logical blocks, in hopes of
> making it easier to revie
Hi All-
Quick ping on this. Master has moved on, so I've re-based the patch set to
the current master, in case anyone is up for looking at it. I also split
out the largest patch into a couple of logical blocks, in hopes of making
it easier to review.
Lastly, I found and fixed a corner case wher
Attached is a proposed patchset for automatically managing junctions,
adding and deleting them as they are needed by the schematic.
The patches touch a number of sections, so any reports of issues would be
greatly appreciated. Notably, this introduces an "append" feature to
eeschema's undo save,
24 matches
Mail list logo
