Re: [Kicad-developers] [PATCH] DIALOG_SHIM default event handler fixes.

2016-04-11 Thread Wayne Stambaugh
I've grumbled about it quite a few times in the past but now it's official. :) I'll update the UI policy when I get a chance. On 4/11/2016 8:11 AM, Chris Pavlina wrote: > I thought you declared that policy a while ago :) > > On Apr 8, 2016 4:39 PM, "Wayne Stambaugh"

Re: [Kicad-developers] [PATCH] DIALOG_SHIM default event handler fixes.

2016-04-11 Thread Wayne Stambaugh
On 4/11/2016 2:12 AM, Lorenzo Marcantonio wrote: > On Fri, Apr 08, 2016 at 04:39:24PM -0400, Wayne Stambaugh wrote: >> I've known for a while that the quasi-modal mode provided by DIALOG_SHIM >> was broken. The only reason it hasn't reared it's head is because of > > Congratz for finding the issu

Re: [Kicad-developers] [PATCH] DIALOG_SHIM default event handler fixes.

2016-04-11 Thread Chris Pavlina
I thought you declared that policy a while ago :) On Apr 8, 2016 4:39 PM, "Wayne Stambaugh" wrote: > I've known for a while that the quasi-modal mode provided by DIALOG_SHIM > was broken. The only reason it hasn't reared it's head is because of > the design of most of dialogs. If you call any d

Re: [Kicad-developers] [PATCH] DIALOG_SHIM default event handler fixes.

2016-04-10 Thread Lorenzo Marcantonio
On Fri, Apr 08, 2016 at 04:39:24PM -0400, Wayne Stambaugh wrote: > I've known for a while that the quasi-modal mode provided by DIALOG_SHIM > was broken. The only reason it hasn't reared it's head is because of Congratz for finding the issue, I lost a lot of time in vain looking for the cause for

[Kicad-developers] [PATCH] DIALOG_SHIM default event handler fixes.

2016-04-08 Thread Wayne Stambaugh
I've known for a while that the quasi-modal mode provided by DIALOG_SHIM was broken. The only reason it hasn't reared it's head is because of the design of most of dialogs. If you call any dialog derived from DIALOG_SHIM using ShowQuasiModal() and allow the default button event handlers (wxID_OK,