Re: [Kicad-developers] [PATCH] Crash Reporter

2019-08-05 Thread Nick Østergaard
Ok, thanks. Just a note, there are two packages for msys2 mingw-packages that provided. I see you based your pkgbuild on the 3.0 one... On Thu, 1 Aug 2019 at 17:01, Tomasz Wlostowski wrote: > > On 30/07/2019 20:03, Nick Østergaard wrote: > > I get the same error. :( > > > > Hi Nick, > > We had t

Re: [Kicad-developers] [PATCH] Crash Reporter

2019-08-01 Thread Tomasz Wlostowski
On 30/07/2019 20:03, Nick Østergaard wrote: > I get the same error. :( > Hi Nick, We had two problems: - wrong check macro (I removed it in the last commit from my branch) - wrong build of wx (must be configured with --enable-backtrace - fixed PKGBUILD in the attachment). Latest code here: http

Re: [Kicad-developers] [PATCH] Crash Reporter

2019-07-30 Thread Nick Østergaard
I get the same error. :( On Tue, 30 Jul 2019 at 16:32, Tomasz Wlostowski wrote: > > On 30/07/2019 15:33, Nick Østergaard wrote: > > It was built like this: > > https://github.com/msys2/MINGW-packages/blob/c6dfad711f4d956a02e93026a0eb9a74ad6bfd65/mingw-w64-wxWidgets3.1/PKGBUILD > > > > Try buildin

Re: [Kicad-developers] [PATCH] Crash Reporter

2019-07-30 Thread Tomasz Wlostowski
On 30/07/2019 15:33, Nick Østergaard wrote: > It was built like this: > https://github.com/msys2/MINGW-packages/blob/c6dfad711f4d956a02e93026a0eb9a74ad6bfd65/mingw-w64-wxWidgets3.1/PKGBUILD > Try building wx with --enable-backtrace --enable-debugreport T. ___

Re: [Kicad-developers] [PATCH] Crash Reporter

2019-07-30 Thread Nick Østergaard
It was built like this: https://github.com/msys2/MINGW-packages/blob/c6dfad711f4d956a02e93026a0eb9a74ad6bfd65/mingw-w64-wxWidgets3.1/PKGBUILD On Tue, 30 Jul 2019 at 14:59, Tomasz Wlostowski wrote: > > On 30/07/2019 14:54, Nick Østergaard wrote: > > Exacept when I try to build it against wx 3.1 I

Re: [Kicad-developers] [PATCH] Crash Reporter

2019-07-30 Thread Tomasz Wlostowski
On 30/07/2019 14:54, Nick Østergaard wrote: > Exacept when I try to build it against wx 3.1 I get errors like: > > debug_report.cpp:515:5: error: 'YAML_STACK_WALKER' was not declared in > this scope > > Building against 3.0 is ok, but it crashes when it is trying to upload > a bug report. > > I

Re: [Kicad-developers] [PATCH] Crash Reporter

2019-07-30 Thread Nick Østergaard
Exacept when I try to build it against wx 3.1 I get errors like: debug_report.cpp:515:5: error: 'YAML_STACK_WALKER' was not declared in this scope Building against 3.0 is ok, but it crashes when it is trying to upload a bug report. I used -DwxWidgets_CONFIG_EXECUTABLE=${MINGW_PREFIX}/bin/wx-conf

Re: [Kicad-developers] [PATCH] Crash Reporter

2019-07-30 Thread Tomasz Wlostowski
On 29/07/2019 18:47, Nick Østergaard wrote: > I rebased this for todays master and pushed it to: > https://github.com/nickoe/kicad-source-mirror/tree/tom-crash-reporter-may27_rebased20190729 > > Diff view of changes: > https://github.com/nickoe/kicad-source-mirror/compare/7b5b807...nickoe:tom-cras

Re: [Kicad-developers] [PATCH] Crash Reporter

2019-07-29 Thread Nick Østergaard
I rebased this for todays master and pushed it to: https://github.com/nickoe/kicad-source-mirror/tree/tom-crash-reporter-may27_rebased20190729 Diff view of changes: https://github.com/nickoe/kicad-source-mirror/compare/7b5b807...nickoe:tom-crash-reporter-may27_rebased20190729?expand=1 I don't thi

Re: [Kicad-developers] [PATCH] Crash Reporter

2019-07-16 Thread Nick Østergaard
It looks like some of the errors are related to the lexer stuff. Can you try to rebase your branch to latest master? On Tue, 16 Jul 2019 at 13:00, Nick Østergaard wrote: > > @Tomasz Wlostowski I am trying to build against wx3.1, but I get > build errors, please review the build log: > > https://

Re: [Kicad-developers] [PATCH] Crash Reporter

2019-07-16 Thread Nick Østergaard
@Tomasz Wlostowski I am trying to build against wx3.1, but I get build errors, please review the build log: https://jenkins.simonrichter.eu/job/windows-kicad-msys2-patch/465/console On Tue, 16 Jul 2019 at 12:37, Nick Østergaard wrote: > > Hmm, ok, I guess you mean the -may27 one.. it seem to ha

Re: [Kicad-developers] [PATCH] Crash Reporter

2019-07-16 Thread Nick Østergaard
Hmm, ok, I guess you mean the -may27 one.. it seem to have never commits. https://github.com/twlostow/kicad-dev/tree/tom-crash-reporter-may27 On Tue, 16 Jul 2019 at 11:08, Tomasz Wlostowski wrote: > > On 15/07/2019 14:43, Nick Østergaard wrote: > > Remind me, is this feature still in a seperate

Re: [Kicad-developers] [PATCH] Crash Reporter

2019-07-16 Thread Tomasz Wlostowski
On 15/07/2019 14:43, Nick Østergaard wrote: > Remind me, is this feature still in a seperate branch to master, or > how is it enabled? IIRC it's still tom-crash-reporter on my github and it's enabled in CMake config (KICAD_CRASH_REPORTER=yes). T. > > On Thu, 11 Jul 2019 at 21:08, Nick Østergaar

Re: [Kicad-developers] [PATCH] Crash Reporter

2019-07-15 Thread Nick Østergaard
Remind me, is this feature still in a seperate branch to master, or how is it enabled? On Thu, 11 Jul 2019 at 21:08, Nick Østergaard wrote: > > @Tomasz Wlostowski I just found that it looks like someone has > uploaded a wxwidgets 3.1 pkgbuild for the mingw-packages for msys2, I > could try to bu

Re: [Kicad-developers] [PATCH] Crash Reporter

2019-07-11 Thread Nick Østergaard
@Tomasz Wlostowski I just found that it looks like someone has uploaded a wxwidgets 3.1 pkgbuild for the mingw-packages for msys2, I could try to build and and rebuild your branch for windows. https://github.com/msys2/MINGW-packages/blob/master/mingw-w64-wxWidgets3.1/PKGBUILD On Tue, 9 Jul 2019

Re: [Kicad-developers] [PATCH] Crash Reporter

2019-07-09 Thread Wayne Stambaugh
Tom, On 7/9/19 2:41 AM, Tomasz Wlostowski wrote: > On 06/07/2019 21:10, Ian McInerney wrote: >> Tom, >> >> Not to pile on the questions, but does the linux stack trace support >> exist in the entire 3.0.x line, or how far back does it go? Currently, >> the minimum version searched by cmake is 3.0.

Re: [Kicad-developers] [PATCH] Crash Reporter

2019-07-08 Thread Tomasz Wlostowski
On 06/07/2019 21:10, Ian McInerney wrote: > Tom, > > Not to pile on the questions, but does the linux stack trace support > exist in the entire 3.0.x line, or how far back does it go? Currently, > the minimum version searched by cmake is 3.0.0, and some major linux > distros only have 3.0.2 (Debia

Re: [Kicad-developers] [PATCH] Crash Reporter

2019-07-06 Thread Ian McInerney
Tom, Not to pile on the questions, but does the linux stack trace support exist in the entire 3.0.x line, or how far back does it go? Currently, the minimum version searched by cmake is 3.0.0, and some major linux distros only have 3.0.2 (Debian Stable, EPEL6/7, and Ubuntu 16.04 to name a few). -

Re: [Kicad-developers] [PATCH] Crash Reporter

2019-07-06 Thread Tomasz Wlostowski
On 06/07/2019 09:04, Carsten Schoenert wrote: > Hi, > > Am 05.07.19 um 23:28 schrieb Ian McInerney: >> 3.1.x is essentially only available on the lesser-known distros and as >> additional packages for OpenSUSE. Aside from that, most distros run >> anything between 3.0.2 and 3.0.4. (see >> here: ht

Re: [Kicad-developers] [PATCH] Crash Reporter

2019-07-06 Thread Carsten Schoenert
Hi, Am 05.07.19 um 23:28 schrieb Ian McInerney: > 3.1.x is essentially only available on the lesser-known distros and as > additional packages for OpenSUSE. Aside from that, most distros run > anything between 3.0.2 and 3.0.4. (see > here: https://repology.org/project/wxwidgets/versions). well, a

Re: [Kicad-developers] [PATCH] Crash Reporter

2019-07-05 Thread Ian McInerney
3.1.x is essentially only available on the lesser-known distros and as additional packages for OpenSUSE. Aside from that, most distros run anything between 3.0.2 and 3.0.4. (see here: https://repology.org/project/wxwidgets/versions). -Ian On Fri, Jul 5, 2019 at 7:52 PM Wayne Stambaugh wrote:

Re: [Kicad-developers] [PATCH] Crash Reporter

2019-07-05 Thread Wayne Stambaugh
Tom, On 7/4/19 8:54 AM, Tomasz Wlostowski wrote: > On 01/07/2019 23:49, Nick Østergaard wrote: >> Hello Tomasz >> >> Do you have any comments on the wxwidgets version? > > Hi Nick, > > I have 3.1.1 in my MSYS environment, probably manually built. > > We have two options: > - ask MSYS folks to u

Re: [Kicad-developers] [PATCH] Crash Reporter

2019-07-04 Thread Tomasz Wlostowski
On 01/07/2019 23:49, Nick Østergaard wrote: > Hello Tomasz > > Do you have any comments on the wxwidgets version? Hi Nick, I have 3.1.1 in my MSYS environment, probably manually built. We have two options: - ask MSYS folks to update wxWidgets in the package repository, - factor out stack trace

Re: [Kicad-developers] [PATCH] Crash Reporter

2019-07-01 Thread Nick Østergaard
Hello Tomasz Do you have any comments on the wxwidgets version? It looks like 3.0.4 of wxwidgets is the latest version packaged in msys2 as of today. On Wed, 12 Jun 2019 at 23:58, Nick Østergaard wrote: > > It looks like you mis-cited me there. That was Wayne that wrote that, > I don't klnow ab

Re: [Kicad-developers] [PATCH] Crash Reporter

2019-06-12 Thread Nick Østergaard
It looks like you mis-cited me there. That was Wayne that wrote that, I don't klnow about the details here. Anyway, the packages are shown on: https://jenkins.simonrichter.eu/job/windows-kicad-msys2-patch/ws/pkglist.txt/*view*/ mingw-w64-x86_64-wxWidgets 3.0.4-2 On Wed, 12 Jun 2019 at 14:10, Tom

Re: [Kicad-developers] [PATCH] Crash Reporter

2019-06-12 Thread Wayne Stambaugh
On 6/12/19 8:10 AM, Tomasz Wlostowski wrote: > On 11/06/2019 22:29, Nick Østergaard wrote: >> Too bad the gcc windows >> build crash report doesn't have a stack trace. Maybe MSVC builds would >> have more debug info. > > Hi Nick, > > My build (wx 3.1.1) under MSYS has stack traces. Which version

Re: [Kicad-developers] [PATCH] Crash Reporter

2019-06-12 Thread Tomasz Wlostowski
On 11/06/2019 22:29, Nick Østergaard wrote: > Too bad the gcc windows > build crash report doesn't have a stack trace. Maybe MSVC builds would > have more debug info. Hi Nick, My build (wx 3.1.1) under MSYS has stack traces. Which version of wxWidgets did you use? Tom _

Re: [Kicad-developers] [PATCH] Crash Reporter

2019-06-11 Thread Nick Østergaard
Yes, that was the same commit I tested as mentioned earlier. Although somehow added a "not" in the original message :) On Tue, 11 Jun 2019 at 00:52, Wayne Stambaugh wrote: > > Did you test the latest commit 2745a95b6b02c3864d6594503cc21619691cdd94? > > On 6/10/19 6:02 PM, Nick Østergaard wrote: >

Re: [Kicad-developers] [PATCH] Crash Reporter

2019-06-10 Thread Wayne Stambaugh
Did you test the latest commit 2745a95b6b02c3864d6594503cc21619691cdd94? On 6/10/19 6:02 PM, Nick Østergaard wrote: > It didn't seem to work for the use case I described on windows last week. > > On Mon, 10 Jun 2019 at 23:51, Wayne Stambaugh wrote: >> >> Hey Tom, >> >> On 6/4/2019 12:31 PM, Toma

Re: [Kicad-developers] [PATCH] Crash Reporter

2019-06-10 Thread Nick Østergaard
It didn't seem to work for the use case I described on windows last week. On Mon, 10 Jun 2019 at 23:51, Wayne Stambaugh wrote: > > Hey Tom, > > On 6/4/2019 12:31 PM, Tomasz Wlostowski wrote: > > On 04/06/2019 17:11, Tomasz Wlostowski wrote: > > > >> Hi Wayne, > >> > >> It looks like I screwed up

Re: [Kicad-developers] [PATCH] Crash Reporter

2019-06-10 Thread Wayne Stambaugh
Hey Tom, On 6/4/2019 12:31 PM, Tomasz Wlostowski wrote: > On 04/06/2019 17:11, Tomasz Wlostowski wrote: > >> Hi Wayne, >> >> It looks like I screwed up the exception handler under KiCad windows >> shell. Will fix soon. > > Fixed in my github branch. > > T. > I just finished testing this on wi

Re: [Kicad-developers] [PATCH] Crash Reporter

2019-06-04 Thread Nick Østergaard
You can testrun it on windows from: https://kicad-downloads.s3.cern.ch/windows/testing/patched/kicad-patched-371-5.1.0-770-g8bf750311-x86_64.exe On Wed, 5 Jun 2019 at 08:17, Eeli Kaikkonen wrote: > > I'm trying to compile the reporter branch on Kubuntu. The official master > branch compiles fin

Re: [Kicad-developers] [PATCH] Crash Reporter

2019-06-04 Thread Eeli Kaikkonen
I'm trying to compile the reporter branch on Kubuntu. The official master branch compiles fine. But with this branch I get a bunch of linking errors: debug_report.cpp:(.text._ZNSt6thread11_State_implINS_8_InvokerISt5tupleIJZN19DIALOG_CRASH_REPORT12OnSendReportER14wxCommandEventEUlvE_E6_M_runEv

Re: [Kicad-developers] [PATCH] Crash Reporter

2019-06-04 Thread Nick Østergaard
I just tried to trigger a crash via the help menu and I see a fine dialog, but that one I don't see for a real crash. On Wed, 5 Jun 2019 at 00:12, Nick Østergaard wrote: > > I mean: I am really on 2745a95b6 > > On Wed, 5 Jun 2019 at 00:11, Nick Østergaard wrote: > > > > Hello > > > > I just chec

Re: [Kicad-developers] [PATCH] Crash Reporter

2019-06-04 Thread Nick Østergaard
I mean: I am really on 2745a95b6 On Wed, 5 Jun 2019 at 00:11, Nick Østergaard wrote: > > Hello > > I just checkout out the crash reporter from Tom's branch. I am not on: > 2745a95b6 (HEAD, tom/tom-crash-reporter-may27) crash_reporter: > correctly install Windows exception handler under Kicad shel

Re: [Kicad-developers] [PATCH] Crash Reporter

2019-06-04 Thread Nick Østergaard
Hello I just checkout out the crash reporter from Tom's branch. I am not on: 2745a95b6 (HEAD, tom/tom-crash-reporter-may27) crash_reporter: correctly install Windows exception handler under Kicad shell I found a place in eeschema where it crashes. Specifically: 1. Open KiCad 2. Load the sallen_ke

Re: [Kicad-developers] [PATCH] Crash Reporter

2019-06-04 Thread Wayne Stambaugh
On 6/4/19 12:31 PM, Tomasz Wlostowski wrote: > On 04/06/2019 17:11, Tomasz Wlostowski wrote: > >> Hi Wayne, >> >> It looks like I screwed up the exception handler under KiCad windows >> shell. Will fix soon. > > Fixed in my github branch. > > T. > As soon as I get home on Sunday, I will test i

Re: [Kicad-developers] [PATCH] Crash Reporter

2019-06-04 Thread Tomasz Wlostowski
On 04/06/2019 17:11, Tomasz Wlostowski wrote: > Hi Wayne, > > It looks like I screwed up the exception handler under KiCad windows > shell. Will fix soon. Fixed in my github branch. T. ___ Mailing list: https://launchpad.net/~kicad-developers Post to

Re: [Kicad-developers] [PATCH] Crash Reporter

2019-06-04 Thread Tomasz Wlostowski
On 03/06/2019 14:42, Wayne Stambaugh wrote: > On 5/31/19 4:23 PM, Tomasz Wlostowski wrote: >> On 30/05/2019 21:12, Wayne Stambaugh wrote: >>> Nothing was displayed. I was running from the project manager. I even >>> crashed the project manager. I'm using msys2 to create mingw32 and >>> mingw64 d

Re: [Kicad-developers] [PATCH] Crash Reporter

2019-06-03 Thread Wayne Stambaugh
On 5/31/19 4:23 PM, Tomasz Wlostowski wrote: > On 30/05/2019 21:12, Wayne Stambaugh wrote: >> Nothing was displayed. I was running from the project manager. I even >> crashed the project manager. I'm using msys2 to create mingw32 and >> mingw64 debug builds of KiCad. I'm using wxWidgets 3.0.4 (

Re: [Kicad-developers] [PATCH] Crash Reporter

2019-05-31 Thread Tomasz Wlostowski
On 30/05/2019 21:12, Wayne Stambaugh wrote: > Nothing was displayed. I was running from the project manager. I even > crashed the project manager. I'm using msys2 to create mingw32 and > mingw64 debug builds of KiCad. I'm using wxWidgets 3.0.4 (not a debug > build). I did not check to see if t

Re: [Kicad-developers] [PATCH] Crash Reporter

2019-05-30 Thread Wayne Stambaugh
On 5/30/19 2:49 PM, Tomasz Wlostowski wrote: > On 30/05/2019 16:46, Wayne Stambaugh wrote: >> Hey Tom, >> >> On 5/29/2019 7:59 PM, Tomasz Wlostowski wrote: >>> On 30/05/2019 00:35, Wayne Stambaugh wrote: A `git pull` from https://github.com/twlostow/kicad-dev.git says I'm up to date.

Re: [Kicad-developers] [PATCH] Crash Reporter

2019-05-30 Thread Tomasz Wlostowski
On 30/05/2019 16:46, Wayne Stambaugh wrote: > Hey Tom, > > On 5/29/2019 7:59 PM, Tomasz Wlostowski wrote: >> On 30/05/2019 00:35, Wayne Stambaugh wrote: >>> A `git pull` from https://github.com/twlostow/kicad-dev.git says I'm up >>> to date. >>> >>> A note to the lead dev team, please do not push

Re: [Kicad-developers] [PATCH] Crash Reporter

2019-05-30 Thread Wayne Stambaugh
Hey Tom, On 5/29/2019 7:59 PM, Tomasz Wlostowski wrote: > On 30/05/2019 00:35, Wayne Stambaugh wrote: >> A `git pull` from https://github.com/twlostow/kicad-dev.git says I'm up >> to date. >> >> A note to the lead dev team, please do not push your personal >> development branches to the main kicad

Re: [Kicad-developers] [PATCH] Crash Reporter

2019-05-29 Thread Seth Hillbrand
On 2019-05-29 05:47, Maciej Suminski wrote: If everything works as expected, then you should be able to see your reports in my test project bug tracker [1]. The crash reporter should receive link to the new bug report in the HTTP response, so I guess it could be shown to the user. Once we are co

Re: [Kicad-developers] [PATCH] Crash Reporter

2019-05-29 Thread Tomasz Wlostowski
On 30/05/2019 00:35, Wayne Stambaugh wrote: > A `git pull` from https://github.com/twlostow/kicad-dev.git says I'm up > to date. > > A note to the lead dev team, please do not push your personal > development branches to the main kicad repo. Thanks. > It looks I'm the bad boy ;-) Just removed th

Re: [Kicad-developers] [PATCH] Crash Reporter

2019-05-29 Thread Seth Hillbrand
Hi Wayne- There are two similar branches there. I was testing tom-crash-reporter-may27 (not tom-crash-reporter). The line numbers in your error don't seem to match up with the ones I see. -Seth On 2019-05-29 18:35, Wayne Stambaugh wrote: A `git pull` from https://github.com/twlostow/kicad

Re: [Kicad-developers] [PATCH] Crash Reporter

2019-05-29 Thread Wayne Stambaugh
A `git pull` from https://github.com/twlostow/kicad-dev.git says I'm up to date. A note to the lead dev team, please do not push your personal development branches to the main kicad repo. Thanks. Wayne On 5/29/2019 5:32 PM, Nick Østergaard wrote: > Are you sure you did pull his latest changes?

Re: [Kicad-developers] [PATCH] Crash Reporter

2019-05-29 Thread Nick Østergaard
Are you sure you did pull his latest changes? It worked fine when I built it yesterday. https://jenkins.simonrichter.eu/job/windows-kicad-msys2-patch/369/ I just triggered a new build from his branch on github. A sidenote: Could we delete the branch from the official github on launchpad? And al

Re: [Kicad-developers] [PATCH] Crash Reporter

2019-05-29 Thread Wayne Stambaugh
Hey Tom, On 5/29/2019 9:56 AM, Tomasz Wlostowski wrote: > On 29/05/2019 06:07, Seth Hillbrand wrote: >> On 2019-05-28 12:13, Tomasz Wlostowski wrote: >>> >>> Done (tom-crash-reporter-may27 on my Github)! >>> >>> Tom >> >> Hi Tom- >> >> This looks very nice.  I like the implementation a lot! >> >>

Re: [Kicad-developers] [PATCH] Crash Reporter

2019-05-29 Thread Tomasz Wlostowski
On 29/05/2019 06:07, Seth Hillbrand wrote: > On 2019-05-28 12:13, Tomasz Wlostowski wrote: >> >> Done (tom-crash-reporter-may27 on my Github)! >> >> Tom > > Hi Tom- > > This looks very nice.  I like the implementation a lot! > > Here are a couple minor bits: > > 1) The force crash dialog says "

Re: [Kicad-developers] [PATCH] Crash Reporter

2019-05-29 Thread Wayne Stambaugh
Thanks Frank! On 5/29/2019 9:22 AM, Frank Severinsen wrote: > Hi Wayne > > Im guessing this one > https://github.com/twlostow/kicad-dev/tree/tom-crash-reporter-may27 > > > Den 29. maj 2019 kl. 15.00.19 +02.00, skrev Wayne Stambaugh > : >> Tom, >> >> On 5/28/2019 12:13 PM, Tomasz Wlostowski wrot

Re: [Kicad-developers] [PATCH] Crash Reporter

2019-05-29 Thread Frank Severinsen
Hi Wayne Im guessing this one Den 29. maj 2019 kl. 15.00.19 +02.00, skrev Wayne Stambaugh : > Tom, > > On 5/28/2019 12:13 PM, Tomasz Wlostowski wrote: > > > On 27/05/2019 17:39, Seth Hillbrand wrote: > > > > > On 2019-05-

Re: [Kicad-developers] [PATCH] Crash Reporter

2019-05-29 Thread Wayne Stambaugh
Tom, On 5/28/2019 12:13 PM, Tomasz Wlostowski wrote: > On 27/05/2019 17:39, Seth Hillbrand wrote: >> On 2019-05-02 17:41, Tomasz Wlostowski wrote: >>> On 02/05/2019 07:06, Wayne Stambaugh wrote: By chance did you build with OCC instead of OCE which is what I am using?  Please fix th

Re: [Kicad-developers] [PATCH] Crash Reporter

2019-05-29 Thread Seth Hillbrand
That's interesting. I don't see it there yet. Does your interface log the connections? I'll send another today and check for it again. -Seth On 2019-05-29 05:47, Maciej Suminski wrote: If everything works as expected, then you should be able to see your reports in my test project bug tracke

Re: [Kicad-developers] [PATCH] Crash Reporter

2019-05-29 Thread Maciej Suminski
If everything works as expected, then you should be able to see your reports in my test project bug tracker [1]. The crash reporter should receive link to the new bug report in the HTTP response, so I guess it could be shown to the user. Once we are confident with the crash reporter, I will modify

Re: [Kicad-developers] [PATCH] Crash Reporter

2019-05-28 Thread Seth Hillbrand
On 2019-05-28 12:13, Tomasz Wlostowski wrote: Done (tom-crash-reporter-may27 on my Github)! Tom Hi Tom- This looks very nice. I like the implementation a lot! Here are a couple minor bits: 1) The force crash dialog says "Clicking on OK will crash KiCad" but the buttons say "Yes/No" 2) Th

Re: [Kicad-developers] [PATCH] Crash Reporter

2019-05-28 Thread Tomasz Wlostowski
On 27/05/2019 17:39, Seth Hillbrand wrote: > On 2019-05-02 17:41, Tomasz Wlostowski wrote: >> On 02/05/2019 07:06, Wayne Stambaugh wrote: >>> >>> By chance did you build with OCC instead of OCE which is what I am >>> using?  Please fix this when you get a chance, I would like to get this >>> merged

Re: [Kicad-developers] [PATCH] Crash Reporter

2019-05-27 Thread Tomasz Wlostowski
On 27/05/2019 17:39, Seth Hillbrand wrote: > On 2019-05-02 17:41, Tomasz Wlostowski wrote: >> On 02/05/2019 07:06, Wayne Stambaugh wrote: >>> >>> By chance did you build with OCC instead of OCE which is what I am >>> using?  Please fix this when you get a chance, I would like to get this >>> merged

Re: [Kicad-developers] [PATCH] Crash Reporter

2019-05-27 Thread Seth Hillbrand
On 2019-05-02 17:41, Tomasz Wlostowski wrote: On 02/05/2019 07:06, Wayne Stambaugh wrote: By chance did you build with OCC instead of OCE which is what I am using? Please fix this when you get a chance, I would like to get this merged but I need to be able to test. Why did your remove the G

Re: [Kicad-developers] [PATCH] Crash Reporter

2019-05-02 Thread Tomasz Wlostowski
On 02/05/2019 07:06, Wayne Stambaugh wrote: > Hey Tom, > > I finally got around to testing this. I could not get it to build on > windows or linux. I'm getting the following compiler error on both 32 > and 64 bit windows and linux builds: > > E:/msys64/home/Wayne/src/kicad-lp-clone/common/debug

Re: [Kicad-developers] [PATCH] Crash Reporter

2019-05-02 Thread Wayne Stambaugh
Hey Tom, I finally got around to testing this. I could not get it to build on windows or linux. I'm getting the following compiler error on both 32 and 64 bit windows and linux builds: E:/msys64/home/Wayne/src/kicad-lp-clone/common/debug_report.cpp: In member function 'void DEBUG_REPORT::buildV

Re: [Kicad-developers] [PATCH] Crash Reporter

2019-04-16 Thread Carsten Schoenert
Hello, Am 16.04.19 um 23:25 schrieb Mark Roszko: > Just to throw it out there > > Did you consider at all at using something off the shelf such as > Breakpad which both Mozilla and Chrome use? > https://wiki.mozilla.org/Breakpad  > https://github.com/google/breakpad this has also some downsides.

Re: [Kicad-developers] [PATCH] Crash Reporter

2019-04-16 Thread Tomasz Wlostowski
On 16/04/2019 23:25, Mark Roszko wrote: > Just to throw it out there > > Did you consider at all at using something off the shelf such as > Breakpad which both Mozilla and Chrome use? > https://wiki.mozilla.org/Breakpad  > https://github.com/google/breakpad Hi Mark, I took some inspiration from

Re: [Kicad-developers] [PATCH] Crash Reporter

2019-04-16 Thread Tomasz Wlostowski
On 16/04/2019 22:52, Seth Hillbrand wrote: > Am 2019-04-14 18:50, schrieb Tomasz Wlostowski: >> Dear all, >> >> The attached patchset introduces a builtin crash reporter for Kicad - >> that is a window that pops up in case of a segmentation fault/other >> serious error, kindly apologizes to the use

Re: [Kicad-developers] [PATCH] Crash Reporter

2019-04-16 Thread Mark Roszko
Just to throw it out there Did you consider at all at using something off the shelf such as Breakpad which both Mozilla and Chrome use? https://wiki.mozilla.org/Breakpad https://github.com/google/breakpad There's then some off the shelf software potentially for processing Breakpad reports such as

Re: [Kicad-developers] [PATCH] Crash Reporter

2019-04-16 Thread Wayne Stambaugh
Tom, On 4/16/19 4:52 PM, Seth Hillbrand wrote: > Am 2019-04-14 18:50, schrieb Tomasz Wlostowski: >> Dear all, >> >> The attached patchset introduces a builtin crash reporter for Kicad - >> that is a window that pops up in case of a segmentation fault/other >> serious error, kindly apologizes to th

Re: [Kicad-developers] [PATCH] Crash Reporter

2019-04-16 Thread Seth Hillbrand
Am 2019-04-14 18:50, schrieb Tomasz Wlostowski: Dear all, The attached patchset introduces a builtin crash reporter for Kicad - that is a window that pops up in case of a segmentation fault/other serious error, kindly apologizes to the user and lets him/her submit (anonymously) a bug report to u