Re: [Kicad-developers] [PATCH] Array tools fixes (inc 5.1.0)

2019-01-30 Thread Seth Hillbrand
Am 2019-01-30 16:03, schrieb John Beard: Hi Wayne, The radius is currently calculated as the distance from the centre (which is in absolute terms) and the centre of the selection. Would be better to be the selected item position (selection centre can be slightly off from the item centre), but no

Re: [Kicad-developers] [PATCH] Array tools fixes (inc 5.1.0)

2019-01-30 Thread John Beard
Hi Wayne, The radius is currently calculated as the distance from the centre (which is in absolute terms) and the centre of the selection. Would be better to be the selected item position (selection centre can be slightly off from the item centre), but not sure what to do for a multiple selecti

Re: [Kicad-developers] [PATCH] Array tools fixes (inc 5.1.0)

2019-01-30 Thread Wayne Stambaugh
On 1/30/2019 1:01 PM, Seth Hillbrand wrote: > Am 2019-01-30 10:24, schrieb John Beard: >> Hi, >> >> Here are a bunch of refactors to fix some issues in the Array tool >> (including a 5.1.0 issue), as well as putting several things under >> test. Seems quite a lot has degraded in here, and I fixed

Re: [Kicad-developers] [PATCH] Array tools fixes (inc 5.1.0)

2019-01-30 Thread Seth Hillbrand
Am 2019-01-30 10:24, schrieb John Beard: Hi, Here are a bunch of refactors to fix some issues in the Array tool (including a 5.1.0 issue), as well as putting several things under test. Seems quite a lot has degraded in here, and I fixed a few long standing issues too. 1) Separate generic array