Re: [Kicad-developers] [FEATURE] Add keepout areas in footprints

JP, Given the feature freeze is now in place, I do not think this will make it for 5.0.0 release. I do not have time to spend on this currently, as I am focusing on library issues. Cheers, On Sun, Nov 5, 2017 at 11:58 PM, jp charras wrote: > Le 05/11/2017 à 12:04, Oliver Walters a écrit : > >

Re: [Kicad-developers] [FEATURE] Add keepout areas in footprints

Le 05/11/2017 à 12:04, Oliver Walters a écrit : > I think that is the desired behaviour, though? Once in the board, the can > edit the layers > individually anyway. I missed something, I did not notice it was possible the layers individually from the board editor. (However, when trying that, I h

Re: [Kicad-developers] [FEATURE] Add keepout areas in footprints

I think that is the desired behaviour, though? Once in the board, the can edit the layers individually anyway. On Sun, Nov 5, 2017 at 9:57 PM, jp charras wrote: > Le 05/11/2017 à 11:48, Oliver Walters a écrit : > > How best to store the layer information then? The way I was doing it > previously

Re: [Kicad-developers] [FEATURE] Add keepout areas in footprints

Le 05/11/2017 à 11:48, Oliver Walters a écrit : > How best to store the layer information then? The way I was doing it > previously was: > > -  F.Cu > - *.Inner.Cu > - B.Cu > > Is this sufficient? Yes, this is sufficient, when a keepout is inside a footprint. The issue was the fact *.Inner.Cu

Re: [Kicad-developers] [FEATURE] Add keepout areas in footprints

How best to store the layer information then? The way I was doing it previously was: - F.Cu - *.Inner.Cu - B.Cu Is this sufficient? On Sun, Nov 5, 2017 at 9:41 PM, jp charras wrote: > Le 05/11/2017 à 11:12, Oliver Walters a écrit : > > JP, > > > > Did you have any other things you want me to

Re: [Kicad-developers] [FEATURE] Add keepout areas in footprints

Le 05/11/2017 à 11:12, Oliver Walters a écrit : > JP, > > Did you have any other things you want me to address here? > > Cheers, > Oliver > Yes: I did not make a lot of tests, but I found some issues (tested on W7 32 bits): First, Pcbnew crashed after editing (after adding a keepout) a footpr

Re: [Kicad-developers] [FEATURE] Add keepout areas in footprints

JP, Did you have any other things you want me to address here? Cheers, Oliver On Wed, Nov 1, 2017 at 10:05 PM, Oliver Walters < oliver.henry.walt...@gmail.com> wrote: > Attached. > > On Wed, Nov 1, 2017 at 9:37 PM, jp charras wrote: > >> Le 01/11/2017 à 11:25, Oliver Walters a écrit : >> > JP,

Re: [Kicad-developers] [FEATURE] Add keepout areas in footprints

Le 01/11/2017 à 11:25, Oliver Walters a écrit : > JP, > > Did you see my other response? I applied your patch and also fixed all the > outstanding issues that I > was aware of. > > I posted that response on 26th October. > > Let me know if you want me to reattach the patch-set. > > Cheers, >

Re: [Kicad-developers] [FEATURE] Add keepout areas in footprints

JP, Did you see my other response? I applied your patch and also fixed all the outstanding issues that I was aware of. I posted that response on 26th October. Let me know if you want me to reattach the patch-set. Cheers, On Wed, Nov 1, 2017 at 9:11 PM, jp charras wrote: > Le 18/10/2017 à 16:

Re: [Kicad-developers] [FEATURE] Add keepout areas in footprints

Le 18/10/2017 à 16:57, Oliver Walters a écrit : > JP, > > Fantastic, you have worked your magic! That works much better in pcbnew now, > the undo/redo is > working well. > > However, I still see that undo/redo for zone editing is broken in modedit. > > Oliver > > On Wed, Oct 18, 2017 at 10:08

Re: [Kicad-developers] [FEATURE] Add keepout areas in footprints

Le 19/10/2017 à 17:26, Maciej Sumiński a écrit : > On 10/19/2017 05:20 PM, jp charras wrote: >> Le 19/10/2017 à 16:59, Maciej Sumiński a écrit : >>> On 10/19/2017 04:32 PM, jp charras wrote: >>> [snip] Hi Orson, Could you have a look into this patch? It fixes the issue when a ch

Re: [Kicad-developers] [FEATURE] Add keepout areas in footprints

On 10/19/2017 05:20 PM, jp charras wrote: > Le 19/10/2017 à 16:59, Maciej Sumiński a écrit : >> On 10/19/2017 04:32 PM, jp charras wrote: >> [snip] >>> Hi Orson, >>> >>> Could you have a look into this patch? >>> It fixes the issue when a change is committed with a item belonging a >>> footprint.

Re: [Kicad-developers] [FEATURE] Add keepout areas in footprints

Le 19/10/2017 à 16:59, Maciej Sumiński a écrit : > On 10/19/2017 04:32 PM, jp charras wrote: > [snip] >> Hi Orson, >> >> Could you have a look into this patch? >> It fixes the issue when a change is committed with a item belonging a >> footprint. >> >> But I do not have very good knowledge of COMM

Re: [Kicad-developers] [FEATURE] Add keepout areas in footprints

On 10/19/2017 04:32 PM, jp charras wrote: [snip] > Hi Orson, > > Could you have a look into this patch? > It fixes the issue when a change is committed with a item belonging a > footprint. > > But I do not have very good knowledge of COMMIT classes. Hi Jean-Pierre, Thank you for looking into t

Re: [Kicad-developers] [FEATURE] Add keepout areas in footprints

Le 19/10/2017 à 12:55, Maciej Sumiński a écrit : > On 10/19/2017 11:31 AM, jp charras wrote: >> Le 18/10/2017 à 16:57, Oliver Walters a écrit : >>> JP, >>> >>> Fantastic, you have worked your magic! That works much better in pcbnew >>> now, the undo/redo is >>> working well. >>> >>> However, I sti

Re: [Kicad-developers] [FEATURE] Add keepout areas in footprints

Le 19/10/2017 à 13:00, jp charras a écrit : > Le 19/10/2017 à 12:55, Maciej Sumiński a écrit : >> On 10/19/2017 11:31 AM, jp charras wrote: >>> Le 18/10/2017 à 16:57, Oliver Walters a écrit : JP, Fantastic, you have worked your magic! That works much better in pcbnew now, the u

Re: [Kicad-developers] [FEATURE] Add keepout areas in footprints

Le 19/10/2017 à 12:55, Maciej Sumiński a écrit : > On 10/19/2017 11:31 AM, jp charras wrote: >> Le 18/10/2017 à 16:57, Oliver Walters a écrit : >>> JP, >>> >>> Fantastic, you have worked your magic! That works much better in pcbnew >>> now, the undo/redo is >>> working well. >>> >>> However, I sti

Re: [Kicad-developers] [FEATURE] Add keepout areas in footprints

On 10/19/2017 11:31 AM, jp charras wrote: > Le 18/10/2017 à 16:57, Oliver Walters a écrit : >> JP, >> >> Fantastic, you have worked your magic! That works much better in pcbnew now, >> the undo/redo is >> working well. >> >> However, I still see that undo/redo for zone editing is broken in modedit

Re: [Kicad-developers] [FEATURE] Add keepout areas in footprints

Le 18/10/2017 à 16:57, Oliver Walters a écrit : > JP, > > Fantastic, you have worked your magic! That works much better in pcbnew now, > the undo/redo is > working well. > > However, I still see that undo/redo for zone editing is broken in modedit. > > Oliver > Yes, because when an item belon

Re: [Kicad-developers] [FEATURE] Add keepout areas in footprints

JP, Fantastic, you have worked your magic! That works much better in pcbnew now, the undo/redo is working well. However, I still see that undo/redo for zone editing is broken in modedit. Oliver On Wed, Oct 18, 2017 at 10:08 PM, jp charras wrote: > Le 16/10/2017 à 15:08, Oliver Walters a écrit

Re: [Kicad-developers] [FEATURE] Add keepout areas in footprints

Le 16/10/2017 à 15:08, Oliver Walters a écrit : > By 'segfault' I obviously meant assertion error. The Type() calls are > returning:  > > a) PCB_MODULE_T > b) PCB_ZONE_AREA_T > > Oliver Hi Oliver, Please, apply this patch to your working tree. Currently, there is an issue when storing keepout

Re: [Kicad-developers] [FEATURE] Add keepout areas in footprints

By 'segfault' I obviously meant assertion error. The Type() calls are returning: a) PCB_MODULE_T b) PCB_ZONE_AREA_T Oliver On Tue, Oct 17, 2017 at 12:06 AM, Oliver Walters < oliver.henry.walt...@gmail.com> wrote: > JP, > > Thanks for pointing out those errors. I have fixed the zone rotation bug

Re: [Kicad-developers] [FEATURE] Add keepout areas in footprints

JP, Thanks for pointing out those errors. I have fixed the zone rotation bug (patch attached to this email). The undo/redo behaviour is odd, I have now noticed something related within the module editor window. If I make a change to a zone (add / remove / rotate / move / flip) then I get a segfa

Re: [Kicad-developers] [FEATURE] Add keepout areas in footprints

Le 14/10/2017 à 23:20, Oliver Walters a écrit : > Friendly bump - has anyone had a chance to look at this? :) > > Oliver > > On 12 Oct 2017 00:30, "Oliver Walters" > wrote: > > Attached is a patch set that allows addition of keepout zones to > footpri

Re: [Kicad-developers] [FEATURE] Add keepout areas in footprints

Friendly bump - has anyone had a chance to look at this? :) Oliver On 12 Oct 2017 00:30, "Oliver Walters" wrote: > Attached is a patch set that allows addition of keepout zones to > footprints (modules). > > When embedded inside a module, a keepout can be specified on a combination > of: > > a)

[Kicad-developers] [FEATURE] Add keepout areas in footprints

Attached is a patch set that allows addition of keepout zones to footprints (modules). When embedded inside a module, a keepout can be specified on a combination of: a) F.Cu b) All internal copper layers c) B.Cu The patch set is working pretty well, save / load is working and you can add / edit