Ok, so I dug into this some more and first of all, the changes that Jeff
pushed still didn't work on GTK.
The root cause of this doesn't appear to be our file system watcher, but
was instead the fact that the tree was being improperly updated. First of
all, we were renaming the old node with the n
Jeff,
your new version appears to be working well on my computer on Windows.
Best regards,
Mikołaj Wielgus
On Sat, Nov 16, 2019 at 1:02 AM Jeff Young wrote:
> I pushed a smarter version of my original fix. @Mikolaj & @Ian if you
> could test it on Windows and GTK that would be great.
>
> Che
- Project manager multiple selection options:
It appears that implementing these enchancements would require significant
changes to the project manager code, since much of the actions is
implemented in TREEPROJECT_ITEM class itself, hence a significant portion
of the actions implementation would h
I pushed a smarter version of my original fix. @Mikolaj & @Ian if you could
test it on Windows and GTK that would be great.
Cheers,
Jeff.
> On 15 Nov 2019, at 22:27, Ian McInerney wrote:
>
> Scratch my last. It is GTK with the problems. When I rename the file to a new
> directory with this
Scratch my last. It is GTK with the problems. When I rename the file to a
new directory with this patch, the tree never seems to update. I have to
manually refresh it in order for the file to appear in the correct place.
-Ian
On Fri, Nov 15, 2019 at 10:21 PM Mikołaj Wielgus
wrote:
> Yes, I'm on
Yes, I'm on Windows (the details are in the linked related bug report).
Sorry for the return value problem -- I failed to notice the warnings in
console.
Best regards,
Mikołaj Wielgus
On Fri, Nov 15, 2019 at 11:07 PM Ian McInerney
wrote:
> I'll give it a test on GTK once my build here finishe
I'll give it a test on GTK once my build here finishes, but I don't think I
have seen any issues with file watcher on GTK in the past.
-Ian
On Fri, Nov 15, 2019 at 10:03 PM Jeff Young wrote:
> Hi Mikolaj,
>
> The Mac compiler doesn’t like Rename() returning values when the return
> type is void
Hi Mikolaj,
The Mac compiler doesn’t like Rename() returning values when the return type is
void. However, after fixing that it works fine on Mac.
I remember however something about the file watcher not working on all
platforms. I thought the problem platform was Windows, though, so maybe I’m
Hi,
Renaming file to a different directory causes the entire project tree to be
recreated, which causes all subdirectories to collapse, unexpectedly to the
user.
This patch solves the problem by deleting the original node after moving
the file. Then the file watcher raises an event whose handler
9 matches
Mail list logo
