[Kicad-developers] Unicode Hotkeys

2019-10-04 Thread Ian McInerney
I was doing some digging in the hotkey code to try to see what may be causing this issue: https://bugs.launchpad.net/kicad/+bug/1840528, and I think it may be due to not using the actual unicode character as the hotkey we process. According to wxWidgets, GetKeyCode()

Re: [Kicad-developers] [Patch] Clean up file extension handling in Pcbnew graphics plugins

2019-10-04 Thread Wayne Stambaugh
Ian, I merged your patch into master and 5.1. Thanks, Wayne On 9/26/2019 4:20 PM, Ian McInerney wrote: > After the various fixes for the file extension handling in the recent > weeks, another small bug was introduced for GTK this time, specifically > that the extension displayed to the user in

Re: [Kicad-developers] Adding additional search path for ngspice codemodels on macOS

2019-10-04 Thread Wayne Stambaugh
Understood. I merged the patch as is. We can manually close out the bug report once all of the issues are resolved. Thanks, Wayne On 10/4/2019 10:51 AM, Adam Wolf wrote: > Well, optimistically it fixes it. :) > > There seems to be a caching thing going on that we haven't quite gotten > to the

[Kicad-developers] [Patch] Pcb Calculator: Convert tracks width versus current formula

2019-10-04 Thread Jakub Kozdon
Hi Jean-Pierre, This came from discussion on bug 1818998. I hope that this patch will work correctly. I will also look at eeschema/dialogs/dialog_bom_help.html Jakub >From 5c8995a9721963d01997ac85e9df128bfab0caac Mon Sep 17 00:00:00 2001 From: Jakub Kozdon Date: Fri, 4 Oct 2019 17:05:50 +02

Re: [Kicad-developers] Adding additional search path for ngspice codemodels on macOS

2019-10-04 Thread Adam Wolf
Well, optimistically it fixes it. :) There seems to be a caching thing going on that we haven't quite gotten to the bottom of, so I don't want to say with certainty. On Fri, Oct 4, 2019, 8:55 AM Wayne Stambaugh wrote: > Adam, > > Does this fix bug 1835296? I didn't see the fixes tag in the pa

Re: [Kicad-developers] Adding additional search path for ngspice codemodels on macOS

2019-10-04 Thread Wayne Stambaugh
Adam, Does this fix bug 1835296? I didn't see the fixes tag in the patch. If it does, I can add the tag after I merge it. Thanks, Wayne On 10/3/2019 10:21 PM, Adam Wolf wrote: > Per Holger on [Bug 1835296] Re: simulating laser_driver on macos > nightly causes segfault... > > Please let me kn

Re: [Kicad-developers] [Patch] Make pl_editor runnable from build directory

2019-10-04 Thread Wayne Stambaugh
You could add the build path to the kicad_pyshell module to the the Python environment. It might be wise to make this a CMake configuration option to prevent any name space clashes with the Python path of the installed version of KiCad. That could lead to some rather unexpected results. On 10/3/

Re: [Kicad-developers] [Patch] Make pl_editor runnable from build directory

2019-10-04 Thread Wayne Stambaugh
Done. Thanks Ian. On 10/3/2019 4:41 PM, Ian McInerney wrote: > Thanks for merging it. Yea, it would probably be good to cherry-pick it.  > > -Ian > > On Thu, Oct 3, 2019 at 9:05 PM Wayne Stambaugh > wrote: > > Ian, > > I merged your patch into master.  Sh