No, reverting that commit causes the problems to reappear, even after
175a2bc0b.
In SCH_EDIT_FRAME::ConvertPart(), the logic appears to toggle the parameter
between 1 and 2 (value 0 is not used). It appears that the convert value
for a
component is never supposed to be 0, even though the convert v
Hello Carlo,
Thank you for giving a KiCad talk. It really does help spread the word.
I hope you had a good turn out to see your talk.
Cheers,
Wayne
On 3/27/19 5:43 PM, Carlo Maragno wrote:
> Hi Everyone,
>
> I gave a presentation on Kicad and it's ecosystem. The event was a
> student organiz
Wayne,
Great, thanks for the update. Looking forward to KiCon!
Andrew
---
Andrew Balmos
Deputy Director, ECE Instructional Labs
On Tue, Mar 26, 2019, 3:59 PM Wayne Stambaugh wrote:
> Andrew,
>
> The final schedule still being worked on. As soon as I know anything, I
> will post it on the de
Hi Everyone,
I gave a presentation on Kicad and it's ecosystem. The event was a student
organized technology conference at University of Brescia, with an audience
ranging from kids to full professors.
I was asked to keep the topic accessible for people with different
backgrounds.
Down below you f
Le 20/03/2019 à 19:27, Wayne Stambaugh a écrit :
> Hi JP,
>
> Rather than pollute the bug report[1] with feedback about your zone
> hatch filling patch, I moved the conversation to the mailing list. If
> anyone else would like to test and comment on this patch, the patch can
> be found in the bug
Carsten,
On 3/27/2019 2:33 PM, Carsten Schoenert wrote:
> Am 27.03.19 um 18:09 schrieb Wayne Stambaugh:
>> Carsten,
>>
>> I'm still getting the following git error when applying patch 1:
>>
>> Applying: Adding license information for demo files
>> Using index info to reconstruct a base tree...
>>
Am 27.03.19 um 18:09 schrieb Wayne Stambaugh:
> Carsten,
>
> I'm still getting the following git error when applying patch 1:
>
> Applying: Adding license information for demo files
> Using index info to reconstruct a base tree...
> error: patch failed: LICENSE.README:15
> error: LICENSE.README:
Carsten,
I'm still getting the following git error when applying patch 1:
Applying: Adding license information for demo files
Using index info to reconstruct a base tree...
error: patch failed: LICENSE.README:15
error: LICENSE.README: patch does not apply
error: Did you hand edit your patch?
It d
Hello Wayne,
Am 27.03.19 um 16:34 schrieb Wayne Stambaugh:
> Hey Carsten,
>
> I tried merging your patches and patch 1 does not merge cleanly. Would
> you please rebase patch 1 so I can get it merged?
rebased and re-added.
--
Regards
Carsten Schoenert
From 34bd245a89c2aeecdb5db8814e7741700365
Hi Kliment,
I should have been more clear in my previous comments. There is an
unwritten policy that anything used internally to KiCad must be part of
the file format. The only exception to this is the fields used for
spice which were held over prior to ng-spice being integrated into
KiCad. Thi
Hey Carsten,
I tried merging your patches and patch 1 does not merge cleanly. Would
you please rebase patch 1 so I can get it merged?
Thanks,
Wayne
On 3/8/2019 1:13 PM, Carsten Schoenert wrote:
> Am 08.03.19 um 19:01 schrieb Wayne Stambaugh:
>> This makes sense to me.
>
> Great!
>
> I create
I reviewed the original patch set and I would be willing to merge it but
I would prefer to use the existing file token "hide" rather than add a
new token "disabled". Also, the file format version will have to be
revised because JP's chamfered corners code has already been merged.
On 3/25/2019 4:5
Hi Michael,
Sorry it took so long. I'm going back through my list of outstanding
patches and I ran across this one. Obviously this patch no longer
applies cleanly by if you are still interested in getting this merged,
please rebase it and I will merge it.
Thanks,
Wayne
On 10/16/2018 5:24 PM,
Hi Wayne,
Thanks, I have pushed the change to master and 5.1 (to keep the two
better in sync).
I know these formatting things seem a bit trivial, but I think it
reduces barriers to contributors if we fix ambiguities when we can
(bugs in clang-format notwithstanding).
Cheers,
John
On Wed, M
Jon,
Would you please see if reverting commit ab74445df4 and loading the the
schematic with the 64 bit time stamps has been fixed by commit 175a2bc0b
when you get a chance? If commit 175a2bc0b resolves the issue, then
your commit should be reverted.
Thanks,
Wayne
On 3/27/2019 9:44 AM, Jon Evan
In my investigation of the issue in that forum thread, I found that
eeschema was choking on the convert value being zero.
In that case, I have misunderstood the code and we should probably
revert ab74445df4
That commit fixed the loading/netlisting issues in the forum thread but
perhaps it fixed it
I don't have a preference on this so I'm fine with the proposal. We
have very few templates in the KiCad source so it's impact is low.
On 3/26/2019 8:28 AM, John Beard wrote:
> Oops, missing newline in the "after" case: should be:
>
> template <>
> struct STRUCT_TYPE
>
> On Tue, Mar 26, 2019 at
Oops.
On 3/27/2019 8:30 AM, Wayne Stambaugh wrote:
> Jon,
>
> I don't think setting m_Convert to 1 is the correct solution unless the
> part actually has a convert. According to the Doxygen comment:
/**
* Shape identification for alternate body styles. Set 0 if the item
* is common to all
Jon,
I don't think setting m_Convert to 1 is the correct solution unless the
part actually has a convert. According to the Doxygen comment:
On 3/23/2019 9:08 PM, Jon Evans wrote:
> For context, I've been looking at the issues in this forum
> thread:
> https://forum.kicad.info/t/before-giving-u
Hi Konstantin,
I have applied this patch to both the development and the 5.1 branches.
Thank you for helping KiCad!
Cheers,
John
On Tue, Mar 26, 2019 at 8:15 PM Baranovskiy Konstantin
wrote:
>
> For now fields created in Fields Editor are placed at
> position (0, 0).
> Every new field must be
20 matches
Mail list logo
