[Kicad-developers] Build failed in Jenkins: linux-kicad-full-gcc-head #4546

2019-01-19 Thread Miguel Angel Ajo
See Changes: [hillbrand] pcbnew: Check GetBoard() before using -- [...truncated 155.83 KB...] [ 87%] Building CXX object eeschema/CMakeFiles/eeschema_kiface.dir/sc

Re: [Kicad-developers] [RFC/PATCH] Generic utility tool

2019-01-19 Thread Tomasz Wlostowski
On 19/01/2019 15:30, John Beard wrote: > A very gentle bump here. I'm thinking about a utility to assist in > debugging/benchmarking/testing/developing DRC routines (currently > working on some DRC unit testing, but the testing utils are easily > re-used into a small utility-style executable). Hi

[Kicad-developers] Build failed in Jenkins: linux-kicad-full-gcc-head #4545

2019-01-19 Thread Miguel Angel Ajo
See Changes: [Wayne Stambaugh] Clear comp highlighting before highlight new one. [Wayne Stambaugh] Grid tricks: cell selection fixes. [Wayne Stambaugh] Component fields grid: copy/paste boolean values.

Re: [Kicad-developers] [PATCH 6/7] Eeschema: Field editor closes on Esc+Shift.

2019-01-19 Thread Wayne Stambaugh
Hi Konstantin, I merged your patch set 1-5 from your original post and 6-7 from your revised patches. Please let me know if this is not correct. Thank you for your contribution to KiCad. Cheers, Wayne On 1/17/19 8:31 AM, Константин Барановский wrote: > Alternative version of patch: > if dialo

[Kicad-developers] Build failed in Jenkins: linux-kicad-full-gcc-head #4544

2019-01-19 Thread Miguel Angel Ajo
See Changes: [Wayne Stambaugh] 3D Viewer: disable ray tracing for OpenGL less than 2.1. -- [...truncated 155.95 KB...] [ 88%] Building CXX object qa/common/CMakeFi

Re: [Kicad-developers] [RFC/PATCH] Generic utility tool

2019-01-19 Thread Wayne Stambaugh
Hey John, I don't think there is any disadvantage to rolling the other tests into the qa test executable. Thanks, Wayne On 1/19/19 10:25 AM, John Beard wrote: > Hi Wayne, > > I'll rebase the patch. Would you like me to roll the other > common-library QA utility classes (io_benchmark, etc) up i

Re: [Kicad-developers] [PATCH 1/7] Clear comp highlighting before highlight new one.

2019-01-19 Thread Seth Hillbrand
Am 2019-01-19 08:22, schrieb Wayne Stambaugh: On 1/17/19 1:36 PM, Seth Hillbrand wrote: Thanks.  This works as expected.  Sorry about the mis-attribution of 3/5.  I couldn't hit them as easily in master because the selection routine was difficult.  Since your patches fixed the selection behavio

Re: [Kicad-developers] [RFC/PATCH] Generic utility tool

2019-01-19 Thread Simon Richter
Hi, On 19.01.19 15:30, John Beard wrote: > 1) These kinds of utilities are wanted at all, or are they adding > maintenance overhead for tools no-one ever uses? I'd understand that > perspective, as I appreciate developer time is highly limited and > cross-platform breakage is so easy to perpetrat

Re: [Kicad-developers] [RFC/PATCH] Generic utility tool

2019-01-19 Thread John Beard
Hi Wayne, I'll rebase the patch. Would you like me to roll the other common-library QA utility classes (io_benchmark, etc) up into this executable as a follow-up? Cheers, John On Sat, Jan 19, 2019 at 2:58 PM Wayne Stambaugh wrote: > > John, > > The original patch no longer applies cleanly. I

Re: [Kicad-developers] [RFC/PATCH] Generic utility tool

2019-01-19 Thread Wayne Stambaugh
John, The original patch no longer applies cleanly. It looks useful so I don't see any reason not to merge it. Cheers, Wayne On 1/19/2019 9:30 AM, John Beard wrote: > Hi, > > A very gentle bump here. I'm thinking about a utility to assist in > debugging/benchmarking/testing/developing DRC rou

Re: [Kicad-developers] [RFC/PATCH] Generic utility tool

2019-01-19 Thread John Beard
Hi, A very gentle bump here. I'm thinking about a utility to assist in debugging/benchmarking/testing/developing DRC routines (currently working on some DRC unit testing, but the testing utils are easily re-used into a small utility-style executable). However, I am cognisant of the costs of addin

Re: [Kicad-developers] Pulling mac 5.0.2...

2019-01-19 Thread Adam Wolf
Ah, are you thinking of KICAD_VERSION_EXTRA? I already did that, but I didn't think it was clear that 5.0.2-4-286de261e-5 was newer than 5.0.2-4-29799fda. Perhaps I am overthinking it. On Sat, Jan 19, 2019 at 2:18 AM Nick Østergaard wrote: > Sorry, but I am not on my workstation. But we have t

Re: [Kicad-developers] [PATCH 1/7] Clear comp highlighting before highlight new one.

2019-01-19 Thread Wayne Stambaugh
Seth On 1/17/19 1:36 PM, Seth Hillbrand wrote: > Am 2019-01-17 04:51, schrieb Константин Барановский: >> Hi Seth. Thank you for your attention. >> >> 1) I admit I made a bad choice and now I'm working on new patch with >> which either Esc closes a cell editor if it's active or Esc closes >> dialog

[Kicad-developers] Build failed in Jenkins: linux-kicad-full-gcc-head #4543

2019-01-19 Thread Miguel Angel Ajo
See Changes: [jean-pierre charras] DIALOG_GRAPHIC_ITEM_PROPERTIES: better tooltip. minor other code -- [...truncated 155.48 KB...] Scanning dependencies of target

Re: [Kicad-developers] Pulling mac 5.0.2...

2019-01-19 Thread Nick Østergaard
Sorry, but I am not on my workstation. But we have the thing from git describe in the paranthesis and you append a monotonically increasing serial number, like pkgrel in a PKGBUILD. I think that will work good, ot should help to tell the difference between binaries. lør. 19. jan. 2019 04.45 skrev