Re: [Kicad-developers] Dialog field validation on KillFocus

2018-11-29 Thread Jeff Young
> > You may want to tread carefully allowing users to accept invalid > settings. They may cause crashes or other unexpected behavior bugs. Will do. In most places where it really matters we weren’t trusting the on-exit-validation anyway, and already have code in TransferDataFromWindow. Cheers

Re: [Kicad-developers] Dialog field validation on KillFocus

2018-11-29 Thread Jeff Young
The red boarder, red text (and a hover error message) would be my preferred solution as far as the user is concerned. But this is straying into toolkit land. That would be one thing if we had our own wxWidgets branches on MSW and GTK, or even if we used the latest so I could push some stuff to

Re: [Kicad-developers] Dialog field validation on KillFocus

2018-11-29 Thread Mark Roszko
> This would be more tolerable than a dialog but a red frame may not work well with all WM themes. Make it display an exclaimination mark symbol adjacent to the field as well? I'm not sure how well it works but wxWidgets has wxSystemSettings::GetColour()

Re: [Kicad-developers] Dialog field validation on KillFocus

2018-11-29 Thread Wayne Stambaugh
On 11/29/2018 8:47 AM, Maciej Sumiński wrote: > On 11/29/18 2:36 PM, Jeff Young wrote: >> While most UI guidelines suggest validating on field exit, it’s not without >> cost. In particular, on GTK we can’t tell the difference between a >> KillFocus from clicking the OK button (when validation sh

Re: [Kicad-developers] Dialog field validation on KillFocus

2018-11-29 Thread Maciej Sumiński
On 11/29/18 2:36 PM, Jeff Young wrote: > While most UI guidelines suggest validating on field exit, it’s not without > cost. In particular, on GTK we can’t tell the difference between a KillFocus > from clicking the OK button (when validation should be run) and a KillFocus > from clicking Cance

[Kicad-developers] Dialog field validation on KillFocus

2018-11-29 Thread Jeff Young
While most UI guidelines suggest validating on field exit, it’s not without cost. In particular, on GTK we can’t tell the difference between a KillFocus from clicking the OK button (when validation should be run) and a KillFocus from clicking Cancel (when it should not). Needless to say, Kil

Re: [Kicad-developers] [PATCH] Docset generation

2018-11-29 Thread John Beard
No attachment went though, so here's a better video: https://sendvid.com/lrzgrdmf Cheers, John On Wed, Nov 28, 2018 at 4:36 PM John Beard wrote: > > Hi Wayne, > > It is not a replacement for the existing doxygen docs, which are > unaffected by this patch. > > This patch merely allows you to gene