Re: [Kicad-developers] [PATCH] GTK+3 zooming

2018-11-23 Thread Seth Hillbrand
Am 2018-11-23 15:38, schrieb John Beard: Hi Seth, Sure thing, should it also be a constructor parameter? Or construct to a default then set it? Hi John- Probably an overridable default constructor parameter. We'll need the get/set pair regardless to respond to the preferences change as we d

Re: [Kicad-developers] Adding global mouse shortcuts in GAL tool framework

2018-11-23 Thread John Beard
Hi Orson, Thanks for the idea - seems like that could be a fairly flexible way to generalise action shortcuts. Perhaps such a refactor would be better after the hotkeys aren't synced with legacy, though. Cheers, John On Fri, Nov 23, 2018 at 8:58 AM Maciej Sumiński wrote: > > Hi John, > > One p

Re: [Kicad-developers] [PATCH] GTK+3 zooming

2018-11-23 Thread John Beard
Hi Seth, Sure thing, should it also be a constructor parameter? Or construct to a default then set it? BTW, that WX spew is now fixed upstream in the 3 branch, so a shout out to the WX people for a quick response! Cheers, John On 23 November 2018 19:09:35 GMT, Seth Hillbrand wrote: >Am 201

Re: [Kicad-developers] [PATCH] GTK+3 zooming

2018-11-23 Thread Seth Hillbrand
Am 2018-11-23 08:26, schrieb John Beard: Hi, This is a patch to refactor the zooming of WX_VIEW_CONTROL. This is related to lp:1786515 [1], but it's not a fix, it's just a refactor to help debug the problem, and also tidy the code. Hi John- This looks good. Works for me on Linux and Mac. Af

[Kicad-developers] [PATCH] GTK+3 zooming

2018-11-23 Thread John Beard
Hi, This is a patch to refactor the zooming of WX_VIEW_CONTROL. This is related to lp:1786515 [1], but it's not a fix, it's just a refactor to help debug the problem, and also tidy the code. The refactor is done to avoid big chunks of conditionally compiled code kicking around in functions, and t

Re: [Kicad-developers] Adding global mouse shortcuts in GAL tool framework

2018-11-23 Thread Maciej Sumiński
Hi John, One possible way of solving the problem is to change the m_defaultHotkey in TOOL_ACTION class to a TOOL_EVENT field which says what triggers the action. Then ACTION_MANAGER instead of comparing hotkeys should run TOOL_EVENT::Matches() to check whether a processed TOOL_EVENT is supposed to