[Kicad-developers] [PATCH 1/3] Set _USE_MATH_DEFINES on Windows

In standard compliant mode, msys2 behaves like msvc and does not define M_PI et al. without _USE_MATH_DEFINES --- CMakeLists.txt | 6 ++ 1 file changed, 6 insertions(+) diff --git a/CMakeLists.txt b/CMakeLists.txt index cf55d49e7b..9c835aaeab 100644 --- a/CMakeLists.txt +++ b/CMakeLists.txt

[Kicad-developers] [PATCH 3/3] Use _WIN32, not WIN32

The latter is non-standard and not guaranteed to be available --- 3d-viewer/3d_cache/3d_cache.cpp | 2 +- 3d-viewer/3d_cache/3d_plugin_manager.cpp | 2 +- common/streamwrapper.cpp | 2 +- include/kicad_curl/kicad_curl.h | 2 +- include/streamwrapper.h

[Kicad-developers] [PATCH 0/3] Windows fixes for compiling without GNU extensions

Hi, sorry for breaking the build earlier, there were a few things I missed when I disabled the GNU compiler extensions: - Windows requires -D_USE_MATH_DEFINES for preprocessor symbols from - Windows requires both -DUNICODE and -D_UNICODE. We set just the latter, and some gcc header silen

[Kicad-developers] [PATCH 2/3] Genericize Unicode switch on Windows

Both UNICODE and _UNICODE are required, on all Windows compilers. --- CMakeLists.txt | 10 +++--- 1 file changed, 3 insertions(+), 7 deletions(-) diff --git a/CMakeLists.txt b/CMakeLists.txt index 9c835aaeab..5ce1048736 100644 --- a/CMakeLists.txt +++ b/CMakeLists.txt @@ -182,6 +182,9 @@ per

Re: [Kicad-developers] [PATCH] Set _USE_MATH_DEFINES on Windows

Hi, On 19.10.2018 21:34, Simon Richter wrote: > In standard compliant mode, msys2 behaves like msvc and does not define > M_PI et al. without _USE_MATH_DEFINES There is going to be another version that consolidates the Windows specific stuff a bit better. Simon signature.asc Description:

[Kicad-developers] Schematic capture: showing connecting line when moving name/value text

Hi, A long time ago, I added a little connecting line while moving the label or value in the schematic editor (BZR4686 now as git commit: 3132c70e54a0c5a61110eab7662e288398145c15 ), which is very helpful to not loose track of which label belongs to which symbol. This feature seems to have gotten l

Re: [Kicad-developers] 5.1

Seth, On 10/19/2018 11:53 AM, Seth Hillbrand wrote: > Am 2018-10-19 03:37, schrieb Maciej Sumiński: >> As far as I remember there are two problems related to GTK versions: >> - Having KiCad and wxPython build againt different toolkits results in >> wxWidgets symbol conflicts when wxPython is loade

[Kicad-developers] Eeschema GAL arc rendering

I don't know if anyone is aware but there is an issue with rendering symbols with arcs in the new Eeschema gal code. Apparently, the legacy canvas could be tricked into drawing a minimal line width using a negative width value. This cause the the gal canvas to draw a rather interesting blob (you

[Kicad-developers] Build failed in Jenkins: linux-kicad-full-gcc-head #4183

See Changes: [hillbrand] Turn off compiler extensions [hillbrand] Disallow variable length arrays -- [...truncated 149.13 KB...] [ 86%] Building CXX object eesche

[Kicad-developers] [PATCH] Set _USE_MATH_DEFINES on Windows

In standard compliant mode, msys2 behaves like msvc and does not define M_PI et al. without _USE_MATH_DEFINES --- CMakeLists.txt | 7 +++ 1 file changed, 7 insertions(+) diff --git a/CMakeLists.txt b/CMakeLists.txt index e3bca991fc..2421e024bf 100644 --- a/CMakeLists.txt +++ b/CMakeLists.txt

Re: [Kicad-developers] [PATCH 1/3] Turn off compiler extensions

Am 2018-10-18 14:23, schrieb Simon Richter: We want to be somewhat standards compliant if we can. --- CMakeLists.txt | 1 + 1 file changed, 1 insertion(+) ___ Mailing list: https://launchpad.net/~kicad-developers Post to : kicad-developers@lists.

[Kicad-developers] [PATCH] Add clang-format pre-commit git hook

Hi, This is a patch to add a hook to check formatting for *changed lines only* when committing to Git. It is good that KiCad has a style, but it is a highly unique one and many people will not be used to writing it. Making it easier for people to find mistakes without having to waste the maintain

Re: [Kicad-developers] 5.1

Hi Carsten- Am 2018-10-19 05:53, schrieb Carsten Schoenert: 5.0.1 is almost unusable if build with libwxgtk3.0-gtk3-dev and right now the KiCad package in testing would become RC if the transition to libwxgtk3.0-gtk3-{0v5,dev} would start. Right. This was the (or one of the) motivation(s) beh

Re: [Kicad-developers] 5.1

Am 2018-10-19 03:37, schrieb Maciej Sumiński: As far as I remember there are two problems related to GTK versions: - Having KiCad and wxPython build againt different toolkits results in wxWidgets symbol conflicts when wxPython is loaded. This issue should be resolved by linking KiCad against the

Re: [Kicad-developers] 5.1

Hi, I made an GTK3 build with wx3.0.4 and didn't noticed more bugs than with wx3.1.1 and GTK3 on a quick glance. I'm using X11 as display manager, and run a Arch based system. Regards, Thomas Am 19.10.18 um 11:53 schrieb Carsten Schoenert: > Hello Seth, > > Am 18.10.18 um 21:52 schrieb s...@hi

Re: [Kicad-developers] 5.1

Hello Wayne, Am 19.10.18 um 15:35 schrieb Wayne Stambaugh: ... > packages for it. I'm concerned we are going to spend a huge amount of > effort for little or no net gain. Has wx 3.1.1 been packaged for Debian > yet? As far I see and know not yet. https://qa.debian.org/developer.php?email=team%

Re: [Kicad-developers] 5.1

Carsten, On 10/19/2018 5:53 AM, Carsten Schoenert wrote: > Hello Seth, > > Am 18.10.18 um 21:52 schrieb s...@hillbrand.org: >> * sense flipped here * Debian 9 = python-wxgtk only uses gtk2 and >> Debian 10 = python-wxgtk only uses gtk3 > > yes, and for wxpython3.0 there is currently no backpor

Re: [Kicad-developers] 5.1

Hey Orson, On 10/19/2018 4:16 AM, Maciej Sumiński wrote: > On 10/17/18 8:30 PM, Wayne Stambaugh wrote: >> Now that the Eeschema gal code has been merged into the development >> branch and things seem reasonably stable, we need to start thinking >> about the 5.1 release. I would like to merge Thom

Re: [Kicad-developers] [PATCH] Fuzzable PCB parsing test harness

Hi Wayne, That's pretty odd, the incantations are practically the same. The only other difference between this and the other pcb-based programs is this line: add_dependencies( pnsrouter pcbcommon pcad2kicadpcb ${GITHUB_PLUGIN_LIBRARIES} ) Which I can't really see making the difference (I th

Re: [Kicad-developers] 5.1

Hello Seth, Am 18.10.18 um 21:52 schrieb s...@hillbrand.org: > * sense flipped here * Debian 9 = python-wxgtk only uses gtk2 and > Debian 10 = python-wxgtk only uses gtk3 yes, and for wxpython3.0 there is currently no backport for stretch available and probably will never be due the massive rev

Re: [Kicad-developers] 5.1

Dear Orson&All, On Freitag, 19. Oktober 2018 10:16:24 CEST Maciej Sumiński wrote: > On 10/17/18 8:30 PM, Wayne Stambaugh wrote: > > Now that the Eeschema gal code has been merged into the development > > branch and things seem reasonably stable, we need to start thinking > > about the 5.1 release.

Re: [Kicad-developers] 5.1

On 10/17/18 8:30 PM, Wayne Stambaugh wrote: > Now that the Eeschema gal code has been merged into the development > branch and things seem reasonably stable, we need to start thinking > about the 5.1 release. I would like to merge Thomas' python 3 code and > Orson's cairo print code as soon as the

Re: [Kicad-developers] 5.1

On 10/18/18 9:48 PM, s...@hillbrand.org wrote: > Hi Wayne- > > We should probably start moving the default build on some Linuxes over > to gtk3 as the gtk2/3 conflicts were one of the prime drivers to the > GAL-legacy switch in eeschema.  This requires turning on > -DUSE_WX_GRAPHICS_CONTEXT as wel