Re: [Kicad-developers] [PATCH] GAL: Draw hole even if pad has no layer

Hi, I think with this kind of thing, KiCad should be strict with what it will accept. Otherwise you might find people rely on broken or undefined behaviour and de facto defaults and it all goes wrong when it's fixed or changed on KiCad's end in future. That's how you get "quirks modes". Howev

Re: [Kicad-developers] [PATCH] GAL: Draw hole even if pad has no layer

Hi, if by submitter you mean me, then this is a board I found on Github, I don't know if it was manually edited. But I have done a little investigation, and I think I've found the source of this problem. The problematic footprint is identical to the one that can be downloaded from SnapEDA:

Re: [Kicad-developers] [PATCH] Fix overbar drawing for non-italic text

On 2018-06-22 10:35 AM, Andrzej Wolski wrote: If you try to shorten the right side of the bar, for some characters it will look really bad, and in case of "I" it will turn into dot. This is before patch: Thanks for the detailed before and after images. They more clearly show the issues with t

Re: [Kicad-developers] [PATCH] GAL: Draw hole even if pad has no layer

Hey Seth, I would agree with you if this was our error. If I'm reading JP's analysis correctly, he could not create this board error using KiCad so I'm working on the assumption that this was not our board file output formatter causing the problem. Using defensive measures such as assertions and

Re: [Kicad-developers] [PATCH] GAL: Draw hole even if pad has no layer

​Hi Wayne- I would view this patch more as defensive coding than trying to fix others' errors. The alternatives are to refuse to parse the file or (as we currently do) parse as written and encounter errors in display and routing. JP's approach provides a clear and predictable response to a modif

Re: [Kicad-developers] [PATCH] Fix pad arrays for SDIP and micromatch plugins

John, I merged your patch. Thanks. Wayne On 6/25/2018 7:49 AM, John Beard wrote: > Hi, > > This fixes some broken PadArray __init__ functions in the SDIP and > MicroMatch plugins. > > Cheers, > > John > > > ___ > Mailing list: https://launchpad.n

Re: [Kicad-developers] [PATCH] Add logo to documentation

Hey John, This looks much better. I merged your patch. Thank you for your contribution to KiCad. Cheers, Wayne On 6/25/2018 7:42 AM, John Beard wrote: > Here is a patch for the Ki logo and a screenshot. > > Cheers, > > John > > > > On Tue, Jun 19, 2018 at 1:30 PM, Wayne Stambaugh

Re: [Kicad-developers] [PATCH] GAL: Draw hole even if pad has no layer

On 6/25/2018 8:12 AM, jp charras wrote: > Le 24/06/2018 à 21:52, Wayne Stambaugh a écrit : >> Are we planning on fixing this for rc3?  If so, what is required.  I'm fine >> with waiting a day or >> two to tag rc3. >> > > Attached a possible fix. > > The board test file shows really broken layer

Re: [Kicad-developers] [PATCH] GAL: Draw hole even if pad has no layer

Le 24/06/2018 à 21:52, Wayne Stambaugh a écrit : > Are we planning on fixing this for rc3?  If so, what is required.  I'm fine > with waiting a day or > two to tag rc3. > Attached a possible fix. The board test file shows really broken layer set in a few pads: - no layers for some pads (the lay

[Kicad-developers] [PATCH] Fix pad arrays for SDIP and micromatch plugins

Hi, This fixes some broken PadArray __init__ functions in the SDIP and MicroMatch plugins. Cheers, John From e7ee6a943d5c7be36500bb66e994cecd46978030 Mon Sep 17 00:00:00 2001 From: John Beard Date: Wed, 13 Jun 2018 19:16:01 +0100 Subject: [PATCH] Pcbnew python plugins: fix some pad arrays Fixe

Re: [Kicad-developers] [PATCH] Add logo to documentation

Here is a patch for the Ki logo and a screenshot. Cheers, John On Tue, Jun 19, 2018 at 1:30 PM, Wayne Stambaugh wrote: > I concur. The small KiCad logo would look better. > > https://github.com/KiCad/kicad-source-mirror/blob/ > master/bitmaps_png/sources/kicad_logo_small.svg > > On 6/18/201