Re: [Kicad-developers] [PATCH] Fix for bug/1754049

On 20/03/18 14:07, Seth Hillbrand wrote: 2018-03-19 17:18 GMT-07:00 hauptmech >: On 20/03/18 11:19, Seth Hillbrand wrote: Hi hauptmech- I disagree with your assessment of whether we should allow the creation of broken boards.  I don't think that w

Re: [Kicad-developers] [PATCH] DRC: Add an optional mode to report all track errors

Hi Jon- I don't see anything inherently problematic here. Works as advertised and seems to be minimally invasive. I suspect that your primary speed bump is the BOARD_COMMIT being called on each segment error marker. You might get bang for the buck by conditionally starting a BOARD_COMMIT at the

[Kicad-developers] [PATCH] DRC: Add an optional mode to report all track errors

I'd like some eyes on this before I push it, since it's a rather significant change. I have added a (disabled by default) option to report all DRC issues on each tested track. The current behavior is to stop at the first error, which means that the only way to get a full DRC report is to fix erro

Re: [Kicad-developers] [PATCH] Fix for bug/1754049

2018-03-19 17:18 GMT-07:00 hauptmech : > On 20/03/18 11:19, Seth Hillbrand wrote: > > Hi hauptmech- > > I disagree with your assessment of whether we should allow the creation of > broken boards. I don't think that we should ever allow KiCad to create a > board that it cannot modify itself. Doin

Re: [Kicad-developers] Zone keepouts within modules

Hi Jon, Oh yes I missed some of the code style policy... I have attached an updated patch. Regards, Simon El 19/03/2018 a las 21:07, Jon Evans escribió: Hi Simon, Thanks for the updated patch, I was able to give it a quick try and it so far I haven't found any issues (I edited a footpri

Re: [Kicad-developers] [PATCH] Fix for bug/1754049

On 20/03/18 11:19, Seth Hillbrand wrote: Hi hauptmech- I disagree with your assessment of whether we should allow the creation of broken boards.  I don't think that we should ever allow KiCad to create a board that it cannot modify itself.  Doing this is to invite confusion and bug reports.

Re: [Kicad-developers] [PATCH] Allow OpenCASCADE standard edition

Nick, as always, thanks for the detailed helpful comments. To specify the installation, we will need to set -DOCC_LIBRARY_DIR and -DOCC_INCLUDE_DIR. That works on my machine and the docker file. I'll implement your suggestions and give people another few days to test if they're interested in this

Re: [Kicad-developers] [PATCH] - File format shim for clearance data

Hi Jeff- A few questions on how you are implementing this: 1) How does the user know what was skipped? I can imagine team members with different versions getting into difficulty, especially if the features being skipped change the board layout. 2) You are removing strict checking for most of th

Re: [Kicad-developers] [PATCH] Fix for bug/1754049

Hi hauptmech- I disagree with your assessment of whether we should allow the creation of broken boards. I don't think that we should ever allow KiCad to create a board that it cannot modify itself. Doing this is to invite confusion and bug reports. I don't have an opinion as to which is prefera

Re: [Kicad-developers] FYI: New format for Gerber Job file, replacing the old one.

Meh... sorry for the noise. It's propably too late already... you were talking about the fob file (only). Clemens On 2018-03-19 22:54, Clemens Koller wrote: > On 2018-03-19 15:44, jp charras wrote: >> I committed a change for the Gerber job file created by Pcbnew. > > Commit ID: 2ff74cb > > On

Re: [Kicad-developers] FYI: New format for Gerber Job file, replacing the old one.

On 2018-03-19 15:44, jp charras wrote: > I committed a change for the Gerber job file created by Pcbnew. Commit ID: 2ff74cb On 2018-03-19 15:44, jp charras wrote: > Gerbview can also real the "old format", but because it is deprecated, I'll > remove the code to read > and write this old format (

Re: [Kicad-developers] Zone keepouts within modules

Hi Simon, Thanks for the updated patch, I was able to give it a quick try and it so far I haven't found any issues (I edited a footprint to create a keepout, and then saw that it correctly caused DRC warnings) I noticed a number of coding style policy issues with your patch though; these would ha

Re: [Kicad-developers] MeetUp of KiCad Developers, Librarians and Contributers on MiniDebConf in Hamburg?

Hi, On 19.03.2018 18:00, Carsten Schoenert wrote: > So are there other people which would like to meet other KiCad > Developers, Librarians and Contributers on MiniDebConf in Hamburg? I won't be there, because it conflicts with HillHacks. Simon signature.asc Description: OpenPGP digital s

Re: [Kicad-developers] Zone keepouts within modules

I think I have it updated correctly now. There was a conflict in pcbnew/menubar_footprint_editor.cpp See patch attached. Simon El 19/03/2018 a las 15:28, Jon Evans escribió: Hi Simon, Thanks for sharing your work! This sounds like a neat feature and I'd like to test it and give feedback. U

Re: [Kicad-developers] Zone keepouts within modules

Oh, I didn't know about it. I saw in the links you sent that there were some issues with rotation and undo/redo. This was also my main struggle. Hopefully I had it working, at least the basic stuff. Simon El 19/03/2018 a las 18:16, Rene Pöschl escribió: On 19/03/18 13:02, Simon Santesteban

Re: [Kicad-developers] Zone keepouts within modules

On 19/03/18 13:02, Simon Santesteban wrote: Hi everyone, I am a new developer in kicad community. I have been working on adding zones to modules, so I would like to share this work. Find attached a patch to have this functionality. Regards, Simon _

[Kicad-developers] MeetUp of KiCad Developers, Librarians and Contributers on MiniDebConf in Hamburg?

Hi there, beside the annual big Debian DebConf there are also smaller events with this format called MiniDebConf. The Debian (Mini)DebConfs are open for every interested people. One of such a mini conference is getting held in Hamburg Germany at the end of the spring this year. https://wiki.debia

Re: [Kicad-developers] [PATCH] Fix for bug/1754049

I don't have a strong opinion on the functionality of this patch (I tested it and it works as advertised) but there is one more style issue; blank lines are needed before each if statement https://kicad-source-mirror.readthedocs.io/en/stable/Documentation/development/coding-style-policy/#42-blank-l

[Kicad-developers] FYI: New format for Gerber Job file, replacing the old one.

I committed a change for the Gerber job file created by Pcbnew. According to the last changes for the .gbrjob file format made by Ucamco, this file uses now a JSON syntax, and has much more info for board stackup (thickness, dielectric parameters, colors ...) Therefore Pcbnew generates this fil

Re: [Kicad-developers] Zone keepouts within modules

Hi Simon, Thanks for sharing your work! This sounds like a neat feature and I'd like to test it and give feedback. Unfortunately your patch does not apply against current master, and it looks like it is based on an old enough point that I couldn't fix the merge issues manually. Could you please re

Re: [Kicad-developers] [RFC] Experimental grid pattern in zone fill

JP, I found some time to test your zone hatching patch over the weekend and it looks really good. I do agree with the previous comment that there should be a way to set a radius of the corners created by the hatch intersections. I imagine the sharp corners would be less than ideal in high speed

[Kicad-developers] Zone keepouts within modules

Hi everyone, I am a new developer in kicad community. I have been working on adding zones to modules, so I would like to share this work. Find attached a patch to have this functionality. Regards, Simon From c4781992a8d4cd17e4a4592fea3bdaf3ec25e31f Mon Sep 17 00:00:00 2001 From: Simon Santest

Re: [Kicad-developers] 3D search paths and environment variables

I think it was primarily due to the fact that two different developers worked on this code so there was a duplication of effort. A single dialog would be my preference. On 3/18/2018 11:08 AM, Jeff Young wrote: > There’s no good reason these are edited in separate dialogs, right? It’s > just a h