[Kicad-developers] [PATCH 1/6] Add missing include

--- common/geometry/shape_poly_set.cpp | 1 + 1 file changed, 1 insertion(+) diff --git a/common/geometry/shape_poly_set.cpp b/common/geometry/shape_poly_set.cpp index c11cf047c..7c0d2f38f 100644 --- a/common/geometry/shape_poly_set.cpp +++ b/common/geometry/shape_poly_set.cpp @@ -33,6 +33,7 @@

[Kicad-developers] [PATCH 6/6] Pass -DBOOST_TEST_DYN_LINK to all parts of test

--- eeschema/qa/CMakeLists.txt | 3 +++ eeschema/qa/test_module.cpp | 1 - 2 files changed, 3 insertions(+), 1 deletion(-) diff --git a/eeschema/qa/CMakeLists.txt b/eeschema/qa/CMakeLists.txt index f11329f35..fb99b8613 100644 --- a/eeschema/qa/CMakeLists.txt +++ b/eeschema/qa/CMakeLists.txt @@ -

[Kicad-developers] [PATCH 3/6] Avoid initialization from non-constexpr

In-class initializers for "static const" class members must be constexpr, however std::string is only "static const" itself and cannot be used without compiler extensions. --- include/utf8.h | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/include/utf8.h b/include/utf8.h ind

[Kicad-developers] [PATCH 5/6] Link pcb_test_window with /SUBSYSTEM:WINDOWS

This is required for wx apps. --- qa/pcb_test_window/CMakeLists.txt | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/qa/pcb_test_window/CMakeLists.txt b/qa/pcb_test_window/CMakeLists.txt index c312ce62d..f3a83bc47 100644 --- a/qa/pcb_test_window/CMakeLists.txt +++ b/qa/pcb_test

[Kicad-developers] [PATCH 4/6] Avoid C-style array member init (illegal in C++)

This is not part of the C++ language, and only supported in some compilers. --- common/common_plotDXF_functions.cpp | 26 ++ eeschema/sch_line.cpp | 21 ++--- include/class_plotter.h | 1 - 3 files changed, 28 insertions(+), 20 de

[Kicad-developers] [PATCH 0/6] A few compatibility fixes

Hi, these are a few things that cause build errors on MSVC, where gcc accepts invalid code. Most of them are obvious. The pcb_test_window executable needs to be linked with /SUBSYSTEM:WINDOWS on Windows because it is a GUI app, which uses different startup code than a console application. The Bo

[Kicad-developers] [PATCH 2/6] Avoid nonstandard variable length array

--- common/geometry/shape_poly_set.cpp | 4 ++-- qa/polygon_triangulation/test_polygon_triangulation.cpp | 6 +++--- 2 files changed, 5 insertions(+), 5 deletions(-) diff --git a/common/geometry/shape_poly_set.cpp b/common/geometry/shape_poly_set.cpp index 7c0d2f38f..ff2ad874

[Kicad-developers] Official gestures support in wxWidgets master

Hi all, I just saw that official support for gestures has arrived in wxWidgets master. I don’t yet know if this is in any way compatible with the private patches (pinch-to-zoom for macOS) and touchpad panning that we currently use. I just wanted to let you know that I will start working on adapt

Re: [Kicad-developers] [PATCH] Component table view initial columns sizing

Wayne,No problem… never used it before, but always good to learn something new… :)Attached.Regards,Bernhard 0001-Fix-initial-sizing-of-Fields-table-columns-in-compon.patch Description: Binary data On 5. Dec 2017, at 20:47, Wayne Stambaugh wrote:Bernhard,Please resend the pat

Re: [Kicad-developers] [PATCH] Component table view initial columns sizing

Bernhard, Please resend the patch using `git format-patch`. This makes it a lot easier to apply patches and push to master if they are ready to go. Thanks, Wayne On 12/5/2017 2:16 PM, Bernhard Stegmaier wrote: > Wayne, > > I created it just by directing a “git show” to a file. > I could apply

Re: [Kicad-developers] [PATCH] Component table view initial columns sizing

Wayne, I created it just by directing a “git show” to a file. I could apply it to master using “patch -p1 < xxx.patch”. Of course, I can also try to use “git formal-patch” and resend… Regards, Bernhard > On 5. Dec 2017, at 19:45, Wayne Stambaugh wrote: > > Bernhard, > > I just tried to merge

Re: [Kicad-developers] [PATCH] Component table view initial columns sizing

Bernhard, I just tried to merge this patch using `git am` and I'm getting this error: fatal: empty ident name (for <>) not allowed It looks like you didn't create this patch using `git format-patch` and/or you do not have your user name and/or user email set in your git config. Cheers, Wayne

Re: [Kicad-developers] [PATCH] Fix artifacts on touchpad scroll (fixes lp:1735669)

I tested this patch on my antiquated laptop and it seems fine on Windows 7 pro but I'm not sure the touchpad behavior is correct so it would be nice if someone with a modern windows laptop could test this before I commit it. Cheers, Wayne On 12/4/2017 7:45 PM, Seth Hillbrand wrote: > ​This fixes

Re: [Kicad-developers] [PATCH] Component table view initial columns sizing

Hi Simon, > On 5. Dec 2017, at 14:37, Simon Richter wrote: > > Unrelated to your patch: does it make sense to perhaps share some of the > grouping code between this and the component pin table? First: I didn’t write that piece of code and I only had a very quick look into the table model code.

Re: [Kicad-developers] Simulator towards 5.0

Hi, On 05.12.2017 17:30, Maciej Sumiński wrote: > When you build a program, do you always go through its build manual or > do you start with 'cmake .. && make'? I think there is no point > enforcing an optional dependency. Another good solution would be to > autodetect libngspice and enable the s

Re: [Kicad-developers] Simulator towards 5.0

This patch changes the default build values in cmake, and adds an instruction on how to disable the the spice simulator in the cmake error. -Kristoffer On 12/05/2017 05:30 PM, Maciej Sumiński wrote: When you build a program, do you always go through its build manual or do you start with 'cmak

Re: [Kicad-developers] Simulator towards 5.0

But it would also fail to build if you did not install wx. Den 5. dec. 2017 5.21 PM skrev "Kevin Cozens" : On 2017-12-05 09:05 AM, Kristoffer Ödmark wrote: > Here I attach a small patch that changes the default compile-flags to the > ones in the released packages. > Enabling SPICE support by de

Re: [Kicad-developers] Python: time_t needs mapping; tentative patch

Alright, here is a reworked patch that includes the ideas discussed here - Where we used to use time_t in the functions that deal with timestamps, this is now done with a new typedef timestamp_t that makes sure the c++ side and swigged Python side agree on the type. - this typedef is now in co

Re: [Kicad-developers] Simulator towards 5.0

I always try to build the package that everyone else is running, and no I do not consult the build manual until i have to. That is also why I have only tested the simulator that will now be inside v5. Since we are in feature freeze, and the simulator will be part of kicad. I think that the sta

Re: [Kicad-developers] Simulator towards 5.0

When you build a program, do you always go through its build manual or do you start with 'cmake .. && make'? I think there is no point enforcing an optional dependency. Another good solution would be to autodetect libngspice and enable the simulator if it is available. On 12/05/2017 05:18 PM, Nick

Re: [Kicad-developers] Fwd: Questions on BOARD_COMMIT

Hi Miles, On 12/04/2017 09:23 AM, miles mccoo wrote: >> Is there a document the explains Board commit? An email thread about it > >>> perhaps? >> >> There are some comments in include/commit.h. Perhaps it should be extended. >> >> > Yes, I think so. A small description of how this class is intend

[Kicad-developers] Jenkins build is back to normal : linux-kicad-full-gcc-head #2590

See ___ Mailing list: https://launchpad.net/~kicad-developers Post to : kicad-developers@lists.launchpad.net Unsubscribe : https://launchpad.net/~kicad-devel

Re: [Kicad-developers] Simulator towards 5.0

On 2017-12-05 09:05 AM, Kristoffer Ödmark wrote: Here I attach a small patch that changes the default compile-flags to the ones in the released packages. Enabling SPICE support by default will break my build unless I turn it off. Seeing a recent message about SPICE support I wanted to have a l

Re: [Kicad-developers] Simulator towards 5.0

Isn't it good enough to mention it under the KiCad Build Configuration Options in the devdocs as it is already? 2017-12-05 16:56 GMT+01:00 Maciej Sumiński : > If everyone agrees that Spice simulator should be enabled by default, > then please display a note saying it is optional and might be dis

[Kicad-developers] Jenkins build is back to normal : kicad-qa #3120

See ___ Mailing list: https://launchpad.net/~kicad-developers Post to : kicad-developers@lists.launchpad.net Unsubscribe : https://launchpad.net/~kicad-developers More help

Re: [Kicad-developers] Simulator towards 5.0

If everyone agrees that Spice simulator should be enabled by default, then please display a note saying it is optional and might be disabled for cases when it is not found by CMake. Regards, Orson On 12/05/2017 03:47 PM, Nick Østergaard wrote: > If they are not available for some reason the packa

Re: [Kicad-developers] Build failed in Jenkins: linux-kicad-full-gcc-head #2589

b On 5 December 2017 at 07:25, Miguel Angel Ajo wrote: > See > > > Changes: > > [tomasz.wlostowski] pcbnew: Optimized zone filling algorithm. > > [tomasz.wlostowski] SHAPE_FILE_IO: default constructor outp

[Kicad-developers] Build failed in Jenkins: linux-kicad-full-gcc-head #2589

See Changes: [tomasz.wlostowski] pcbnew: Optimized zone filling algorithm. [tomasz.wlostowski] SHAPE_FILE_IO: default constructor outputs to stdout [tomasz.wlostowski] SHAPE_POLY_SET: fix empty triangula

Re: [Kicad-developers] Zone filling & display speed improvements

On 5 December 2017 at 06:02, Tomasz Wlostowski wrote: > On 05/12/17 08:55, jp charras wrote: >> Le 05/12/2017 à 01:41, Tomasz Wlostowski a écrit : >>> Hi guys, >>> >>> Now it should work fine - the filling algorithm was not thread safe and >>> apparently wxProgressDialog can't be invoked from non-

Re: [Kicad-developers] Signal integrity simulation within Kicad

Hi Andreas, For (1), I will defer to others who know more about this, I seem to remember a conversation about this a while ago on the mailing list, with the conclusion being that it is indeed hard to be notified when BOARD changes, and fixing this could be a bit of work. For (2), the PCB_BASE_FRA

Re: [Kicad-developers] Simulator towards 5.0

I dont see why they should not be able to disable these options in that case, I dont think we should adapt our builds for the majority to suit the needs of the minority. - Kristoffer On 12/05/2017 03:33 PM, Wayne Stambaugh wrote: Can we guarantee that these build dependencies are available on

Re: [Kicad-developers] Simulator towards 5.0

If they are not available for some reason the packager for that platform can disable the feature until he figures out how to support the feature. I don't really see the rationale in having supported features be enabled explicitly. 2017-12-05 15:33 GMT+01:00 Wayne Stambaugh : > Can we guarantee t

Re: [Kicad-developers] Signal integrity simulation within Kicad

Dear Kicad developers, I am browsing the Kicad source code to get an idea how to integrate a simulation tool. I'd like the following: 1. The plugin should be informed whenever something changes. It would be great to get a bounding box of the change. 2. The plugin should be able to draw on the ca

Re: [Kicad-developers] Simulator towards 5.0

Can we guarantee that these build dependencies are available on all platforms? I'm primarily think of BSD devs. For the windows, macos, and linux devs there are no issues. On 12/5/2017 9:28 AM, Nick Østergaard wrote: > I would personally also like to see these options enabled by default. It > ma

Re: [Kicad-developers] Simulator towards 5.0

I would personally also like to see these options enabled by default. It makes it easier for a packager to be convinced what options to enable... :) 2017-12-05 15:05 GMT+01:00 Kristoffer Ödmark : > I checked the default package in Ubuntu ppa through a friend. Indeed all > of this is enabled. > >

Re: [Kicad-developers] Zone filling & display speed improvements

Hi, On 05.12.2017 15:17, Wayne Stambaugh wrote: > One less pop up window is a good thing. I like the status bar idea but > unless you can get it done quickly I would prefer to make this part of > version 6. We should be focusing on bug fixing for the stable 5 release. If the status bar is part

[Kicad-developers] Build failed in Jenkins: kicad-qa #3119

See Changes: [tomasz.wlostowski] pcbnew: Optimized zone filling algorithm. [tomasz.wlostowski] SHAPE_FILE_IO: default constructor outputs to stdout [tomasz.wlostowski] SHAPE_POLY_SET: fix empty triangulation bug [tomasz.

Re: [Kicad-developers] Zone filling & display speed improvements

On 12/5/2017 9:06 AM, Tomasz Wlostowski wrote: > On 05/12/17 13:10, Oliver Walters wrote: >> Could the filling progress be displayed in the lower statusbar instead >> of a popup window? > > Great idea, if: > - someone codes it :-) > - other progress dialogs are migrated to the new progress bar for

Re: [Kicad-developers] Zone filling & display speed improvements

On 12/4/2017 10:48 PM, Henner Zeller wrote: > On 4 December 2017 at 16:41, Tomasz Wlostowski > wrote: >> On 04/12/17 15:43, Henner Zeller wrote: >>> On 4 December 2017 at 06:31, Tomasz Wlostowski >>> wrote: On 04/12/17 02:05, Henner Zeller wrote: > On 2 December 2017 at 10:11, Henner Zel

Re: [Kicad-developers] Zone filling & display speed improvements

On 05/12/17 13:10, Oliver Walters wrote: > Could the filling progress be displayed in the lower statusbar instead > of a popup window? Great idea, if: - someone codes it :-) - other progress dialogs are migrated to the new progress bar for consistency. Tom ___

Re: [Kicad-developers] Zone filling & display speed improvements

On 05/12/17 04:48, Henner Zeller wrote: > Thanks Tom! > > Nice, the [tom-faster-zones-dec01] branch works well and very fast. I > have not seen any crashes anymore. > > There is a leftover method mentioned in pcbnew/class_zone.h: > void RemoveInsulatedCopperIslands() > .. which is not used/impl

Re: [Kicad-developers] Simulator towards 5.0

I checked the default package in Ubuntu ppa through a friend. Indeed all of this is enabled. Here I attach a small patch that changes the default compile-flags to the ones in the released packages. Its a small fix and it doesnt add or remove anything really, just a changes how a default build

Re: [Kicad-developers] Zone filling & display speed improvements

On 05/12/17 08:55, jp charras wrote: > Le 05/12/2017 à 01:41, Tomasz Wlostowski a écrit : >> Hi guys, >> >> Now it should work fine - the filling algorithm was not thread safe and >> apparently wxProgressDialog can't be invoked from non-main thread. >> >> Check out the updated branch. >> >> Thanks!

Re: [Kicad-developers] [PATCH] Component table view initial columns sizing

Hi Bernhard, On 05.12.2017 14:02, Bernhard Stegmaier wrote: > attached patch fixes initial sizing of “Fields” table columns of component > table view. Unrelated to your patch: does it make sense to perhaps share some of the grouping code between this and the component pin table? Simon si

Re: [Kicad-developers] [PATCH] Set modified flag on new sheets

Patch merged. Thanks, Wayne On 12/4/2017 4:48 PM, Seth Hillbrand wrote: > ​The attached patch fixes https://bugs.launchpad.net/kicad/+bug/1736054 > > Newly created sheets should have their modified flags set so that they > are considered "unsaved" until they are successfully written to disk. >

Re: [Kicad-developers] [PATCH] Eeschema wire/bus selection logic

I merged your patch. Thanks, Wayne On 12/4/2017 10:26 AM, Seth Hillbrand wrote: > No worries.  Here's the patch rebased to current master. > > -S > > On Mon, Dec 4, 2017 at 5:01 AM, Wayne Stambaugh > wrote: > > Seth, > > I thought I merged all of your wi

Re: [Kicad-developers] Zone filling & display speed improvements

Tom, Could the filling progress be displayed in the lower statusbar instead of a popup window? On Tue, Dec 5, 2017 at 2:48 PM, Henner Zeller wrote: > On 4 December 2017 at 16:41, Tomasz Wlostowski > wrote: > > On 04/12/17 15:43, Henner Zeller wrote: > >> On 4 December 2017 at 06:31, Tomasz Wlo

Re: [Kicad-developers] Zone filling & display speed improvements

Hi, Glad to hear, that my idea of parallel zone filling is working. Regards Heikki On Tue, Dec 5, 2017 at 9:55 AM, jp charras wrote: > Le 05/12/2017 à 01:41, Tomasz Wlostowski a écrit : > > Hi guys, > > > > Now it should work fine - the filling algorithm was not thread safe and > > apparent