Re: [Kicad-developers] [PATCH] Fix for 3D model offset

2017-11-21 Thread José Ignacio
What if you open the same file again, how can it tell it's in mm or inches? On Tue, Nov 21, 2017 at 7:19 PM, Wayne Stambaugh wrote: > I'm not sure I understand what the issue is. Once an offset is changed > to mm when either a footprint in a board or a library is parsed, why > would it not be s

Re: [Kicad-developers] [PATCH] Fix for 3D model offset

2017-11-21 Thread Wayne Stambaugh
I'm not sure I understand what the issue is. Once an offset is changed to mm when either a footprint in a board or a library is parsed, why would it not be saved as mm. If it isn't, then this is a bug. Once the footprint offset is converted to mm, there should be no expectation that it will be c

Re: [Kicad-developers] Library Editor refactor

2017-11-21 Thread Nick Østergaard
Thank your for fixing. Seems to address the issue. Some minor things about it. It seems that it adds about two lines of whitespace inside that box where the checkboxes are, even if I edit more libs. And I canot not select/deselect with the space key when I highlighted a row. But I guess you didn'

Re: [Kicad-developers] Library Editor refactor

2017-11-21 Thread Maciej Suminski
I have just managed to fix the last issue (disappearing buttons in 'Save Library' dialog) and pushed the code to the master branch. Thank you for testing and comments, I really appreciate it. Now let's have a look at the abandoned patches on the mailing list and the bug tracker.. Regards, Orson

Re: [Kicad-developers] [PATCH] Fix for 3D model offset

2017-11-21 Thread easyw
I think you just need to patch the footprint editor importer to fix this... I think this fork for footprint format will add more 'rumors' in libraries for something that just worked fine ... (only not to be adding a note in the docs that footprint offset were in deci-mils) Anyway Alea iacta es

Re: [Kicad-developers] [PATCH] Fix for 3D model offset

2017-11-21 Thread Oliver Walters
Wayne, Not sure how you want to handle this but I feel that making a clean break and using "offset" for mm solves all the issues associated with embedded footprints without version info, as Maurice says above. Let me know if want me to implement. On Wed, Nov 22, 2017 at 8:24 AM, easyw wrote: >

Re: [Kicad-developers] [PATCH] Fix for 3D model offset

2017-11-21 Thread easyw
Hi, first headache symptom... Testing conditions: latest KiCad patched Application: pcbnew Version: (2017-11-21 revision 8de70f3)-master, release build If you edit a footprint adding 3D models offset and then export it, it will be saved with the new mm convention... but when re-imported it will

Re: [Kicad-developers] New symbol table: problems with '/' characters?

2017-11-21 Thread José Ignacio
This is pretty much the same issue that happened back in February ( https://lists.launchpad.net/kicad-developers/msg27766.html ) I don't have my launchpad logins right now to comment on it but I strongly disagree with classifying bug #1732236 as a low prior

Re: [Kicad-developers] [PATCH] LIB_TABLE tweaks

2017-11-21 Thread Oliver Walters
Fantastic! Thanks very much Wayne On 22 Nov 2017 01:17, "Wayne Stambaugh" wrote: > Yeah!! I finally got this merged. Thank you Oliver for your > contribution to KiCad and for your patience. > > Cheers, > > Wayne > > On 11/21/2017 12:51 AM, Oliver Walters wrote: > > Wayne, > > > > I have recrea

Re: [Kicad-developers] [PATCH] add helper to selecting graphic grid. Add 40 mils grid (approx. 1mm) to draw graphic items in mm

2017-11-21 Thread Eldar Khayrullin
Hello. Anybody can to watch my small patch? В Суббота, 18 ноя. 2017 в 2:47 П. П., Eldar Khayrullin написал: Hello. Can you apply my small patch? Description of the patch in mail theme. ___ Mailing list: https://launchpad.net/~kicad-developers Post to

Re: [Kicad-developers] [PATCH] Add live footprint filtering in modview window

2017-11-21 Thread Wayne Stambaugh
Oliver, I didn't forget. It's still on my todo list. I just haven't had the time to review it. I will do my best to get it reviewed and merged over the Thanksgiving Holiday before the feature freeze. Cheers, Wayne On 11/20/2017 6:57 PM, Oliver Walters wrote: > Wayne, > > Friendly bump in ca

Re: [Kicad-developers] Library Editor refactor

2017-11-21 Thread Maciej Sumiński
On 11/21/2017 05:06 PM, Nick Østergaard wrote: > 2017-11-21 10:22 GMT+01:00 Nick Østergaard : > >> 2017-11-21 <20%2017%2011%2021> 9:43 GMT+01:00 Maciej Sumiński < >> maciej.sumin...@cern.ch>: >> >>> On 11/20/2017 11:16 PM, Nick Østergaard wrote: Hello Maciej, >>> >>> Hi Nick, >>> I have

Re: [Kicad-developers] Library Editor refactor

2017-11-21 Thread Nick Østergaard
2017-11-21 10:22 GMT+01:00 Nick Østergaard : > 2017-11-21 <20%2017%2011%2021> 9:43 GMT+01:00 Maciej Sumiński < > maciej.sumin...@cern.ch>: > >> On 11/20/2017 11:16 PM, Nick Østergaard wrote: >> > Hello Maciej, >> >> Hi Nick, >> >> > I have some comments: >> > >> > First of all, it looks quite neat

Re: [Kicad-developers] Polygons: should have outline mode to draw Edge.Cuts

2017-11-21 Thread Kristoffer Ödmark
Could not a quick fix for this be to attach the "magnetic" functionality that exists when routing to the endpoints of a Edge.Cuts line? On 11/21/2017 04:00 PM, Thomas Pointhuber wrote: Hi, as librarian I would also note that an improved Edge:Cuts behaviour should take in account footprints whi

Re: [Kicad-developers] Polygons: should have outline mode to draw Edge.Cuts

2017-11-21 Thread Thomas Pointhuber
Hi, as librarian I would also note that an improved Edge:Cuts behaviour should take in account footprints which define Edge Connectors or cutouts. At the moment, cutouts are incorrectly rendered in the 3d-viewer when showing a single footprint, because there is no difference to a board outline in

Re: [Kicad-developers] Polygons: should have outline mode to draw Edge.Cuts

2017-11-21 Thread easyw
Hi Henner, I know this is outside the KiCad branch, but if you want to manage complex board edges including arcs, ellipses or bsplines, you may consider useful KiCad StepUp... Recently I've added a feature to allow the user to design the pcb edge in FreeCAD and push it to KiCad_pcb board file.

Re: [Kicad-developers] [PATCH] LIB_TABLE tweaks

2017-11-21 Thread Wayne Stambaugh
Yeah!! I finally got this merged. Thank you Oliver for your contribution to KiCad and for your patience. Cheers, Wayne On 11/21/2017 12:51 AM, Oliver Walters wrote: > Wayne, > > I have recreated the patch set once again, and there is no reference to > "printf" in any of these patch files. >

Re: [Kicad-developers] Library Editor refactor

2017-11-21 Thread Nick Østergaard
2017-11-21 <20%2017%2011%2021> 9:43 GMT+01:00 Maciej Sumiński < maciej.sumin...@cern.ch>: > On 11/20/2017 11:16 PM, Nick Østergaard wrote: > > Hello Maciej, > > Hi Nick, > > > I have some comments: > > > > First of all, it looks quite neat. > > I am glad to hear that. Thank you for the test ride!

Re: [Kicad-developers] Library Editor refactor

2017-11-21 Thread Maciej Sumiński
On 11/20/2017 11:16 PM, Nick Østergaard wrote: > Hello Maciej, Hi Nick, > I have some comments: > > First of all, it looks quite neat. I am glad to hear that. Thank you for the test ride! > Secondly I noticed a small thing. When I open the symbol library editor and > it open in a small window