Re: [Kicad-developers] LIB_PART data storage refactor

2017-08-14 Thread Maciej Suminski
On 08/14/2017 10:33 PM, Maciej Suminski wrote: > I measured the time spent in SCH_SCREEN::Draw() for the slowest to > render sheet I have found ("Northbridge" subsheet of the c4puter > project) and I could observe any performance drop. There was no ^ not > noticeable d

Re: [Kicad-developers] LIB_PART data storage refactor

2017-08-14 Thread Maciej Suminski
I measured the time spent in SCH_SCREEN::Draw() for the slowest to render sheet I have found ("Northbridge" subsheet of the c4puter project) and I could observe any performance drop. There was no noticeable difference for designs of medium complexity either. I believe the iteration overhead (addit

Re: [Kicad-developers] LIB_PART data storage refactor

2017-08-14 Thread Wayne Stambaugh
This improves load performance which makes sense but what about the performance hit when iterating over the list of all LIB_ITEMs say during drawing which happens frequently? Would it make more sense to limit the sorting until it's required instead of every change or file load? I'm not opposed to

[Kicad-developers] LIB_PART data storage refactor

2017-08-14 Thread Maciej Suminski
Hi, In the attachment you will find a patch that refactors data storage in LIB_PART. Instead of keeping all drawings in a boost::ptr_vector, the items are stored in an integer to LIB_ITEMS map. Thanks to that, it is no longer necessary to call LIB_ITEMS::sort() on every modification, so the result

Re: [Kicad-developers] [PATCH] Add remote lib retrieval to SCH_LEGACY_PLUGIN_CACHE

2017-08-14 Thread Wayne Stambaugh
You could modify the SCH_LEGACY_PLUGIN_CACHE code to handle urls instead of file names. That way you could hand remote and local files in the same plugin. wxWidgets has classes to handle urls (wxUrl) and input streams (wxInputStream) which can be use as the LINE_READER (INPUTSTREAM_LINE_READER ta

Re: [Kicad-developers] Python script offered as example for Action Plugin and wxFormBuilder integration

2017-08-14 Thread Wayne Stambaugh
On 8/12/2017 11:59 AM, Greg Smith wrote: > Where should I submit a (likely short) style guide for review? The KiCad developer's mailing list. > > I have recently reviewed PEP8 and updated the code for KiPadCheck and > LayerViewSet to be compliant, so I can write a short document about the KiCa

Re: [Kicad-developers] [RFC] Long pin numbers/pad names support

2017-08-14 Thread jp charras
Le 14/08/2017 à 08:42, Maciej Suminski a écrit : > Hi Jean-Pierre, > > On 08/13/2017 02:01 PM, jp charras wrote: > [snip] >> >> This was made to speed up netlist and connection calculations in the early >> time of Pcbnew. >> (There was no support of wxString and std::string, therefore comparing 2

Re: [Kicad-developers] [PATCH] Add remote lib retrieval to SCH_LEGACY_PLUGIN_CACHE

2017-08-14 Thread
I see, I thought it would be better to upgrade SCH_LEGACY_PLUGIN_CACHE to handle remote libraries seemlessly rather than creating a new plugin. I will check how to add a new plugin for remote libs without adding additional actions for the user. Badr Le 2017-08-14 02:44, Wayne Stambaugh a écri