Currently most (all?) of the HitTest code uses intersection tests defined
for EDA_RECT (which is already a large duplication of code). Should I
refactor all of the ones I have touched to use the common/geometry routines?
On Fri, May 5, 2017 at 2:33 PM, Oliver Walters <
oliver.henry.walt...@gmail.c
Tomasz,
I would be happy to put my new code in a more generic location. I was not
aware of common/geometry and simply fixed the ::HitTest() functions that
were already present for each shape.
I am a little confused by the numerous duplication of the "Rectangle" class
(SHAPE_RECT, EDA_RECT, BOX_2I
On 02.05.2017 09:25, Oliver Walters wrote:
> I have attached a patch-set that implements "partial selection" of
> objects when the selection box is dragged right-to-left.
>
> L -> R = Objects must be completely enclosed to be selected
> R -> L = Objects that intersect the selection rectangle will
Actually I'd prefer there to be only 1 selector tool, every program that
I've used that made the distinction of 2 mouse pointers with slightly
different functionality of selection has made it HELL to use.
The act of switching between the two cursors is a PITA, whereas a silent
selector switch based
the way autocad did it since about when computer mice started coming out
for computers was to use a continuous border for the rectangle when doing a
"window" select (that is, all objects must be completely enclosed to be
part of the selection), when dragging the other way the outline is dashed
for
@Wayne, as you asked I prepared patches for stable 4.0 branch.
Related message and bug:
https://bugs.launchpad.net/kicad/+bug/1423515
>From 6a597c6f1b01b9ae0763e95deb25cedac988b962 Mon Sep 17 00:00:00 2001
From: Eldar Khayrullin
Date: Sun, 16 Apr 2017 20:07:31 +0300
Subject: [PATCH 2/2] Pcbnew:
It will be cool to have this feature. Good work
В Четверг, 4 май. 2017 в 11:41 , Kristoffer Ödmark
написал:
Hello all!
Last night I was doing some design that used a PCB antenna. I had
this antenna design made in zones, It was very frustrating to try to
copy this between an old design and a
On 5/4/2017 10:53 AM, Marco Ciampa wrote:
> On Thu, May 04, 2017 at 02:36:06PM +0200, Kristoffer Ödmark wrote:
>> Personally I would like the box select to update selections online while
>> dragging, this would be very informative. I also think that maybe this
>> functionality would be better with
On Thu, May 04, 2017 at 02:36:06PM +0200, Kristoffer Ödmark wrote:
> Personally I would like the box select to update selections online while
> dragging, this would be very informative. I also think that maybe this
> functionality would be better with a modifier button now that I think about
> it,
On 30.04.2017 14:47, Russell Oliver wrote:
> Hi Tom,
>
> sorry again,
> Attached is a fixed patch.
Hi Russell,
I'd like to merge it. Few more comments:
- check code indentation (you have a mix of tabs and spaces). uncrustify
tool can do that for you.
- the argument naming should follow the aA
The "drag one way to do selection of completely enclosed objects, drag
another way to select any objects that touch the selection area" is
definitely a common pattern in other programs. I have seen it in various
graphics editing and CAD tools.
re. Kristoffer's point, I think it would be cool to h
Personally I would like the box select to update selections online while
dragging, this would be very informative. I also think that maybe this
functionality would be better with a modifier button now that I think
about it, since sometimes I cannot starta a drag move in one corner due
to a large
SketchUp implements this behaviour as well
(https://help.sketchup.com/it/article/385). I'm not sure but it
might be a common pattern in other programs as well. Maybe a helpful
tooltip-text on the selection tool would be enough?
//Konrad
On Thu, May 4, 2017 at 1:39 PM, Kristoffer Ödmark
wrote
Hello!
I like the functionality a lot! Selection is probably the one thing that
is used most of all functions in kicad, so I clearly like that it can be
done in multiple ways! I do however wonder how one would find and
discover this functionality?
- Kristoffer
On 05/02/2017 09:25 AM, Oliver
Hello all!
Last night I was doing some design that used a PCB antenna. I had this
antenna design made in zones, It was very frustrating to try to copy
this between an old design and a new one since I had to use a texteditor
( very glad that I could though ).
After this I figured that this sh
cheers, I will have a look.
Fabrizio
On Thu, May 4, 2017 at 5:12 AM, Константин Барановский <
baranovskiykonstan...@gmail.com> wrote:
> Hi Fabrizio,
> you can find all the icons in my branch:
> https://code.launchpad.net/~baranovskiykonstantin/kicad/+
> git/kicad/+ref/new_icons_rebased
>
> This
16 matches
Mail list logo
