Re: [Kicad-developers] [PATCH] Add footprint select dropdown to component chooser, serious refactoring

2017-03-24 Thread Chris Pavlina
Wayne, I can't reproduce this. Could you do me a favor and file a bug report for it (and assign me, with all these files attached)? It's getting late, I'm signing off for the night and probably not going to work on KiCad over the weekend, and I don't want to lose track of it. -- Chris On Fri, M

[Kicad-developers] UTF8/wxString conversion fixes pushed -- TEST!!

2017-03-24 Thread Chris Pavlina
Hi, I noticed today that we have been handling conversion between UTF8 and wxString wrong _all over_, leading to some interesting encoding issues (UTF8 strings were being converted in the encoding of the current locale, not UTF-8). Following a bit of discussion with Wayne I went through and fixed

[Kicad-developers] SHAPE_POLY_SET tests not building for me on macOS

2017-03-24 Thread Chris Pavlina
Has cc7825d been tested on macOS? It's refusing to build for me on macOS Sierra, clang complains that boost/test/unit_test.hpp doesn't exist. It does, so I guess the include path must be set wrong (missing /usr/local/include). I'm not sure how the build on those works... -- Chris ___

Re: [Kicad-developers] [PATCH] common.h tidyups

2017-03-24 Thread Wayne Stambaugh
Hey John, I'll cherry-pick the swig commit from your branch. The revised patch you sent is now failing to build eeschema/sim/ngspice.cpp. It's missing the definitions for wxTextFile and wxFileName so you will have to add the appropriate headers to ngspice.cpp. Cheers, Wayne On 3/24/2017 11:38

Re: [Kicad-developers] [PATCH] common.h tidyups

2017-03-24 Thread John Beard
Hi Wayne, Like this? As for the patches that don't apply out of order, in this case it is due to removing the following line in the previous commit. If you want to cherry-pick that patch, doing it by git rather than raw patches would be much easier. Git would be able to flag the conflict up and i

[Kicad-developers] Jenkins build is back to normal : kicad-noscript-fedora20 #1768

2017-03-24 Thread Miguel Angel Ajo
See ___ Mailing list: https://launchpad.net/~kicad-developers Post to : kicad-developers@lists.launchpad.net Unsubscribe : https://launchpad.net/~kicad-develop

Re: [Kicad-developers] [PATCH] common.h tidyups

2017-03-24 Thread Wayne Stambaugh
On 3/24/2017 9:50 AM, John Beard wrote: > Hi Wayne, > > The InitKicadAbout function was removed in 2010 by commit > b45a35b719739e1ed1a723a4e7412d63020e5f2c. Is it still useful in the > swig file? It should be removed but unfortunately this patch now no longer applies cleanly. > > As for the di

[Kicad-developers] Jenkins build is back to normal : kicad-qa #2493

2017-03-24 Thread Miguel Angel Ajo
See ___ Mailing list: https://launchpad.net/~kicad-developers Post to : kicad-developers@lists.launchpad.net Unsubscribe : https://launchpad.net/~kicad-developers More help

[Kicad-developers] Build failed in Jenkins: kicad-noscript-fedora20 #1767

2017-03-24 Thread Miguel Angel Ajo
See Changes: [Chris Pavlina] Add footprint select dropdown to component chooser, serious refactoring -- Started by upstream project "linux-kicad-full-gcc-head" build

Re: [Kicad-developers] Build failed in Jenkins: kicad-qa #2492

2017-03-24 Thread Chris Pavlina
Looks like this is related to the version of boost on the build box - it seems that boost didn't add a move constructor to boost::optional until the version *after* that. Unfortunately that means I can't reproduce it here, so I'm going to have to push a fix I /expect/ to work and hope the build bo

Re: [Kicad-developers] [PATCH] common.h tidyups

2017-03-24 Thread John Beard
Hi Wayne, The InitKicadAbout function was removed in 2010 by commit b45a35b719739e1ed1a723a4e7412d63020e5f2c. Is it still useful in the swig file? As for the directory_utils compile failure, perhaps there's a difference in WX on Windows? Does #include at the top of common/directory_utils.cpp fix

Re: [Kicad-developers] Build failed in Jenkins: kicad-qa #2492

2017-03-24 Thread Chris Pavlina
...crap. I'll have this fixed today. On Fri, Mar 24, 2017 at 02:28:57PM +0100, Miguel Angel Ajo wrote: > See > > Changes: > > [Chris Pavlina] Add footprint select dropdown to component chooser, serious > refactoring >

[Kicad-developers] Build failed in Jenkins: kicad-qa #2492

2017-03-24 Thread Miguel Angel Ajo
See Changes: [Chris Pavlina] Add footprint select dropdown to component chooser, serious refactoring -- Started by an SCM change Building remotely on debian8 (gcc clang linux) in wo

Re: [Kicad-developers] [PATCH] Add footprint select dropdown to component chooser, serious refactoring

2017-03-24 Thread Chris Pavlina
On Fri, Mar 24, 2017 at 09:07:22AM -0400, Wayne Stambaugh wrote: > On 3/24/2017 8:52 AM, Chris Pavlina wrote: > > On Fri, Mar 24, 2017 at 08:43:00AM -0400, Wayne Stambaugh wrote: > >> Chris, > >> > >> I did some testing on this and it looks good. I have a few comments and > >> questions. > >> > >>

Re: [Kicad-developers] [PATCH] Add footprint select dropdown to component chooser, serious refactoring

2017-03-24 Thread Wayne Stambaugh
On 3/24/2017 8:52 AM, Chris Pavlina wrote: > On Fri, Mar 24, 2017 at 08:43:00AM -0400, Wayne Stambaugh wrote: >> Chris, >> >> I did some testing on this and it looks good. I have a few comments and >> questions. >> >> There is a noticeable response time lag when the footprints are being >> loaded

Re: [Kicad-developers] [PATCH] Refactor LAYER_ID to be the one and only layer definition

2017-03-24 Thread Jon Evans
Hi Wayne, Any feedback on this? Thanks, Jon On Wed, Mar 22, 2017 at 6:15 AM, Maciej Sumiński wrote: > I have briefly tested the patch, no issues found. I have no objections > to the changes, but I will leave the final decision to Wayne. > > Regards, > Orson > > On 03/22/2017 03:51 AM, Jon Evan

Re: [Kicad-developers] [PATCH] Add footprint select dropdown to component chooser, serious refactoring

2017-03-24 Thread Chris Pavlina
On Fri, Mar 24, 2017 at 08:43:00AM -0400, Wayne Stambaugh wrote: > Chris, > > I did some testing on this and it looks good. I have a few comments and > questions. > > There is a noticeable response time lag when the footprints are being > loaded on windows. This may be specific to windows. I w

Re: [Kicad-developers] [PATCH] Add footprint select dropdown to component chooser, serious refactoring

2017-03-24 Thread Wayne Stambaugh
Chris, I did some testing on this and it looks good. I have a few comments and questions. There is a noticeable response time lag when the footprints are being loaded on windows. This may be specific to windows. I will test it on linux when I get a chance. Are you planning on filtering the fo

Re: [Kicad-developers] [PATCH] CPolyLine -> SHAPE_POLY_SET refactor

2017-03-24 Thread Maciej Sumiński
TL;DR: Everything seems fine, I am going to merge the branch today. For the record: I got the board that was showing the differences. I refilled zones using the master branch, then once again with the polygon refactor patch applied. Diff of zone polygons shows no difference. There were difference

Re: [Kicad-developers] OpenGL fallback and video compat test

2017-03-24 Thread Lorenzo Marcantonio
On Fri, Mar 24, 2017 at 10:12:44PM +1300, Simon Wells wrote: > Cairo is much faster since the awesome devs at CERN (iirc) had another > go at it. But thats currently only in nightlies and i believe has been > decided to use that instead of trying to make a DC GAL. Have you tried > recentish nightly

Re: [Kicad-developers] OpenGL fallback and video compat test

2017-03-24 Thread Simon Wells
Cairo is much faster since the awesome devs at CERN (iirc) had another go at it. But thats currently only in nightlies and i believe has been decided to use that instead of trying to make a DC GAL. Have you tried recentish nightly cairo? On 24 March 2017 at 21:51, Lorenzo Marcantonio wrote: > On

Re: [Kicad-developers] OpenGL fallback and video compat test

2017-03-24 Thread Lorenzo Marcantonio
On Thu, Mar 23, 2017 at 08:11:31PM -0400, Chris Pavlina wrote: > Hi, > > I've been thinking about my intent to make KiCad fall back cleanly to > Cairo when OpenGL isn't available. From what I can see, there are Wouldn't be better to try to make a DC version of the GAL instead of cairo since it is

Re: [Kicad-developers] OpenGL fallback and video compat test

2017-03-24 Thread Maciej Sumiński
On 03/24/2017 01:11 AM, Chris Pavlina wrote: > Hi, > > I've been thinking about my intent to make KiCad fall back cleanly to > Cairo when OpenGL isn't available. From what I can see, there are > certain situations where trying to use OpenGL causes crashes that appear > very hard to prevent. > > I