Re: [Kicad-developers] [BUG] Bug introduced in fix for lp:1660875

2017-02-05 Thread Oliver Walters
After further investigation, pressing the HK_MIRROR_Y and HK_MIRROR_X keys (whilst moving an item) also cause it to be removed. I have attached a patch that addresses this, and provides a fix for the issues outlined in the previous message. On Sun, Feb 5, 2017 at 11:11 PM, Oliver Walters < oliv

Re: [Kicad-developers] I'm working on a nice thing

2017-02-05 Thread jp charras
Le 06/02/2017 à 03:52, Chris Pavlina a écrit : > Still very early... I call it "componentchoosernew" > > https://misc.c4757p.com/componentchoosernew.png > Looks really promising! -- Jean-Pierre CHARRAS ___ Mailing list: https://launchpad.net/~kicad-

Re: [Kicad-developers] [PATCH] Delete whole tracks in GAL

2017-02-05 Thread Marcos Chaparro
Thanks, I've been waiting fot this patch to happen, I can't get used to the clunky 'u' shortcut to delete a track. Marcos On Sun, Feb 5, 2017 at 1:37 PM, John Beard wrote: > Apparently those patches don't apply because the diff context lines > have a line of a different non-mainline patch in t

[Kicad-developers] I'm working on a nice thing

2017-02-05 Thread Chris Pavlina
Still very early... I call it "componentchoosernew" https://misc.c4757p.com/componentchoosernew.png -- Chris ___ Mailing list: https://launchpad.net/~kicad-developers Post to : kicad-developers@lists.launchpad.net Unsubscribe : https://launchpad.n

Re: [Kicad-developers] [PATCH] ActionPlugin undo and redo feature

2017-02-05 Thread Jean-Samuel Reynaud
Hi All, Any update on this ? Regards, Le 02/02/2017 à 10:50, Jean-Samuel Reynaud a écrit : > Dear All, > > Find attached a patch to add undo/redo feature for external python > plugin called from the "External Plugins" menu. > > Attached: > - The patch himself > - A plugin to test is (named te

[Kicad-developers] Footprint browser

2017-02-05 Thread Kristoffer Ödmark
Hello! I found an interesting and well written offtopic comment[1] in the user forum regarding the different pickers, and I went to investigate in the code. I was looking for the dialog for the footprint browser, but I did not find it. What I found however was that it was not implemented in

[Kicad-developers] [PATCH] Display more information in component selector

2017-02-05 Thread Chris Pavlina
Hi, This patch adds more information to the component selector. In particular, it adds two things: 1. Display component description even for aliases. 2. Display all fields. Screenshot: https://misc.c4757p.com/choose-component.png It should be ready for commit, just pending review. Upcoming cha

Re: [Kicad-developers] [PATCH] Delete whole tracks in GAL

2017-02-05 Thread John Beard
Apparently those patches don't apply because the diff context lines have a line of a different non-mainline patch in them (from the rotate CCW patch). Hopefully, these will apply to the current master. On Sun, Feb 5, 2017 at 9:23 PM, John Beard wrote: > Hi, > > These patches implement deletion o

Re: [Kicad-developers] [PATCH] libedit: part deletion

2017-02-05 Thread Chris Pavlina
Awesome! Glad it was something simple. Everything else looks good - I just pushed it to master. I also pushed a commit to remove unit display from this dialog entirely, since there's no support for deleting individual units. Apologies for invalidating the work you did to sniff out this bug - as it

[Kicad-developers] [PATCH] Delete whole tracks in GAL

2017-02-05 Thread John Beard
Hi, These patches implement deletion of whole tracks (actually whole connections, it won't span an unrouted gap). Fixes: https://bugs.launchpad.net/kicad/+bug/1517213 This in in two parts: * Expand the current connection/track/net selection to act on multiple selections, not just the first item

[Kicad-developers] [PATCH] Fix arc selection over-enthusiastic bounding boxes

2017-02-05 Thread John Beard
Hi, Here is a patch to fix https://bugs.launchpad.net/kicad/+bug/1492734, where a small-angle arc has an unexpectedly large bounding box, causing odd selection behaviour. The code was actually already there with a TODO on it - this patch basically just uses that and replaces the TODO with a comme

[Kicad-developers] [PATCH] CCW Rotation in GAL

2017-02-05 Thread John Beard
Hi, Here is a patch for adding CCW rotation to the GAL canvas. Possibly controversial is the new namespace in tool_action_utils.h for dumping generic free function helpers that act on TOOL_ACTIONS and on other classes in concert. I feel that this is a way to isolate the these routines, giving acc

[Kicad-developers] [BUG] Bug introduced in fix for lp:1660875

2017-02-05 Thread Oliver Walters
The fix for lp:1660875 has introduced a bug into nightly and stable Nightly: 9319ef034dbf0421ebbd2c78f7ee41f01bb56c0c Stable: d1f8dbb9debe128ddd015edb1ff0fa954a8a08a7 Bug: When moving a pin around in libedit, pressing HK_EDIT or HK_ROTATE will delete the currently selected pin (designated m_drawI

Re: [Kicad-developers] Pad import/export/push and modedit mirror

2017-02-05 Thread John Beard
On Sat, Feb 4, 2017 at 8:10 PM, Nick Østergaard wrote: > I have attached a patch that renames this. It contains three commits > for easier review. Sounds good to me. At the (considerable) risk of bikeshedding, I might also suggest something like "stash" or "store" instead of "copy", since the us