[Kicad-developers] PATCH: fix coding style of 'sexpr' code in kicad2step

2017-02-01 Thread Cirilo Bernardo
The attached patch: (a) changes to sexpr code format to comply with KiCad style rules (b) changes 'enum' to 'enum class' in sexpr code for more rigorous compiler checking - Cirilo From ebb6ad6aae0ec0628d988f3e7dc2f8606521b033 Mon Sep 17 00:00:00 2001 From: Cirilo Bernardo Date: Thu, 2 Feb 2017 1

Re: [Kicad-developers] [PATCH 2/2] Copy and adapt FindCairo.cmake for Pixman

2017-02-01 Thread Wayne Stambaugh
Your patches have been committed. Thanks! On 1/17/2017 8:01 PM, Simon Richter wrote: > --- > CMakeModules/FindPixman.cmake | 162 > +++--- > 1 file changed, 135 insertions(+), 27 deletions(-) > > > > ___ > Mailin

Re: [Kicad-developers] [PATCH 2/2] Copy and adapt FindCairo.cmake for Pixman

2017-02-01 Thread Wayne Stambaugh
Thanks Bernhard. I'll commit the patch as soon as I get a chance. On 2/1/2017 11:44 AM, Bernhard Stegmaier wrote: > Seem to work fine for my setup (dependencies using MacPorts). > > > Regards, > Bernhard > >> On 26.01.2017, at 15:02, Wayne Stambaugh wrote: >> >> Would one of our osx devs plea

Re: [Kicad-developers] [PATCH 2/2] Copy and adapt FindCairo.cmake for Pixman

2017-02-01 Thread Bernhard Stegmaier
Seem to work fine for my setup (dependencies using MacPorts). Regards, Bernhard > On 26.01.2017, at 15:02, Wayne Stambaugh wrote: > > Would one of our osx devs please test these two patches to make sure > they don't break anything. I tested this on msys2 on windows and linux > but I want to b

Re: [Kicad-developers] [PATCH] CPolyLine -> SHAPE_POLY_SET refactor

2017-02-01 Thread Maciej Sumiński
On 02/01/2017 02:36 PM, jp charras wrote: [snip] > * In GAL canvas, depending on the zoom level and the size of the filled zones > areas, filled zones > areas are displayed or not. > Same for zone outlines. Without looking at the code, my first shot is incorrect bounding box calculation (ViewBBox

Re: [Kicad-developers] [PATCH] pcb_calculator: delete obsolete sources of binary bitmaps (.pngs)

2017-02-01 Thread Clemens Koller
I didn't get any feedback from my last mail yet. Here is a patch to remove IMO unnecessary .png files, supplementing my last patch. Regards, Clemens On 2017-01-31 21:00, Clemens Koller wrote: > Hello! > > Attached is a new patch to cleanup the color code bitmaps in pcb_calculator. > The k is i

[Kicad-developers] Footprint Association and Filtering

2017-02-01 Thread Oliver Walters
Hi all, Currently a lot of the .pretty libs have the library name (e.g. "Socket_Strips.pretty") duplicated (or partly duplicated) in the footprint name. This is (mainly) required to allow the footprint filtering in CvPCB to match the filters defined for components. One case where this is very an

Re: [Kicad-developers] [PATCH] Changed the 3d model previewer to use spinboxes

2017-02-01 Thread Kristoffer Ödmark
I was also using cairo if that makes a difference - Kristoffer On 02/01/2017 02:32 PM, Wayne Stambaugh wrote: I was using windows 7 when I tested this. I will check my windows 10 box at home when I get a chance. On 2/1/2017 8:02 AM, Kristoffer Ödmark wrote: Can someone else confirm this? In

Re: [Kicad-developers] [PATCH] CPolyLine -> SHAPE_POLY_SET refactor

2017-02-01 Thread jp charras
Le 30/01/2017 à 22:30, Alejandro Garcia Montoro a écrit : > > I've pushed a polygon-refactor branch on my own repo, see [1]. > > > Developers, please review and test this patch as thoroughly as possible > and give feedback to Alejandro. Once we are comfortable that it is good > to

Re: [Kicad-developers] [PATCH] Changed the 3d model previewer to use spinboxes

2017-02-01 Thread Wayne Stambaugh
I was using windows 7 when I tested this. I will check my windows 10 box at home when I get a chance. On 2/1/2017 8:02 AM, Kristoffer Ödmark wrote: > Can someone else confirm this? In my win 10 VM this was working if you > clicked the viewmodel window it would get focus back. > > -Kristoffer >

Re: [Kicad-developers] [PATCH] Changed the 3d model previewer to use spinboxes

2017-02-01 Thread Kristoffer Ödmark
Can someone else confirm this? In my win 10 VM this was working if you clicked the viewmodel window it would get focus back. -Kristoffer On 01/31/2017 10:41 PM, José Ignacio wrote: Windows has always been sucky dealing with scrollwheel focus, on most program you have to click before you can sc

Re: [Kicad-developers] [PATCH] Add exchange footprints to GAL

2017-02-01 Thread Maciej Sumiński
Hi John, I have just pushed your patches. Once again - thank you very much! Taking into account your recent contributions, I dare to say you now deserve the GAL contributor medal. Regards, Orson On 01/31/2017 04:32 PM, John Beard wrote: > Hi, > > The attached patches add the "exchange footprint