Re: [Kicad-developers] [PATCH] Changed the 3d model previewer to use spinboxes

2017-01-30 Thread Kristoffer Ödmark
I will look into it, the difference in behavior between the oses is very strange. -Kristoffer On Jan 31, 2017 2:30 AM, "Wayne Stambaugh" wrote: > Manual entry now works on windows but you changed the behavior. > Currently, as you enter a number in the edit control, the changes update > instantl

Re: [Kicad-developers] [PATCH] Changed the 3d model previewer to use spinboxes

2017-01-30 Thread Wayne Stambaugh
Manual entry now works on windows but you changed the behavior. Currently, as you enter a number in the edit control, the changes update instantly. With your patch, you have to tab to the next control before the change is made. IMO, this is a step backwards from the current behavior at least on w

Re: [Kicad-developers] [PATCH] libedit: preselect active component when switching

2017-01-30 Thread Wayne Stambaugh
This seems fine to me. On 1/30/2017 4:57 PM, Chris Pavlina wrote: > Hi, > > This patch makes libedit preselect the current part when choosing the > next part to edit. That makes it easier to go through a library one part > at a time and not lose your place. I figure this is pretty > noncontrovers

[Kicad-developers] [PATCH] libedit: add hotkey for Load Component

2017-01-30 Thread Chris Pavlina
Hi, This patch adds a hotkey (default: Ctrl+L) to libedit for Load Component. Just another simple workflow-quickener when doing a lot of library edits. I'll push this one in a day too. -- Chris >From c45f9c2b740ca5e7a7ac264d50a7d59d57794f3b Mon Sep 17 00:00:00 2001 From: Chris Pavlina Date: Mon

[Kicad-developers] [PATCH] libedit: preselect active component when switching

2017-01-30 Thread Chris Pavlina
Hi, This patch makes libedit preselect the current part when choosing the next part to edit. That makes it easier to go through a library one part at a time and not lose your place. I figure this is pretty noncontroversial, so I'll push it in a day or so if nobody sees anything wrong with it. --

Re: [Kicad-developers] [PATCH] CPolyLine -> SHAPE_POLY_SET refactor

2017-01-30 Thread Alejandro Garcia Montoro
2017-01-30 15:25 GMT+01:00 Wayne Stambaugh : > Thank you Alejandro. The refactoring looks good and the unit tests are > a nice touch. Since this patch is rather large, it might be worthwhile > pushing this to a new branch in you own development repo on launchpad so > other devs can clone it or m

Re: [Kicad-developers] [PATCH] Changed the 3d model previewer to use spinboxes

2017-01-30 Thread Kristoffer Ödmark
Hello! The patch now works under windows, mac and linux. -Kristoffer On 2017-01-27 16:40, Wayne Stambaugh wrote: This doesn't work on windows at all. Changing any of the values either with the spin buttons or direct entry into the edit control does not update 3D view of the model. This issue

Re: [Kicad-developers] [PATCH] Changed the 3d model previewer to use spinboxes

2017-01-30 Thread Kristoffer Ödmark
Thank you for the help everyone! The missing component was the "base-devel" package, worth noting is that I set up this machine with the sole purpose of building and testing kicad under windows, It might be worth to add that the base-devel package is needed as well in the documentation. To mak

Re: [Kicad-developers] [PATCH] CPolyLine -> SHAPE_POLY_SET refactor

2017-01-30 Thread Wayne Stambaugh
Thank you Alejandro. The refactoring looks good and the unit tests are a nice touch. Since this patch is rather large, it might be worthwhile pushing this to a new branch in you own development repo on launchpad so other devs can clone it or merge it into there own development repos. Developers,

Re: [Kicad-developers] [PATCH] Changed the 3d model previewer to use spinboxes

2017-01-30 Thread Константин Барановский
Hi, Kristoffer! You need to install the make utility. Just launch mingw and run command: pacman -S make > 2017-01-30 10:51 GMT+02:00 Kristoffer Ödmark : > I am using this PKGbuild: > > https://github.com/Alexpux/MINGW-packages/blob/master/mingw- > w64-kicad-git/PKGBUILD > > I was trying to get

Re: [Kicad-developers] [PATCH] Changed the 3d model previewer to use spinboxes

2017-01-30 Thread Kristoffer Ödmark
I am using this PKGbuild: https://github.com/Alexpux/MINGW-packages/blob/master/mingw-w64-kicad-git/PKGBUILD I was trying to get the compilation to work under MSYS2 the easy way according to the guide. To see that everything was set up correctly, which apparently it isnt. - Kristoffer On 201

Re: [Kicad-developers] [PATCH] Changed the 3d model previewer to use spinboxes

2017-01-30 Thread Nick Østergaard
Please show me your cmake options. Remember to make sure you have the relevant mingw toolchain installed. 2017-01-30 9:23 GMT+01:00 Kristoffer Ödmark : > I can't get Kicad to compile under windows, the guide in the online docs > doesnt work for me under windows 7 64bit. If anyone have any ideas of

Re: [Kicad-developers] [PATCH] Changed the 3d model previewer to use spinboxes

2017-01-30 Thread Kristoffer Ödmark
I can't get Kicad to compile under windows, the guide in the online docs doesnt work for me under windows 7 64bit. If anyone have any ideas of what to test I would really appreciate it. I am following the guide at: http://ci.kicad-pcb.org/job/kicad-doxygen/ws/Documentation/doxygen/html/md_Docum