Re: [Kicad-developers] Plethora of warnings from -Woverloaded-virtual

2014-02-18 Thread Lorenzo Marcantonio
On Tue, Feb 18, 2014 at 07:44:31PM -0600, Dick Hollenbeck wrote: > I am certain that I spent hours removing them. You *actively* hunted down excess virtuals? Did they give such a performance issue? -- Lorenzo Marcantonio Logos Srl ___ Mailing list:

Re: [Kicad-developers] Plethora of warnings from -Woverloaded-virtual

2014-02-18 Thread Lorenzo Marcantonio
On Tue, Feb 18, 2014 at 07:36:59PM -0600, Dick Hollenbeck wrote: > There is currently not enough protection against somebody changing the base, > then you end > up with TWO virtuals. This is why the derived ones are not using it. I'm not getting the meaning of this... what do you mean with 'prot

Re: [Kicad-developers] PATCH: Component chooser now with thumbnail image of the component. And Unit select.

2014-02-18 Thread jp charras
Le 19/02/2014 07:14, Henner Zeller a écrit : >> I have a few comments and one minor bug. On windows builds with >> wxWidget 3.0.0, the component view panel does not update when a new >> component is selected. When the dialog is closed and reopen it, then >> the selected component is shown correct

Re: [Kicad-developers] Test cases

2014-02-18 Thread Henner Zeller
On 18 February 2014 22:43, Miguel Angel wrote: > >Sure Henner, I understand your point, but: > > > 1) All python-exposed structures (meant to be public) need to be tested from > python. > That warrants that the python interface is reliable, and not breaking. > And it's a good start. Sound

Re: [Kicad-developers] Test cases

2014-02-18 Thread Miguel Angel
Sure Henner, I understand your point, but: 1) All python-exposed structures (meant to be public) need to be tested from python. That warrants that the python interface is reliable, and not breaking. And it's a good start. 2) Probably, keeping replicas of tests which are written in python

Re: [Kicad-developers] Getting libraries when building from source.

2014-02-18 Thread Nick Østergaard
Have you read the 5 - Footprint Libraries Management chapter in http://bazaar.launchpad.net/~kicad-developers/kicad/doc/view/head:/doc/help/en/cvpcb.pdf? 2014-02-19 1:45 GMT+01:00 Sean Silva : > > > > On Mon, Feb 17, 2014 at 4:09 PM, Nick Østergaard wrote: > >> I might have read your original ma

Re: [Kicad-developers] Test cases

2014-02-18 Thread Henner Zeller
Mmh, I guess I am too late in the game, but shouldn't the unittest itself be written in C++ ? It feels too much of a pain to use Python here (and with pain I mean, I personally rather poke a finger in my eye than writing something in Python :) ). I just fear that the unit-tests themself will become

Re: [Kicad-developers] PATCH: Component chooser now with thumbnail image of the component. And Unit select.

2014-02-18 Thread Henner Zeller
> I have a few comments and one minor bug. On windows builds with > wxWidget 3.0.0, the component view panel does not update when a new > component is selected. When the dialog is closed and reopen it, then > the selected component is shown correctly. This should hopefully be now fixed with the

[Kicad-developers] Test cases

2014-02-18 Thread Miguel Angel
Hi Kaspar, Asking google about you (to find your hardware) I discovered that you were playing with kicad/unittests this summer. http://bazaar.launchpad.net/~kaspar-emanuel/kicad/python-unittest/revision/4243 Wouls you like it incorporated to qa/testcases? http://bazaar.launchpad.net/~kicad-pro

Re: [Kicad-developers] FOSDEM biggest open-source Europen conference just finished

2014-02-18 Thread Miguel Angel
Wow, I didn't know about ehsm, but looks really interesting, what's your hardware exactly? :) --- irc: ajo / mangelajo Miguel Angel Ajo Pelayo +34 636 52 25 69 skype: ajoajoajo 2014-02-19 1:54 GMT+01:00 Kaspar Emanuel : > On 3 February 2014 19:18, Adam Wolf wrote: > > The Open Source Hardware

[Kicad-developers] PATCH: improve component redraw in chooser

2014-02-18 Thread Henner Zeller
Hi, Simple followup change with mostly the suggestion of jp regarding improving the redraw in the component box. This hopefully makes it work on Windows as well properly. Commit message: * Improve component chooser redraw to fit int wxWidget redraw strategies. * Use LIB_COMPONENT::Draw and LIB_C

Re: [Kicad-developers] Plethora of warnings from -Woverloaded-virtual

2014-02-18 Thread Dick Hollenbeck
I am certain that I spent hours removing them. ___ Mailing list: https://launchpad.net/~kicad-developers Post to : kicad-developers@lists.launchpad.net Unsubscribe : https://launchpad.net/~kicad-developers More help : https://help.launchpad.net/L

[Kicad-developers] Plethora of warnings from -Woverloaded-virtual

2014-02-18 Thread Dick Hollenbeck
> Hi all, I'm just wanting to make sure that some warnings that I'm seeing > are not intentional before I submit a patch to fix them. The use of virtual, as is, is intentional. > Clang's -Woverloaded-virtual warning [*] fires many times when building, > primarily of the form: Yes, just turn

Re: [Kicad-developers] FOSDEM biggest open-source Europen conference just finished

2014-02-18 Thread Kaspar Emanuel
On 3 February 2014 19:18, Adam Wolf wrote: > The Open Source Hardware conference is rumored to be in Europe this year. > The details haven't been released yet. Just thought I would note that this summer will be the second EHSM and I am sure talks from developers of open source EDA tools will be

Re: [Kicad-developers] Getting libraries when building from source.

2014-02-18 Thread Sean Silva
On Mon, Feb 17, 2014 at 4:09 PM, Nick Østergaard wrote: > I might have read your original mail a bit wrong, the dickelbeck lib is > the legacy one. > > But it should be enough with only the github plugin AFIK, you can verify > it by looking at the Help menu and then the version information. > Wh

Re: [Kicad-developers] Plethora of warnings from -Woverloaded-virtual

2014-02-18 Thread Sean Silva
On Tue, Feb 18, 2014 at 7:07 PM, Henner Zeller wrote: > Thanks for working on cleaning up the code-base by using more > stringent compiler warnings. > > While I can't comment on the original question as I don't know the > code too much (I would add ''const' in the Base class), The base class is

Re: [Kicad-developers] Plethora of warnings from -Woverloaded-virtual

2014-02-18 Thread Henner Zeller
Thanks for working on cleaning up the code-base by using more stringent compiler warnings. While I can't comment on the original question as I don't know the code too much (I would add ''const' in the Base class), I suggest something for a styleguide: - Always in derived method, prepend it wit

[Kicad-developers] Plethora of warnings from -Woverloaded-virtual

2014-02-18 Thread Sean Silva
Hi all, I'm just wanting to make sure that some warnings that I'm seeing are not intentional before I submit a patch to fix them. Clang's -Woverloaded-virtual warning [*] fires many times when building, primarily of the form: In file included from /home/sean/pg/others/kicad/kicad/eeschema/lib_pol

Re: [Kicad-developers] PATCH: Component chooser now with thumbnail image of the component. And Unit select.

2014-02-18 Thread Tomasz Wlostowski
On 02/19/2014 12:01 AM, Henner Zeller wrote: On 18 February 2014 14:51, Tomasz Wlostowski wrote: On 02/18/2014 08:28 PM, Wayne Stambaugh wrote: On 2/18/2014 12:22 PM, Henner Zeller wrote: I agree with your assessment about EDA_DRAW_PANEL being decoupled from the frame window. My guess is

Re: [Kicad-developers] PATCH: Component chooser now with thumbnail image of the component. And Unit select.

2014-02-18 Thread Henner Zeller
On 18 February 2014 14:51, Tomasz Wlostowski wrote: > On 02/18/2014 08:28 PM, Wayne Stambaugh wrote: >> >> On 2/18/2014 12:22 PM, Henner Zeller wrote: > > >> I agree with your assessment about EDA_DRAW_PANEL being decoupled from >> the frame window. My guess is that would be quite a significant >

Re: [Kicad-developers] PATCH: Component chooser now with thumbnail image of the component. And Unit select.

2014-02-18 Thread Tomasz Wlostowski
On 02/18/2014 08:28 PM, Wayne Stambaugh wrote: On 2/18/2014 12:22 PM, Henner Zeller wrote: I agree with your assessment about EDA_DRAW_PANEL being decoupled from the frame window. My guess is that would be quite a significant undertaking given the current design. If this is something you wan

Re: [Kicad-developers] PATCH: Component chooser now with thumbnail image of the component. And Unit select.

2014-02-18 Thread Wayne Stambaugh
On 2/18/2014 3:58 PM, Henner Zeller wrote: > On 18 February 2014 12:10, jp charras wrote: >> Le 18/02/2014 20:28, Wayne Stambaugh a écrit : >>> On 2/18/2014 12:22 PM, Henner Zeller wrote: On 18 February 2014 08:31, Wayne Stambaugh wrote: > On 2/18/2014 2:40 AM, Henner Zeller wrote: >

Re: [Kicad-developers] PATCH: Component chooser now with thumbnail image of the component. And Unit select.

2014-02-18 Thread Henner Zeller
On 18 February 2014 13:11, Wayne Stambaugh wrote: > On 2/18/2014 3:58 PM, Henner Zeller wrote: >> On 18 February 2014 12:10, jp charras wrote: >>> Le 18/02/2014 20:28, Wayne Stambaugh a écrit : On 2/18/2014 12:22 PM, Henner Zeller wrote: > On 18 February 2014 08:31, Wayne Stambaugh wrot

Re: [Kicad-developers] PATCH: Component chooser now with thumbnail image of the component. And Unit select.

2014-02-18 Thread Wayne Stambaugh
On 2/18/2014 3:58 PM, Henner Zeller wrote: > On 18 February 2014 12:10, jp charras wrote: >> Le 18/02/2014 20:28, Wayne Stambaugh a écrit : >>> On 2/18/2014 12:22 PM, Henner Zeller wrote: On 18 February 2014 08:31, Wayne Stambaugh wrote: > On 2/18/2014 2:40 AM, Henner Zeller wrote: >

Re: [Kicad-developers] PATCH: Component chooser now with thumbnail image of the component. And Unit select.

2014-02-18 Thread Henner Zeller
On 18 February 2014 12:10, jp charras wrote: > Le 18/02/2014 20:28, Wayne Stambaugh a écrit : >> On 2/18/2014 12:22 PM, Henner Zeller wrote: >>> On 18 February 2014 08:31, Wayne Stambaugh wrote: On 2/18/2014 2:40 AM, Henner Zeller wrote: > Hi, > > This is an update patch to the n

Re: [Kicad-developers] PATCH: Component chooser now with thumbnail image of the component. And Unit select.

2014-02-18 Thread jp charras
Le 18/02/2014 20:28, Wayne Stambaugh a écrit : > On 2/18/2014 12:22 PM, Henner Zeller wrote: >> On 18 February 2014 08:31, Wayne Stambaugh wrote: >>> On 2/18/2014 2:40 AM, Henner Zeller wrote: Hi, This is an update patch to the new component chooser containing the planned follo

Re: [Kicad-developers] PATCH: Component chooser now with thumbnail image of the component. And Unit select.

2014-02-18 Thread Wayne Stambaugh
On 2/18/2014 12:22 PM, Henner Zeller wrote: > On 18 February 2014 08:31, Wayne Stambaugh wrote: >> On 2/18/2014 2:40 AM, Henner Zeller wrote: >>> Hi, >>> >>> This is an update patch to the new component chooser containing the >>> planned followup-change to display a mini-preview of the component.

Re: [Kicad-developers] PATCH: Component chooser now with thumbnail image of the component. And Unit select.

2014-02-18 Thread Henner Zeller
On 18 February 2014 08:31, Wayne Stambaugh wrote: > On 2/18/2014 2:40 AM, Henner Zeller wrote: >> Hi, >> >> This is an update patch to the new component chooser containing the >> planned followup-change to display a mini-preview of the component. >> Clicking on that box opens the 'big' component b

Re: [Kicad-developers] PATCH: Component chooser now with thumbnail image of the component. And Unit select.

2014-02-18 Thread Wayne Stambaugh
On 2/18/2014 2:40 AM, Henner Zeller wrote: > Hi, > > This is an update patch to the new component chooser containing the > planned followup-change to display a mini-preview of the component. > Clicking on that box opens the 'big' component browser (Also fixes > [Bug 1280567]). (Since we already ca

Re: [Kicad-developers] PATCH: Component chooser now with thumbnail image of the component. And Unit select.

2014-02-18 Thread Tomasz Wlostowski
On 02/18/2014 08:40 AM, Henner Zeller wrote: Hi, This is an update patch to the new component chooser containing the planned followup-change to display a mini-preview of the component. Clicking on that box opens the 'big' component browser (Also fixes [Bug 1280567]). (Since we already can presel

Re: [Kicad-developers] Clang unknown pragma warnings

2014-02-18 Thread Henner Zeller
On 17 February 2014 23:35, Lorenzo Marcantonio wrote: > On Mon, Feb 17, 2014 at 11:25:09PM +0100, Camille 019 wrote: >> Hi, >> The attached patch change conditional inclusion around "pragma >> implementation" to avoid unknown pragma warnings with Clang. > > Why are still we using pragma implement