[Kicad-developers] fyi extra changes in r4203

2013-06-09 Thread Chris Morgan
http://bazaar.launchpad.net/~kicad-testing-committers/kicad/testing/revision/4203 Spotted the extra changes to HOW_TO_CONTRIBUTE.txt when trying to merge up to the latest kicad here as it caused a conflict. Chris ___ Mailing list: https://launchpad.net/

[Kicad-developers] Origins

2013-06-09 Thread NHays Terrace
It seems to me that the coordinate origin being up and left of the sheet is rather arbitrary. I can understand that you must start somewhere and that the system needs an absolute origin. But when I relocate the grid origin, I would think that the XY status bar report should move with it. I am used

Re: [Kicad-developers] [PATCH] - Implement auto panning while moving in EDA_DRAW_PANEL::OnMouseEvent()

2013-06-09 Thread Dick Hollenbeck
On 06/09/2013 01:25 PM, Chris Morgan wrote: > I think you have good points. I'll take a look at the more comprehensive fix > for the issue. > > On the point of animating the pan, what are your thoughts? The pan today is > very > discontinuous looking. >From a user interface standpoint, the ani

Re: [Kicad-developers] [PATCH] - Implement auto panning while moving in EDA_DRAW_PANEL::OnMouseEvent()

2013-06-09 Thread Chris Morgan
I think you have good points. I'll take a look at the more comprehensive fix for the issue. On the point of animating the pan, what are your thoughts? The pan today is very discontinuous looking. Chris On Sunday, June 9, 2013, Dick Hollenbeck wrote: > On 06/09/2013 01:01 PM, Dick Hollenbeck w

Re: [Kicad-developers] [PATCH] - Implement auto panning while moving in EDA_DRAW_PANEL::OnMouseEvent()

2013-06-09 Thread Dick Hollenbeck
On 06/09/2013 01:01 PM, Dick Hollenbeck wrote: > >> The if() test should probably be: >> >> >> if( size.x <= event.GetX() || size.y <= event.GetY() >> || event.GetX() < 0 || event.GetY() < 0 ) > > > Fine, that works. > > But let's remember that there are workspace limits defined by how ma

Re: [Kicad-developers] [PATCH] - Implement auto panning while moving in EDA_DRAW_PANEL::OnMouseEvent()

2013-06-09 Thread Dick Hollenbeck
> The if() test should probably be: > > > if( size.x <= event.GetX() || size.y <= event.GetY() > || event.GetX() < 0 || event.GetY() < 0 ) Fine, that works. But let's remember that there are workspace limits defined by how many nanometers can fit in a 32 bit integer workspace. I don't

Re: [Kicad-developers] missing page layout

2013-06-09 Thread Dick Hollenbeck
On 06/09/2013 11:55 AM, jp charras wrote: > Le 09/06/2013 18:33, Dick Hollenbeck a écrit : >> Jean-Pierre, >> >> >> When I open latest pcbnew I get the attached message. >> >> a) The title of the window is wrong, window titles should be capitalized, >> per UI guidelines. >> >> >> b) the window its

Re: [Kicad-developers] [PATCH] - Implement auto panning while moving in EDA_DRAW_PANEL::OnMouseEvent()

2013-06-09 Thread Dick Hollenbeck
Looking at it again, I think there *still* some asymmetry with respect to the if() test. The if() test should probably be: if( size.x <= event.GetX() || size.y <= event.GetY() || event.GetX() < 0 || event.GetY() < 0 ) So that if the mouse is even one pixel outside the client, or more, t

Re: [Kicad-developers] [PATCH] - Implement auto panning while moving in EDA_DRAW_PANEL::OnMouseEvent()

2013-06-09 Thread Dick Hollenbeck
Thanks Chris for reporting this problem. I am not thrilled about having support for panning in two different places (especially if the original location is no longer functional). The original place is EDA_DRAW_PANEL::OnMouseLeaving() as you pointed out. Looking in there, I discovered an "off b

Re: [Kicad-developers] missing page layout

2013-06-09 Thread jp charras
Le 09/06/2013 18:33, Dick Hollenbeck a écrit : Jean-Pierre, When I open latest pcbnew I get the attached message. a) The title of the window is wrong, window titles should be capitalized, per UI guidelines. b) the window itself is un-welcomed at this point. So maybe some user instruction

Re: [Kicad-developers] [PATCH] - Implement auto panning while moving in EDA_DRAW_PANEL::OnMouseEvent()

2013-06-09 Thread Chris Morgan
On Sun, Jun 9, 2013 at 11:05 AM, Dick Hollenbeck wrote: > On 06/08/2013 07:08 PM, Chris Morgan wrote: > > I'm still not sure how to generate patches with bzr. I really want to do > 'bzr format-patch > > -1' like with git but I can't find an equivalent approach. > > > > ---

Re: [Kicad-developers] [PATCH] - Implement auto panning while moving in EDA_DRAW_PANEL::OnMouseEvent()

2013-06-09 Thread Dick Hollenbeck
On 06/08/2013 07:08 PM, Chris Morgan wrote: > I'm still not sure how to generate patches with bzr. I really want to do 'bzr > format-patch > -1' like with git but I can't find an equivalent approach. > > > revno: 4196 > committer: Chris