Re: [PATCH 2/7] kexec_file: print out debugging message if required

2023-11-23 Thread Nathan Chancellor
On Thu, Nov 23, 2023 at 09:49:20PM +0800, b...@redhat.com wrote: > On 11/17/23 at 10:01pm, Baoquan He wrote: > > On 11/17/23 at 09:37am, Liu, Yujie wrote: > > > Hi Baoquan, > > > > > > On Fri, 2023-11-17 at 17:14 +0800, Baoquan He wrote: > > > > Hi, > > > > > > > > On 11/16/23 at 05:04am, kernel

Re: [PATCH linux-next v3 00/14] Split crash out from kexec and clean up related config items

2024-01-25 Thread Nathan Chancellor
Hi Baoquan, On Wed, Jan 24, 2024 at 01:12:40PM +0800, Baoquan He wrote: > Motivation: > = > Previously, LKP reported a building error. When investigating, it can't > be resolved reasonablly with the present messy kdump config items. > > https://lore.kernel.org/oe-kbuild-all/202312182

Re: [PATCH linux-next 1/3] x86, crash: don't nest CONFIG_CRASH_DUMP ifdef inside CONFIG_KEXEC_CODE ifdef scope

2024-02-02 Thread Nathan Chancellor
This series resolves the build issues I was seeing. Please feel free to carry Tested-by: Nathan Chancellor # build forward if there are any more revisions without drastic changes. On Mon, Jan 29, 2024 at 09:50:31PM +0800, Baoquan He wrote: > Michael pointed out that the #if

Re: [RFC PATCH 2/9] x86/purgatory: Simplify stack handling

2024-04-24 Thread Nathan Chancellor
On Wed, Apr 24, 2024 at 05:53:12PM +0200, Ard Biesheuvel wrote: > From: Ard Biesheuvel > > The x86 purgatory, which does little more than verify a SHA-256 hash of > the loaded segments, currently uses three different stacks: > - one in .bss that is used to call the purgatory C code > - one in .ro

Re: [RFC PATCH 2/9] x86/purgatory: Simplify stack handling

2024-04-26 Thread Nathan Chancellor
On Fri, Apr 26, 2024 at 09:32:52PM +, Justin Stitt wrote: > Hi, > > On Wed, Apr 24, 2024 at 11:26:59AM -0700, Nathan Chancellor wrote: > > On Wed, Apr 24, 2024 at 05:53:12PM +0200, Ard Biesheuvel wrote: > > > arch/x86/purgatory/stack.S| 18

Re: [PATCH v5 13/20] x86/kexec: Mark relocate_kernel page as ROX instead of RWX

2024-12-11 Thread Nathan Chancellor
Hi David, On Thu, Dec 05, 2024 at 03:05:19PM +, David Woodhouse wrote: > From: David Woodhouse > > All writes to the page now happen before it gets marked as executable > (or after it's already switched to the identmap page tables where it's > OK to be RWX). > > Signed-off-by: David Woodhou

Re: [PATCH v5 07/20] x86/kexec: Invoke copy of relocate_kernel() instead of the original

2024-12-15 Thread Nathan Chancellor
On Sun, Dec 15, 2024 at 10:09:57AM +, David Woodhouse wrote: > On Sat, 2024-12-14 at 16:08 -0700, Nathan Chancellor wrote: > > > > I guess this seems somewhat unavoidable because control_page is just a > > 'void *', perhaps machine_kexec() should just be m

Re: [PATCH] x86/kexec: Only write through identity mapping of control page

2024-12-12 Thread Nathan Chancellor
X instead of > RWX") > Reported-by: Nathan Chancellor > Reported-by: "Ning, Hongyu" > Closes: https://bugzilla.kernel.org/show_bug.cgi?id=219592 > Signed-off-by: David Woodhouse Tested-by: Nathan Chancellor > --- > arch/x86/kernel/relocate_kernel_64.S | 32

Re: [PATCH v5 13/20] x86/kexec: Mark relocate_kernel page as ROX instead of RWX

2024-12-12 Thread Nathan Chancellor
On Thu, Dec 12, 2024 at 05:00:00PM +, David Woodhouse wrote: > > > > Here is the output that I see with that patch applied when rebooting via > > 'systemctl kexec': > > > > RAX=00010c070001 RBX= RCX= > > RDX=00047fffb1a0 > > RSI=00011c444000 RDI=00

Re: [PATCH v5 07/20] x86/kexec: Invoke copy of relocate_kernel() instead of the original

2024-12-14 Thread Nathan Chancellor
Hi David, On Thu, Dec 05, 2024 at 03:05:13PM +, David Woodhouse wrote: > From: David Woodhouse > > This currently calls set_memory_x() from machine_kexec_prepare() just > like the 32-bit version does. That's actually a bit earlier than I'd > like, as it leaves the page RWX all the time the i

Re: [PATCH v4 0/4] stackleak: Support Clang stack depth tracking

2025-07-26 Thread Nathan Chancellor
Hi Kees, On Wed, Jul 23, 2025 at 10:50:24PM -0700, Kees Cook wrote: > v4: > - rebase on for-next/hardening tree (took subset of v3 patches) > - improve commit logs for x86 and arm64 changes (Mike, Will, Ard) > v3: https://lore.kernel.org/lkml/20250717231756.make.423-k...@kernel.org/ > v2: h