Re: [PATCH v3] vmcore-dmesg: Collect full dmesg regardless of logged_chars

2015-12-08 Thread Dave Young
On 12/08/15 at 03:04pm, Simon Horman wrote: > On Tue, Dec 08, 2015 at 11:36:04AM +0800, Dave Young wrote: > > On 11/18/15 at 01:24pm, Dangyi Liu wrote: > > > Simon, > > > > > > Could you help to review this patch? > > > > > > Thanks, >

Re: [PATCH 10/14] crashdump/ppc: Add print_crashkernel_region_size() function

2015-12-08 Thread Dave Young
On 12/08/15 at 10:57pm, Daniel Kiper wrote: > Provide just print_crashkernel_region_size() stub. This way > we can properly build kexec utility on ppc arch even > if the functionality is not available on it. The functionality is available by reading device tree nodes in procfs.. > > Signed-off-b

Re: [PATCH 11/14] crashdump/ppc64: Add print_crashkernel_region_size() function

2015-12-08 Thread Dave Young
On 12/08/15 at 10:57pm, Daniel Kiper wrote: > Provide just print_crashkernel_region_size() stub. This way > we can properly build kexec utility on ppc64 arch even > if the functionality is not available on it. Ditto as ppc, you can read procfs file to get the values.. > > Signed-off-by: Daniel K

Re: [PATCH 06/14] crashdump/cris: Add print_crashkernel_region_size() function

2015-12-08 Thread Dave Young
On 12/08/15 at 10:57pm, Daniel Kiper wrote: > Provide just print_crashkernel_region_size() stub. This way > we can properly build kexec utility on cris arch even > if the functionality is not available on it. > > Signed-off-by: Daniel Kiper > --- > kexec/arch/cris/kexec-cris.c |5 + > 1

Re: [PATCH 2/2] kexec: Provide arch_kexec_protect(unprotect)_crashkres()

2015-12-23 Thread Dave Young
Ccing Vivek On 12/23/15 at 07:12pm, Xunlei Pang wrote: > Implement the protection method for the crash kernel memory > reservation for the 64-bit x86 kdump. > > Signed-off-by: Xunlei Pang > --- > Only provided x86_64 implementation, as I've only tested on x86_64 so far. > > arch/x86/kernel/mac

Re: [PATCH 2/2] kexec: Provide arch_kexec_protect(unprotect)_crashkres()

2015-12-23 Thread Dave Young
Hi, Xunlei On 12/24/15 at 02:05pm, Xunlei Pang wrote: > On 12/24/2015 at 01:54 PM, Dave Young wrote: > > Ccing Vivek > > > > On 12/23/15 at 07:12pm, Xunlei Pang wrote: > >> Implement the protection method for the crash kernel memory > >> reservation for the

Re: [Linux-ima-devel] [PATCH v2 4/7] ima: measure and appraise kexec image and initramfs

2015-12-24 Thread Dave Young
s will be freed at the end of kexec_file_load syscall. > > Changelog v2: > - Calculate the file hash from the in memory buffer (suggested by Dave Young) > - Rename ima_read_and_process_file() to ima_hash_and_process_file() > - replace individual case statements with range: >

Re: [Linux-ima-devel] [PATCH v2 4/7] ima: measure and appraise kexec image and initramfs

2015-12-27 Thread Dave Young
Hi, Mimi On 12/25/15 at 09:45am, Mimi Zohar wrote: > On Fri, 2015-12-25 at 13:33 +0800, Dave Young wrote: > > Hi, Mimi > > > > CCing kexec list, not all kexec people subscribed to IMA list. > > I just subscribed to it since Vivek CCed me last time about the V1 of t

Re: [Linux-ima-devel] [PATCH v2 4/7] ima: measure and appraise kexec image and initramfs

2015-12-29 Thread Dave Young
Hi, Mimi On 12/28/15 at 07:51am, Mimi Zohar wrote: > On Mon, 2015-12-28 at 10:08 +0800, Dave Young wrote: > > On 12/25/15 at 09:45am, Mimi Zohar wrote: > > > IMA calculates the file hash, in this case, based on the buffer > > > contents. The hash is calculated once an

Re: [PATCH v2 14/16] x86, nvdimm, kexec: Use walk_iomem_res_desc() for iomem search

2016-01-04 Thread Dave Young
Hi, Toshi, On 12/25/15 at 03:09pm, Toshi Kani wrote: > Change to call walk_iomem_res_desc() for searching resource entries > with the following names: > "ACPI Tables" > "ACPI Non-volatile Storage" > "Persistent Memory (legacy)" > "Crash kernel" > > Note, the caller of walk_iomem_res() with "G

Re: [PATCH v2 14/16] x86, nvdimm, kexec: Use walk_iomem_res_desc() for iomem search

2016-01-04 Thread Dave Young
Hi, Boris On 12/27/15 at 11:24am, Borislav Petkov wrote: > On Sun, Dec 27, 2015 at 10:12:57AM +0800, Minfei Huang wrote: > > You can refer the below link that you may get a clue about GART. This is > > the fisrt time kexec-tools tried to support to ignore GART region in 2nd > > kernel. > > > > ht

Re: [PATCH v2 14/16] x86, nvdimm, kexec: Use walk_iomem_res_desc() for iomem search

2016-01-04 Thread Dave Young
On 01/04/16 at 05:25pm, Dave Young wrote: > Hi, Toshi, > > On 12/25/15 at 03:09pm, Toshi Kani wrote: > > Change to call walk_iomem_res_desc() for searching resource entries > > with the following names: > > "ACPI Tables" > > "ACPI Non-v

Re: [PATCH v2 14/16] x86, nvdimm, kexec: Use walk_iomem_res_desc() for iomem search

2016-01-04 Thread Dave Young
On 01/04/16 at 01:26pm, Borislav Petkov wrote: > On Mon, Jan 04, 2016 at 05:29:37PM +0800, Dave Young wrote: > > Replied to Toshi old kernel will export the "GART" region for amd cards. > > So for old kernel and new kexec-tools we will have problem. > > &g

Kexec_file_load failed with "Missing required AuthAttr"

2016-01-06 Thread Dave Young
Hi, I saw the warning "Missing required AuthAttr" when testing kexec, known issue? Idea about how to fix it? The kernel is latest linus tree plus sevral patches from Toshi to cleanup io resource structure. in function pkcs7_sig_note_set_of_authattrs(): if (!test_bit(sinfo_has_content_ty

Re: [PATCH v3 07/17] kexec: Set IORESOURCE_SYSTEM_RAM to System RAM

2016-01-07 Thread Dave Young
TEM_RAM for > a System RAM range. > > Change kexec_add_buffer() to call walk_iomem_res() with > IORESOURCE_SYSTEM_RAM type for "Crash kernel". > > Cc: Andrew Morton > Cc: Dave Young > Cc: kexec@lists.infradead.org > Signed-off-by: Toshi Kani > --- > ke

Re: Kexec_file_load failed with "Missing required AuthAttr"

2016-01-15 Thread Dave Young
Ccing Peter Jones for pesign possible issues. On 01/07/16 at 01:25pm, Dave Young wrote: > Hi, > > I saw the warning "Missing required AuthAttr" when testing kexec, known issue? > Idea about how to fix it? > > The kernel is latest linus tree plus sevral patc

[PATCH] arm/kdump: fix kernel panic for masking disabled irq

2016-01-16 Thread Dave Young
+0x1/0x4c) [ 66.885332] Code: 443c 4643 f6a9 f9a1 (6823) 0732 [ 66.890145] ---[ end trace 5a39094ece4dc200 ]--- [ 66.894782] Kernel panic - not syncing: Fatal exception [ 66.900033] ---[ end Kernel panic - not syncing: Fatal exception Signed-off-by: Dave Young --- arch/arm/kernel/machine_kexec

Re: [PATCH] Don't require SpcSpOpusInfo in Authenticode pkcs7 signatures

2016-01-18 Thread Dave Young
On 01/18/16 at 10:49am, Peter Jones wrote: > Dave Young reported: > > Hi, > > > > I saw the warning "Missing required AuthAttr" when testing kexec, > > known issue? Idea about how to fix it? > > > > The kernel is latest linus tree plus sev

Re: [PATCH 18/19] arm64: kdump: update a kernel doc

2016-01-18 Thread Dave Young
On 01/18/16 at 07:26pm, AKASHI Takahiro wrote: > On 01/16/2016 05:16 AM, Mark Rutland wrote: > >On Fri, Jan 15, 2016 at 07:18:38PM +, Geoff Levand wrote: > >>From: AKASHI Takahiro > >> > >>This patch adds arch specific descriptions about kdump usage on arm64 > >>to kdump.txt. > >> > >>Signed-o

Re: [PATCH 18/19] arm64: kdump: update a kernel doc

2016-01-18 Thread Dave Young
On 01/19/16 at 09:43am, Dave Young wrote: > On 01/18/16 at 07:26pm, AKASHI Takahiro wrote: > > On 01/16/2016 05:16 AM, Mark Rutland wrote: > > >On Fri, Jan 15, 2016 at 07:18:38PM +, Geoff Levand wrote: > > >>From: AKASHI Takahiro > > >> > > &g

Re: [PATCH 18/19] arm64: kdump: update a kernel doc

2016-01-19 Thread Dave Young
On 01/19/16 at 02:35pm, AKASHI Takahiro wrote: > On 01/19/2016 10:43 AM, Dave Young wrote: > >On 01/18/16 at 07:26pm, AKASHI Takahiro wrote: > >>On 01/16/2016 05:16 AM, Mark Rutland wrote: > >>>On Fri, Jan 15, 2016 at 07:18:38PM +, Geoff Levand wrot

Re: [PATCH 00/19] arm64 kexec kernel patches v13

2016-01-19 Thread Dave Young
On 01/15/16 at 07:18pm, Geoff Levand wrote: > This series adds the core support for kexec re-boot and kdump on ARM64. This > version of the series combines Takahiro's kdump patches with my kexec patches. > Please consider all patches for inclusion. > > I just tested all the endian combinations of

Re: [PATCH 18/19] arm64: kdump: update a kernel doc

2016-01-19 Thread Dave Young
On 01/19/16 at 12:51pm, Mark Rutland wrote: > On Tue, Jan 19, 2016 at 08:28:48PM +0800, Dave Young wrote: > > On 01/19/16 at 02:35pm, AKASHI Takahiro wrote: > > > On 01/19/2016 10:43 AM, Dave Young wrote: > > > >On 01/18/16 at 07:26pm, AKASHI Takahiro wrote: > &

Re: [PATCH 18/19] arm64: kdump: update a kernel doc

2016-01-19 Thread Dave Young
On 01/19/16 at 12:17pm, Mark Rutland wrote: > On Tue, Jan 19, 2016 at 09:43:32AM +0800, Dave Young wrote: > > On 01/18/16 at 07:26pm, AKASHI Takahiro wrote: > > > On 01/16/2016 05:16 AM, Mark Rutland wrote: > > > >On Fri, Jan 15, 2016 at 07:18:38PM +, Geoff Leva

Re: [PATCH 18/19] arm64: kdump: update a kernel doc

2016-01-19 Thread Dave Young
On 01/19/16 at 02:01pm, Mark Rutland wrote: > On Tue, Jan 19, 2016 at 09:45:53PM +0800, Dave Young wrote: > > On 01/19/16 at 12:51pm, Mark Rutland wrote: > > > On Tue, Jan 19, 2016 at 08:28:48PM +0800, Dave Young wrote: > > > > On 01/19/16 at 02:35pm, AKASHI Takahiro

Re: [PATCH 18/19] arm64: kdump: update a kernel doc

2016-01-19 Thread Dave Young
On 01/19/16 at 02:05pm, Mark Rutland wrote: > On Tue, Jan 19, 2016 at 09:52:33PM +0800, Dave Young wrote: > > On 01/19/16 at 12:17pm, Mark Rutland wrote: > > > On Tue, Jan 19, 2016 at 09:43:32AM +0800, Dave Young wrote: > > > > On 01/18/16 at 07:26pm, AKASHI Takahiro

Re: [PATCH 00/19] arm64 kexec kernel patches v13

2016-01-19 Thread Dave Young
On 01/19/16 at 04:15pm, Geoff Levand wrote: > On Tue, 2016-01-19 at 20:32 +0800, Dave Young wrote: > > Geoff, another question about kexec-tools part is, can the kexec > > -tools code > > been written in kernel? We have the infrastructure for kexec_file_load. > > I see

Re: [PATCH 18/19] arm64: kdump: update a kernel doc

2016-01-19 Thread Dave Young
On 01/20/16 at 03:07pm, AKASHI Takahiro wrote: > On 01/20/2016 11:49 AM, Dave Young wrote: > >On 01/19/16 at 02:01pm, Mark Rutland wrote: > >>On Tue, Jan 19, 2016 at 09:45:53PM +0800, Dave Young wrote: > >>>On 01/19/16 at 12:51pm, Mark Rutland wrote: > >>>

Re: [PATCH 18/19] arm64: kdump: update a kernel doc

2016-01-19 Thread Dave Young
> > So I'm not still sure about what are advantages of a property under /chosen > > over "memmap=" kernel parameter. > > Both are simple and can have the same effect with minimizing changes to dtb. > > (But if, in the latter case, we have to provide *all* the memory-related > > information > > thr

Re: [PATCH 18/19] arm64: kdump: update a kernel doc

2016-01-20 Thread Dave Young
On 01/20/16 at 05:01pm, AKASHI Takahiro wrote: > On 01/20/2016 04:00 PM, Dave Young wrote: > >>>So I'm not still sure about what are advantages of a property under /chosen > >>>over "memmap=" kernel parameter. > >>>Both are simple and can hav

Re: [PATCH 18/19] arm64: kdump: update a kernel doc

2016-01-20 Thread Dave Young
On 01/20/16 at 11:28am, Mark Rutland wrote: > On Wed, Jan 20, 2016 at 10:49:46AM +0800, Dave Young wrote: > > On 01/19/16 at 02:01pm, Mark Rutland wrote: > > > On Tue, Jan 19, 2016 at 09:45:53PM +0800, Dave Young wrote: > > > > On 01/19/16 at 12:51pm, Mark Rutland w

Re: [PATCH 18/19] arm64: kdump: update a kernel doc

2016-01-20 Thread Dave Young
Hi, Mark On 01/20/16 at 11:54am, Mark Rutland wrote: > On Wed, Jan 20, 2016 at 02:38:56PM +0800, Dave Young wrote: > > Maybe I did not say it clearly, I prefer kexec syscall/tool to modifiy dtb > > or uefi-memmap so that we do not need any extra kernel cmdline. > > I a

Re: [PATCH 18/19] arm64: kdump: update a kernel doc

2016-01-20 Thread Dave Young
> I am strongly opposed to modifying the FW-provided memroy map > information, for the reasons I expressed in other replies. > > What are your concerns with a property under /chosen? If we choose a simpler way between memmap= and /chosen property then I think a property in /chosen looks better to

Re: [PATCH 18/19] arm64: kdump: update a kernel doc

2016-01-24 Thread Dave Young
Hi, AKASHI > >To place "elfcorehdr=" or "memmap="/"usable-memory=" into the command > >line, one needs to know where it is valid to place it. Appending doesn't > >always work, as per the example above with 51e158c12aca3c9a. > > So, are you now suggesting that we put both "elfcorehdr=" and > "usab

Re: [PATCH 18/19] arm64: kdump: update a kernel doc

2016-01-24 Thread Dave Young
On 01/25/16 at 11:19am, Dave Young wrote: > Hi, AKASHI > > > >To place "elfcorehdr=" or "memmap="/"usable-memory=" into the command > > >line, one needs to know where it is valid to place it. Appending doesn't > > >always work,

Re: [RFC PATCH v2 06/11] kexec: replace call to copy_file_from_fd() with kernel version

2016-01-24 Thread Dave Young
hooks" to fix sparse warning > > v2: > - Calculate the file hash from the in memory buffer > (suggested by Dave Young) > - Rename ima_read_and_process_file() to ima_hash_and_process_file() > - replace individual case statements with range: > KEXEC_CHECK ... IMA_MAX_

Re: [RFC PATCH v2 06/11] kexec: replace call to copy_file_from_fd() with kernel version

2016-01-24 Thread Dave Young
> > diff --git a/fs/exec.c b/fs/exec.c > > index 211b81c..a5ae51e 100644 > > --- a/fs/exec.c > > +++ b/fs/exec.c > > @@ -884,6 +884,21 @@ out: > > } > > EXPORT_SYMBOL_GPL(kernel_read_file); > > > > +int kernel_read_file_from_fd(int fd, void **buf, loff_t *size, loff_t > > max_size, > > +

Re: [RFC PATCH v2 06/11] kexec: replace call to copy_file_from_fd() with kernel version

2016-01-25 Thread Dave Young
Hi, Mimi On 01/25/16 at 10:04am, Mimi Zohar wrote: > On Mon, 2016-01-25 at 14:37 +0800, Dave Young wrote: > > Hi, Mimi > > > > Besides of code issues, I have several thing to be understand: > > > > What is the effect to kexec behavior with this patchset? > &

Re: [RFC PATCH v2 06/11] kexec: replace call to copy_file_from_fd() with kernel version

2016-01-26 Thread Dave Young
On 01/26/16 at 11:40am, Mimi Zohar wrote: > Hi Dave, > > On Tue, 2016-01-26 at 09:20 +0800, Dave Young wrote: > > Hi, Mimi > > > > On 01/25/16 at 10:04am, Mimi Zohar wrote: > > > On Mon, 2016-01-25 at 14:37 +0800, Dave Young wrote: > > > > Hi, Mimi

[PATCH] x86/efi: skip bgrt init for kexec reboot

2016-01-27 Thread Dave Young
-by: Dave Young --- arch/x86/platform/efi/efi.c |3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) --- linux-x86.orig/arch/x86/platform/efi/efi.c +++ linux-x86/arch/x86/platform/efi/efi.c @@ -531,7 +531,8 @@ void __init efi_init(void) void __init efi_late_init(void

Re: [PATCH] x86/efi: skip bgrt init for kexec reboot

2016-02-03 Thread Dave Young
On 01/27/16 at 07:20pm, Dave Young wrote: > For kexec reboot the bgrt image address could contains random data because > we have freed boot service areas in 1st kernel boot phase. One possible > result is kmalloc fail in efi_bgrt_init due to large random image size. > > So chang

Re: [PATCH] x86/efi: skip bgrt init for kexec reboot

2016-02-04 Thread Dave Young
Hi, Matt Thanks for the feedback. On 02/04/16 at 10:03am, Matt Fleming wrote: > On Wed, 03 Feb, at 10:53:33PM, Matt Fleming wrote: > > On Thu, 04 Feb, at 05:42:00AM, Dave Young wrote: > > > > > > On 01/27/16 at 07:20pm, Dave Young wrote: > > > > For ke

Re: [PATCH] x86/efi: skip bgrt init for kexec reboot

2016-02-04 Thread Dave Young
On 02/04/16 at 11:56am, Matt Fleming wrote: > On Thu, 04 Feb, at 07:09:03PM, Dave Young wrote: > > > > Consider the original code path, maybe change it to efi_kexec_setup will > > be better to remind people? Or something else like a wraper function with > > similar n

Re: [PATCH] x86/efi: skip bgrt init for kexec reboot

2016-02-12 Thread Dave Young
On 02/11/16 at 04:09pm, Matt Fleming wrote: > On Fri, 05 Feb, at 08:41:15AM, Dave Young wrote: > > On 02/04/16 at 11:56am, Matt Fleming wrote: > > > On Thu, 04 Feb, at 07:09:03PM, Dave Young wrote: > > > > > > > > Consider the original code path, maybe ch

Re: [PATCH v3 18/22] kexec: replace call to copy_file_from_fd() with kernel version

2016-02-12 Thread Dave Young
ad_hooks enumeration to ima_policy_id > - use kstat file size type loff_t, not size_t > - add union name "hooks" to fix sparse warning > - Calculate the file hash from the in memory buffer > (suggested by Dave Young) > - Rename ima_read_and_process_file() to ima_has

Re: [PATCH v3 19/22] ima: support for kexec image and initramfs

2016-02-12 Thread Dave Young
Hi, Mimi > diff --git a/security/integrity/ima/ima.h b/security/integrity/ima/ima.h > index a5d2592..832e62a 100644 > --- a/security/integrity/ima/ima.h > +++ b/security/integrity/ima/ima.h > @@ -147,6 +147,8 @@ enum ima_hooks { > POST_SETATTR, > MODULE_CHECK, > FIRMWARE_CHECK, >

[PATCH] kexec/fs2dt.c: wrong dt node fix

2016-02-25 Thread Dave Young
; to dt. Thus kexec kernel is not happy.. Instead let's fix it by only concating slash when the basenanme is not empty and restore the initial value of pathname as "/proc/device-tree/" Signed-off-by: Dave Young --- kexec/fs2dt.c |5 +++-- 1 file changed, 3 insertions(+), 2 del

Re: [PATCH] kexec/fs2dt.c: wrong dt node fix

2016-02-25 Thread Dave Young
Simon, Oops, the patchlog need a revise since I tested a local branch with latest upstream kexec-tools, but it is not necessary in F23. But the code change is still valid to me, will repost with an updated patch descriptioin. On 02/26/16 at 11:43am, Dave Young wrote: > There is a report

Re: [PATCH 1/3] Pass struct mem_sym into machine_apply_elf_rel()

2016-02-26 Thread Dave Young
tion, unsigned long address, > + unsigned long value); > #endif /* KEXEC_ELF_H */ > > -- > 2.5.0 > > > ___ > kexec mailing list > kexec@lists.infradead.org > http://lists.infradead.org/mailman/listinfo/kexec Tested the 3 patches on ppc64le installed Fedora 23 With the patches applied, I can not reproduce the bug below: https://bugzilla.redhat.com/show_bug.cgi?id=1310495 But loading older kernel ie. 3.10 kernel from RHEL it is not sufficient, still need another patch: http://lists.infradead.org/pipermail/kexec/2016-February/015445.html But above one is only necessary for old kernel, there may be some kernel changes for dtb in recent kernel, I'm not sure why kernel versions matter. Tested-by: Dave Young Thanks Dave ___ kexec mailing list kexec@lists.infradead.org http://lists.infradead.org/mailman/listinfo/kexec

[PATCH update] kexec/fs2dt.c: wrong dt node fix

2016-02-26 Thread Dave Young
empty and restore the initial value of pathname as "/proc/device-tree/" Note: I only reproduce the issue with loading older kernel like 3.10 in RHEL. I do not see the problem in new kernels in Fedora. Signed-off-by: Dave Young --- kexec/fs2dt.c |5 +++-- 1 file changed, 3 insert

Re: [PATCH 0/2] Export new VMCOREINFO about compound page

2016-03-04 Thread Dave Young
nymous page > > kernel/kexec_core.c | 7 +-- > 1 file changed, 5 insertions(+), 2 deletions(-) > > Acked-by: Dave Young Thanks Dave ___ kexec mailing list kexec@lists.infradead.org http://lists.infradead.org/mailman/listinfo/kexec

Re: [PATCH 1/3] Pass struct mem_sym into machine_apply_elf_rel()

2016-03-04 Thread Dave Young
On 02/26/16 at 07:53pm, Dave Young wrote: > On 02/26/16 at 06:03pm, Anton Blanchard wrote: > > On PowerPC64 ABIv2 we need to look at the symbol to determine > > if it has a local entry point. Pass struct mem_sym into > > machine_apply_elf_rel() so we can. > > > &g

Re: [PATCH 2/2] [PATCH 2/2] proc-vmcore: wrong data type casting fix

2016-03-10 Thread Dave Young
Hi, Minfei On 03/11/16 at 03:19pm, Minfei Huang wrote: > On 03/11/16 at 02:21pm, dyo...@redhat.com wrote: > > @@ -231,7 +231,8 @@ static ssize_t __read_vmcore(char *buffe > > > > list_for_each_entry(m, &vmcore_list, list) { > > if (*fpos < m->offset + m->size) { > > -

Re: [PATCH 1/2] [PATCH 1/2] Introduce new macros min_lt and max_lt for comparing with larger type

2016-03-10 Thread Dave Young
so we need use min_t or max_t with u64. > > > > To simplify the usage introducing two more macros min_lt and max_lt, > > 'lt' means larger type. > > > > Signed-off-by: Dave Young > > --- > > include/linux/kernel.h | 13 + > >

[PATCH] proc-vmcore: wrong data type casting fix

2016-03-11 Thread Dave Young
remap_pfn_range(). Use unsigned long long in min_t instead so that the variables are not truncated. Signed-off-by: Baoquan He Signed-off-by: Dave Young --- fs/proc/vmcore.c |7 +-- 1 file changed, 5 insertions(+), 2 deletions(-) --- linux-x86.orig/fs/proc/vmcore.c +++ linux-x86/f

[PATCH V2] proc-vmcore: wrong data type casting fix

2016-03-11 Thread Dave Young
ger BUG_ON() in remap_pfn_range(). Use unsigned long long in min_t instead so that the variables are not truncated. Signed-off-by: Baoquan He Signed-off-by: Dave Young --- v1->v2: spelling fix in patch log fs/proc/vmcore.c |7 +-- 1 file changed, 5 insertions(+), 2 deletions(-) --- linux-x86.ori

Re: [PATCH V2] proc-vmcore: wrong data type casting fix

2016-03-11 Thread Dave Young
Hi, Andrew On 03/11/16 at 12:27pm, Andrew Morton wrote: > On Fri, 11 Mar 2016 16:42:48 +0800 Dave Young wrote: > > > On i686 PAE enabled machine the contiguous physical area could be large > > and it can cause trimming down variables in below calculation in > > read_

Re: [PATCH V2] proc-vmcore: wrong data type casting fix

2016-03-13 Thread Dave Young
Hi, HATAYAMA On 03/14/16 at 12:25pm, HATAYAMA Daisuke wrote: > From: Dave Young > Subject: [PATCH V2] proc-vmcore: wrong data type casting fix > Date: Fri, 11 Mar 2016 16:42:48 +0800 > > > On i686 PAE enabled machine the contiguous physical area could be large > > and it

[PATCH V3] proc-vmcore: wrong data type casting fix

2016-03-14 Thread Dave Young
so that the variables in are not truncated. Signed-off-by: Baoquan He Signed-off-by: Dave Young --- v2->v3: tweak patch description about bug details for people to get the problem easier. v1->v2: spelling fix in patch log fs/proc/vmcore.c |7 +-- 1 file changed, 5 insertions(+), 2 d

Re: [PATCH] ARM: kexec: fix crashkernel= handling

2016-03-29 Thread Dave Young
Hi, Russell A long standing issue, but nobody tried to do it. Thank you for bringing up. On 03/29/16 at 11:10am, Russell King wrote: > When the kernel crashkernel parameter is specified with just a size, we > are supposed to allocate a region from RAM to store the crashkernel. > However, ARM mere

Re: [PATCH v15 00/20] arm64 kexec kernel patches v15

2016-03-31 Thread Dave Young
On 03/14/16 at 05:47pm, Geoff Levand wrote: > This series adds the core support for kexec re-boot and kdump on ARM64. This > version of the series combines Takahiro's kdump patches with my kexec patches. > Please consider all patches for inclusion. > > To load a second stage kernel and execute a

Re: [PATCH] ARM: kexec: fix crashkernel= handling

2016-04-06 Thread Dave Young
On 04/01/16 at 02:25pm, Russell King - ARM Linux wrote: [snip] > Well, if we want to remove it, we then need to sort out a method of > specifying a limit on the address - where platforms physical memory > bridges the 4GB CPU-accessible limit, the crashkernel region must be > allocated below that

Re: [PATCH v2] ARM: kexec: fix crashkernel= handling

2016-04-07 Thread Dave Young
crash_size, SECTION_SIZE); > + if (start != crash_base) { > + pr_err("crashkernel reservation failed - memory is in > use.\n"); > + return; > + } > + } > + > ret = memblock_reserve(crash_base, crash_size); > if (ret < 0) { > pr_warn("crashkernel reservation failed - memory is in use > (0x%lx)\n", Reviewed-by: Dave Young Thanks Dave ___ kexec mailing list kexec@lists.infradead.org http://lists.infradead.org/mailman/listinfo/kexec

kexec loading fails without kernel code address in /proc/iomem

2016-04-14 Thread Dave Young
Hi, Linus Zhengyu Zhang found a kexec failure caused by below commit: commit c4004b02f8e5b9ce357a0bb1641756cc86962664 Author: Linus Torvalds Date: Wed Apr 6 13:45:07 2016 -0700 x86: remove the kernel code/data/bss resources from /proc/iomem Let's see if anybody even notices. I

Re: Removal of the kernel code/data/bss resources does break kexec/kdump

2016-04-19 Thread Dave Young
On 04/14/16 at 06:02pm, Linus Torvalds wrote: > On Thu, Apr 14, 2016 at 1:27 PM, Emrah Demir wrote: > > On 2016-04-14 13:40, Linus Torvalds wrote: > >> > >> > >> Actually, %pK is horrible in /proc and /sys files, and does the wrong > >> thing. > > > > I agree with that, but for now there is no way

Re: Removal of the kernel code/data/bss resources does break kexec/kdump

2016-04-19 Thread Dave Young
On 04/19/16 at 09:20am, Linus Torvalds wrote: > On Tue, Apr 19, 2016 at 2:04 AM, Dave Young wrote: > > > > It is not clear how to handle it, maybe we can assume nobody is using it as > > non-root, leave it as is or just add |CAP_SYS_BOOT for /proc/iomem? > > Pretty mu

Re: [PATCH 00/12] Fixing TI Keystone2 kexec

2016-05-11 Thread Dave Young
Hi, Russell On 04/28/16 at 10:26am, Russell King - ARM Linux wrote: > These changes are required for TI Keystone2 kexec to be functional. TI > Keystone2 has the run-time view of physical memory above 4GiB, but with > a boot time alias below 4GiB which can only be used during the early > boot. >

Re: [PATCH 00/12] Fixing TI Keystone2 kexec

2016-05-11 Thread Dave Young
On 05/11/16 at 09:52am, Russell King - ARM Linux wrote: > On Wed, May 11, 2016 at 04:29:23PM +0800, Dave Young wrote: > > Hi, Russell > > > > On 04/28/16 at 10:26am, Russell King - ARM Linux wrote: > > > These changes are required for TI Keystone2 kexec to be funct

Re: [PATCH 00/12] Fixing TI Keystone2 kexec

2016-05-11 Thread Dave Young
On 05/11/16 at 10:32am, Russell King - ARM Linux wrote: > On Wed, May 11, 2016 at 05:13:38PM +0800, Dave Young wrote: > > On 05/11/16 at 09:52am, Russell King - ARM Linux wrote: > > > I think you're confusing things. DT doesn't contain the boot alias > > >

Re: [PATCH v15 00/20] arm64 kexec kernel patches v15

2016-05-16 Thread Dave Young
Marc, it has been discussed for long time, I think kdump code can be logically splitted from this series so that we can get the kexec done first? On 04/01/16 at 11:39am, Geoff Levand wrote: > Hi, > > On Fri, 2016-04-01 at 09:59 +0800, Dave Young wrote: > > Geoff, for easier to r

Re: [PATCH v15 00/20] arm64 kexec kernel patches v15

2016-05-17 Thread Dave Young
Hi Marc On 05/17/16 at 09:06am, Marc Zyngier wrote: > Hi Dave, > > On 17/05/16 06:42, Dave Young wrote: > > Marc, it has been discussed for long time, I think kdump code can be > > logically splitted from this series so that we can get the kexec > > done first? &

Re: [PATCH] MAINTAINERS: Kdump maintainers update

2016-05-25 Thread Dave Young
they have been contributing to kdump for a long time now and they are in > > > a much better position to spend time on this than me. > > [] > > > diff --git a/MAINTAINERS b/MAINTAINERS > > [] > > > @@ -6189,8 +6189,9 @@ F: Documentation/kbuild/kconfig-l

Re: [PATCH 0/8] kexec_file_load implementation for PowerPC

2016-06-13 Thread Dave Young
On 06/12/16 at 12:10am, Thiago Jung Bauermann wrote: > Hello, > > This patch series implements the kexec_file_load system call on PowerPC. > > It starts by removing an x86 assumption from kexec_file: kexec_add_buffer uses > iomem to find reserved memory ranges, but PowerPC uses the memblock subsy

Re: [PATCH 1/8] kexec_file: Remove unused members from struct kexec_buf.

2016-06-13 Thread Dave Young
nel/kexec_internal.h > @@ -26,8 +26,6 @@ struct kexec_sha_region { > */ > struct kexec_buf { > struct kimage *image; > - char *buffer; > - unsigned long bufsz; > unsigned long mem; > unsigned long memsz; > un

Re: [PATCH 2/8] kexec_file: Generalize kexec_add_buffer.

2016-06-13 Thread Dave Young
On 06/12/16 at 12:10am, Thiago Jung Bauermann wrote: > Allow architectures to specify different memory walking functions for > kexec_add_buffer. Intel uses iomem to track reserved memory ranges, > but PowerPC uses the memblock subsystem. > > Also, factor kexec_locate_mem_hole out of kexec_add_buff

Re: [PATCH 2/8] kexec_file: Generalize kexec_add_buffer.

2016-06-13 Thread Dave Young
On 06/12/16 at 12:10am, Thiago Jung Bauermann wrote: > Allow architectures to specify different memory walking functions for > kexec_add_buffer. Intel uses iomem to track reserved memory ranges, > but PowerPC uses the memblock subsystem. Can the crashk_res be inserted to iomem_resource so that onl

Re: [PATCH 2/8] kexec_file: Generalize kexec_add_buffer.

2016-06-13 Thread Dave Young
g for > KEXEC_ON_CRASH. > > Am Montag, 13 Juni 2016, 15:29:39 schrieb Dave Young: > > On 06/12/16 at 12:10am, Thiago Jung Bauermann wrote: > > > Allow architectures to specify different memory walking functions for > > > kexec_add_buffer. Intel uses iomem to

Re: [PATCH v2 2/9] kexec_file: Generalize kexec_add_buffer.

2016-06-15 Thread Dave Young
Bauermann > Cc: Eric Biederman > Cc: Dave Young > Cc: kexec@lists.infradead.org > Cc: linux-ker...@vger.kernel.org > --- > include/linux/kexec.h | 3 +++ > kernel/kexec_file.c | 44 > 2 files changed, 39 insertions(+), 8

Re: [PATCH v2 2/9] kexec_file: Generalize kexec_add_buffer.

2016-06-15 Thread Dave Young
On 06/15/16 at 01:21pm, Thiago Jung Bauermann wrote: > Hello Dave, > > Am Mittwoch, 15 Juni 2016, 15:33:02 schrieb Dave Young: > > > @@ -472,14 +498,16 @@ int kexec_add_buffer(struct kimage *image, char > > > *buffer, unsigned long bufsz,> >

Re: [PATCH v2 2/9] kexec_file: Generalize kexec_add_buffer.

2016-06-17 Thread Dave Young
On 06/16/16 at 05:39pm, Thiago Jung Bauermann wrote: > Am Donnerstag, 16 Juni 2016, 09:58:53 schrieb Dave Young: > > On 06/15/16 at 01:21pm, Thiago Jung Bauermann wrote: > > > +/** > > > + * arch_kexec_walk_mem - call func(data) on free memory regions > >

Re: [PATCH v2 2/9] kexec_file: Generalize kexec_add_buffer.

2016-06-19 Thread Dave Young
On 06/17/16 at 05:51pm, Thiago Jung Bauermann wrote: > Am Freitag, 17 Juni 2016, 15:35:23 schrieb Dave Young: > > On 06/16/16 at 05:39pm, Thiago Jung Bauermann wrote: > > > Am Donnerstag, 16 Juni 2016, 09:58:53 schrieb Dave Young: > > > > On 06/15/16 at 01:21p

Re: [PATCH 0/6] kexec_file: Add buffer hand-over for the next kernel

2016-06-21 Thread Dave Young
On 06/20/16 at 10:44pm, Thiago Jung Bauermann wrote: > Hello, > > This patch series implements a mechanism which allows the kernel to pass on > a buffer to the kernel that will be kexec'd. This buffer is passed as a > segment which is added to the kimage when it is being prepared by > kexec_file_l

Re: [PATCH v3 3/9] kexec_file: Factor out kexec_locate_mem_hole from kexec_add_buffer.

2016-06-22 Thread Dave Young
On 06/21/16 at 04:48pm, Thiago Jung Bauermann wrote: > kexec_locate_mem_hole will be used by the PowerPC kexec_file_load > implementation to find free memory for the purgatory stack. > > Signed-off-by: Thiago Jung Bauermann > Cc: Eric Biederman > Cc: Dave Young > Cc: kexe

Re: [PATCH v3 2/9] kexec_file: Generalize kexec_add_buffer.

2016-06-22 Thread Dave Young
ent memory walking functions for > kexec_add_buffer. Intel uses iomem to track reserved memory ranges, > but PowerPC uses the memblock subsystem. > > Signed-off-by: Thiago Jung Bauermann > Cc: Eric Biederman > Cc: Dave Young > Cc: kexec@lists.infradead.org > Cc: l

Re: [PATCH v3 2/9] kexec_file: Generalize kexec_add_buffer.

2016-06-22 Thread Dave Young
On 06/22/16 at 08:30pm, Thiago Jung Bauermann wrote: > Am Mittwoch, 22 Juni 2016, 18:20:47 schrieb Dave Young: > > The patch looks good, but could the subject be more specific? > > > > For example just like the first sentence of the patch descriotion: > > Allow archite

Re: [PATCH v3 3/9] kexec_file: Factor out kexec_locate_mem_hole from kexec_add_buffer.

2016-06-22 Thread Dave Young
On 06/22/16 at 08:34pm, Thiago Jung Bauermann wrote: > Am Mittwoch, 22 Juni 2016, 18:18:01 schrieb Dave Young: > > On 06/21/16 at 04:48pm, Thiago Jung Bauermann wrote: > > > +/** > > > + * kexec_locate_mem_hole - find free memory to load segment or use in > >

Re: [PATCH v3 3/9] kexec_file: Factor out kexec_locate_mem_hole from kexec_add_buffer.

2016-06-22 Thread Dave Young
- Original Message - From: "Dave Young" To: "Thiago Jung Bauermann" Cc: linuxppc-...@lists.ozlabs.org, kexec@lists.infradead.org, linux-ker...@vger.kernel.org, "Eric Biederman" Sent: Thursday, June 23, 2016 10:30:52 AM Subject: Re: [PATCH

Re: [PATCH v3 3/9] kexec_file: Factor out kexec_locate_mem_hole from kexec_add_buffer.

2016-06-27 Thread Dave Young
On 06/23/16 at 12:37pm, Thiago Jung Bauermann wrote: > Am Donnerstag, 23 Juni 2016, 01:44:07 schrieb Dave Young: > > Hmm, hold on. For declaring a struct in a header file, comment should be > > just after each fields, like below, your format is for a function instead: >

[no subject]

2016-06-27 Thread Dave Young
ermann wrote: > Am Dienstag, 28 Juni 2016, 00:19:48 schrieb Dave Young: > > On 06/23/16 at 12:37pm, Thiago Jung Bauermann wrote: > > > Am Donnerstag, 23 Juni 2016, 01:44:07 schrieb Dave Young: > > > What is bad about the description of top_down? > > It is not cle

Re: [PATCH v3 3/9] kexec_file: Factor out kexec_locate_mem_hole from kexec_add_buffer.

2016-06-27 Thread Dave Young
Please ignore previous reply, I mistakenly send a broken mail without subject, sorry about it. Resend the reply here. On 06/27/16 at 01:37pm, Thiago Jung Bauermann wrote: > Am Dienstag, 28 Juni 2016, 00:19:48 schrieb Dave Young: > > On 06/23/16 at 12:37pm, Thiago Jung Bauermann wrote:

Re: [PATCH v3 3/9] kexec_file: Factor out kexec_locate_mem_hole from kexec_add_buffer.

2016-06-28 Thread Dave Young
On 06/27/16 at 04:21pm, Dave Young wrote: > Please ignore previous reply, I mistakenly send a broken mail without > subject, sorry about it. Resend the reply here. > > On 06/27/16 at 01:37pm, Thiago Jung Bauermann wrote: > > Am Dienstag, 28 Juni 2016, 00:19:48 schrieb Dave You

Re: [PATCH v3 3/9] kexec_file: Factor out kexec_locate_mem_hole from kexec_add_buffer.

2016-06-29 Thread Dave Young
On 06/28/16 at 07:18pm, Thiago Jung Bauermann wrote: > Am Dienstag, 28 Juni 2016, 15:20:55 schrieb Dave Young: > > On 06/27/16 at 04:21pm, Dave Young wrote: > > > Please ignore previous reply, I mistakenly send a broken mail without > > > subject, sorry abou

Re: [PATCH v3 2/9] kexec_file: Generalize kexec_add_buffer.

2016-06-29 Thread Dave Young
On 06/28/16 at 07:18pm, Thiago Jung Bauermann wrote: > Am Donnerstag, 23 Juni 2016, 10:25:06 schrieb Dave Young: > > On 06/22/16 at 08:30pm, Thiago Jung Bauermann wrote: > > > Am Mittwoch, 22 Juni 2016, 18:20:47 schrieb Dave Young: > > > > The patch looks good,

Re: [PATCH v20 13/14] arm64: kdump: update a kernel doc

2016-06-30 Thread Dave Young
se following command > to load dump-capture kernel. > @@ -370,6 +380,9 @@ For s390x: > For arm: > "1 maxcpus=1 reset_devices" > > +For arm64: > + "1 maxcpus=1 reset_devices" > + > Notes on loading the dump-capture kernel: > &g

kexec_file_load signature verification failure

2016-06-30 Thread Dave Young
Hi, David kexec_file_load fails with a Bad Message error with recent kernel: kexec_file_load failed: Bad message Debug messages: [ 3463.794391] PEFILE: checksum @ da [ 3463.794395] PEFILE: header size = 200 [ 3463.794397] PEFILE: cert = 898 @4a5370 [97 08 00 00 00 02 02 00 30 82 08 8b 06 09 2a

Re: [PATCH v3 2/9] kexec_file: Generalize kexec_add_buffer.

2016-06-30 Thread Dave Young
On 06/29/16 at 06:18pm, Thiago Jung Bauermann wrote: > Am Mittwoch, 29 Juni 2016, 15:47:51 schrieb Dave Young: > > On 06/28/16 at 07:18pm, Thiago Jung Bauermann wrote: > > > diff --git a/include/linux/kexec.h b/include/linux/kexec.h > > > index e8acb2b43dd9..e16d845d587f

Re: [PATCH v3 3/9] kexec_file: Factor out kexec_locate_mem_hole from kexec_add_buffer.

2016-06-30 Thread Dave Young
On 06/29/16 at 06:09pm, Thiago Jung Bauermann wrote: > Am Mittwoch, 29 Juni 2016, 15:45:18 schrieb Dave Young: > > On 06/28/16 at 07:18pm, Thiago Jung Bauermann wrote: > > > Am Dienstag, 28 Juni 2016, 15:20:55 schrieb Dave Young: > > > > On 06/27/16 at 04:21pm, Dave

Re: [PATCH v3 3/9] kexec_file: Factor out kexec_locate_mem_hole from kexec_add_buffer.

2016-06-30 Thread Dave Young
On 06/30/16 at 01:08pm, Thiago Jung Bauermann wrote: > Am Donnerstag, 30 Juni 2016, 11:41:19 schrieb Dave Young: > > On 06/29/16 at 06:09pm, Thiago Jung Bauermann wrote: > > > Am Mittwoch, 29 Juni 2016, 15:45:18 schrieb Dave Young: > > > > On 06/28/16 at 07:18p

Re: [PATCH v3 2/9] kexec_file: Generalize kexec_add_buffer.

2016-06-30 Thread Dave Young
On 06/30/16 at 01:42pm, Thiago Jung Bauermann wrote: > Am Donnerstag, 30 Juni 2016, 12:49:44 schrieb Thiago Jung Bauermann: > > Am Donnerstag, 30 Juni 2016, 11:07:00 schrieb Dave Young: > > > On 06/29/16 at 06:18pm, Thiago Jung Bauermann wrote: > > > > I'm not

Re: [PATCH v3 2/9] kexec_file: Generalize kexec_add_buffer.

2016-07-01 Thread Dave Young
On 07/01/16 at 02:51pm, Thiago Jung Bauermann wrote: > Am Donnerstag, 30 Juni 2016, 17:43:57 schrieb Dave Young: > > On 06/30/16 at 01:42pm, Thiago Jung Bauermann wrote: > > > Am Donnerstag, 30 Juni 2016, 12:49:44 schrieb Thiago Jung Bauermann: > > > > To be honest

  1   2   3   4   5   6   7   8   9   10   >